All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, x86@kernel.org,
	linux-snps-arc@lists.infradead.org,
	linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN
Date: Mon, 16 Dec 2024 16:41:36 -0800	[thread overview]
Message-ID: <202412161641.8209C666@keescook> (raw)
In-Reply-To: <20241213054610.55843-6-laoar.shao@gmail.com>

On Fri, Dec 13, 2024 at 01:46:08PM +0800, Yafang Shao wrote:
> Since task->comm is guaranteed to be NUL-terminated, we can print it
> directly without the need to copy it into a separate buffer. This
> simplifies the code and avoids unnecessary operations.
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Looks good to me; thanks!

Acked-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <kees@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, x86@kernel.org,
	linux-snps-arc@lists.infradead.org,
	linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN
Date: Mon, 16 Dec 2024 16:41:36 -0800	[thread overview]
Message-ID: <202412161641.8209C666@keescook> (raw)
In-Reply-To: <20241213054610.55843-6-laoar.shao@gmail.com>

On Fri, Dec 13, 2024 at 01:46:08PM +0800, Yafang Shao wrote:
> Since task->comm is guaranteed to be NUL-terminated, we can print it
> directly without the need to copy it into a separate buffer. This
> simplifies the code and avoids unnecessary operations.
> 
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>

Looks good to me; thanks!

Acked-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  parent reply	other threads:[~2024-12-17  0:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  5:46 [PATCH 0/7] vsprintf: Add %pTN to print Task Name Yafang Shao
2024-12-13  5:46 ` Yafang Shao
2024-12-13  5:46 ` [PATCH 1/7] vsprintf: Add %pTN to print task name Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  8:05   ` Petr Mladek
2024-12-13  8:05     ` Petr Mladek
2024-12-13  8:35     ` Kalle Valo
2024-12-13  8:35       ` Kalle Valo
2024-12-13 13:27       ` Borislav Petkov
2024-12-13 13:27         ` Borislav Petkov
2024-12-13 17:11         ` Andy Shevchenko
2024-12-13 17:11           ` Andy Shevchenko
2024-12-13  8:36     ` Yafang Shao
2024-12-13  8:36       ` Yafang Shao
2024-12-13  5:46 ` [PATCH 2/7] kernel: Replace get_task_comm() with %pTN Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 3/7] arch: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 4/7] net: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 5/7] security: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-16 23:02   ` Paul Moore
2024-12-16 23:02     ` Paul Moore
2024-12-17  0:41   ` Kees Cook [this message]
2024-12-17  0:41     ` Kees Cook
2024-12-17  1:08   ` Linus Torvalds
2024-12-17  1:08     ` Linus Torvalds
2024-12-13  5:46 ` [PATCH 6/7] drivers: Repace " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  7:48   ` Jiri Slaby
2024-12-13  7:48     ` Jiri Slaby
2024-12-16 20:33   ` Lyude Paul
2024-12-16 20:33     ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202412161641.8209C666@keescook \
    --to=kees@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jmorris@namei.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.