All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
	 torvalds@linux-foundation.org, akpm@linux-foundation.org,
	 linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,  x86@kernel.org,
	linux-snps-arc@lists.infradead.org,
	 linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	 intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev,
	 Steven Rostedt <rostedt@goodmis.org>,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	 Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	 Sergey Senozhatsky <senozhatsky@chromium.org>,
	 Andy Whitcroft <apw@canonical.com>,
	 Joe Perches <joe@perches.com>,
	 Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH 1/7] vsprintf: Add %pTN to print task name
Date: Fri, 13 Dec 2024 10:35:03 +0200	[thread overview]
Message-ID: <87r06crnew.fsf@kernel.org> (raw)
In-Reply-To: <Z1vq2-V7vB5KhBR9@pathway.suse.cz> (Petr Mladek's message of "Fri, 13 Dec 2024 09:05:47 +0100")

Petr Mladek <pmladek@suse.com> writes:

> On Fri 2024-12-13 13:46:04, Yafang Shao wrote:
>> Since the task->comm is guaranteed to be NUL-ternimated, we can print it
>> directly. Add a new vsnprintf format specifier "%pTN" to print task comm,
>> where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots
>> Name. With this abstraction, the user no longer needs to care about
>> retrieving task name.
>
> What is the advantage, please?
>
> Honestly, I believe that the meaning of
>
> 	printk("%s\n", task->comm);
>
> is much more clear than using a cryptic %pXYZ modifier:
>
> 	printk("%pTN\n", task);
>
>
> The %pXYZ modifiers makes sense only when the formatting of the printed
> information needs some processing. But this is a plain string.
> IMHO, it is not worth it. In fact, I believe that it is a
> counter productive.

I agree, it makes the code harder to read for someone who is not
familiar with all the %p magic we have (like me).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
	 torvalds@linux-foundation.org, akpm@linux-foundation.org,
	 linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,  x86@kernel.org,
	linux-snps-arc@lists.infradead.org,
	 linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	 intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	 dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev,
	 Steven Rostedt <rostedt@goodmis.org>,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	 Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	 Sergey Senozhatsky <senozhatsky@chromium.org>,
	 Andy Whitcroft <apw@canonical.com>,
	 Joe Perches <joe@perches.com>,
	 Dwaipayan Ray <dwaipayanray1@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH 1/7] vsprintf: Add %pTN to print task name
Date: Fri, 13 Dec 2024 10:35:03 +0200	[thread overview]
Message-ID: <87r06crnew.fsf@kernel.org> (raw)
In-Reply-To: <Z1vq2-V7vB5KhBR9@pathway.suse.cz> (Petr Mladek's message of "Fri, 13 Dec 2024 09:05:47 +0100")

Petr Mladek <pmladek@suse.com> writes:

> On Fri 2024-12-13 13:46:04, Yafang Shao wrote:
>> Since the task->comm is guaranteed to be NUL-ternimated, we can print it
>> directly. Add a new vsnprintf format specifier "%pTN" to print task comm,
>> where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots
>> Name. With this abstraction, the user no longer needs to care about
>> retrieving task name.
>
> What is the advantage, please?
>
> Honestly, I believe that the meaning of
>
> 	printk("%s\n", task->comm);
>
> is much more clear than using a cryptic %pXYZ modifier:
>
> 	printk("%pTN\n", task);
>
>
> The %pXYZ modifiers makes sense only when the formatting of the printed
> information needs some processing. But this is a plain string.
> IMHO, it is not worth it. In fact, I believe that it is a
> counter productive.

I agree, it makes the code harder to read for someone who is not
familiar with all the %p magic we have (like me).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

  reply	other threads:[~2024-12-13  8:35 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  5:46 [PATCH 0/7] vsprintf: Add %pTN to print Task Name Yafang Shao
2024-12-13  5:46 ` Yafang Shao
2024-12-13  5:46 ` [PATCH 1/7] vsprintf: Add %pTN to print task name Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  8:05   ` Petr Mladek
2024-12-13  8:05     ` Petr Mladek
2024-12-13  8:35     ` Kalle Valo [this message]
2024-12-13  8:35       ` Kalle Valo
2024-12-13 13:27       ` Borislav Petkov
2024-12-13 13:27         ` Borislav Petkov
2024-12-13 17:11         ` Andy Shevchenko
2024-12-13 17:11           ` Andy Shevchenko
2024-12-13  8:36     ` Yafang Shao
2024-12-13  8:36       ` Yafang Shao
2024-12-13  5:46 ` [PATCH 2/7] kernel: Replace get_task_comm() with %pTN Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 3/7] arch: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 4/7] net: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  5:46 ` [PATCH 5/7] security: " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-16 23:02   ` Paul Moore
2024-12-16 23:02     ` Paul Moore
2024-12-17  0:41   ` Kees Cook
2024-12-17  0:41     ` Kees Cook
2024-12-17  1:08   ` Linus Torvalds
2024-12-17  1:08     ` Linus Torvalds
2024-12-13  5:46 ` [PATCH 6/7] drivers: Repace " Yafang Shao
2024-12-13  5:46   ` Yafang Shao
2024-12-13  7:48   ` Jiri Slaby
2024-12-13  7:48     ` Jiri Slaby
2024-12-16 20:33   ` Lyude Paul
2024-12-16 20:33     ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r06crnew.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apw@canonical.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joe@perches.com \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=lukas.bulwahn@gmail.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.