All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Simon Glass <sjg@chromium.org>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Martyn Welch <martyn.welch@collabora.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Tom Rini <trini@konsulko.com>
Subject: [PATCH 3/5] pxe_utils: Allow the FDT to be missing
Date: Thu, 19 Dec 2024 21:01:18 -0700	[thread overview]
Message-ID: <20241220040120.3245610-4-sjg@chromium.org> (raw)
In-Reply-To: <20241220040120.3245610-1-sjg@chromium.org>

The devicetree file may not be provided, so avoid a failure in that
case.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 boot/pxe_utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c
index 3a4caa9329a..8bebf4ec925 100644
--- a/boot/pxe_utils.c
+++ b/boot/pxe_utils.c
@@ -799,7 +799,7 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
 		}
 		unmap_sysmem(buf);
 	}
-	if (ctx->bflow)
+	if (ctx->bflow && conf_fdt)
 		ctx->bflow->fdt_addr = hextoul(conf_fdt, NULL);
 
 	if (IS_ENABLED(CONFIG_BOOTSTD_FULL) && ctx->no_boot) {
@@ -819,7 +819,7 @@ static int label_boot(struct pxe_context *ctx, struct pxe_label *label)
 				  ctx->initrd_addr_str, ctx->initrd_filesize,
 				  ctx->initrd_str);
 		}
-		if (!ctx->kernel_addr || !ctx->conf_fdt ||
+		if (!ctx->kernel_addr || (conf_fdt && !ctx->conf_fdt) ||
 		    (initrd_addr_str && (!ctx->initrd_addr_str ||
 		     !ctx->initrd_filesize || !ctx->initrd_str))) {
 			printf("malloc fail (saving label)\n");
-- 
2.34.1


  parent reply	other threads:[~2024-12-20  4:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  4:01 [PATCH 0/5] pxe: Support an automatic localboot Simon Glass
2024-12-20  4:01 ` [PATCH 1/5] test/py: Refactor extlinux-image creation into a function Simon Glass
2024-12-20  4:01 ` [PATCH 2/5] test: bootflow: Avoid a confusing error condition Simon Glass
2024-12-20  4:01 ` Simon Glass [this message]
2024-12-20 14:45   ` [PATCH 3/5] pxe_utils: Allow the FDT to be missing Tom Rini
2025-01-14 15:13   ` Quentin Schulz
2025-01-15  1:16     ` Simon Glass
2025-01-15 11:59       ` Quentin Schulz
2025-01-15 13:19         ` Simon Glass
2024-12-20  4:01 ` [PATCH 4/5] pxe_utils: Support a backup for localboot Simon Glass
2024-12-20 14:56   ` Tom Rini
2024-12-20 17:18     ` Simon Glass
2024-12-20 17:23       ` Tom Rini
2024-12-20 17:37         ` Simon Glass
2024-12-20 20:48           ` Tom Rini
2025-01-08 17:04             ` Simon Glass
2025-01-08 17:31               ` Tom Rini
2025-01-09 12:31                 ` Simon Glass
2024-12-20  4:01 ` [PATCH 5/5] pxe_utils: Support the SAY command Simon Glass
2024-12-20 14:44   ` Tom Rini
2024-12-20 17:36     ` Simon Glass
2024-12-20 18:30       ` Tom Rini
2024-12-20 19:34         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241220040120.3245610-4-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=martyn.welch@collabora.com \
    --cc=michael@amarulasolutions.com \
    --cc=quentin.schulz@cherry.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.