From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Caleb Connolly <caleb.connolly@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Julien Masson <jmasson@baylibre.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Martyn Welch <martyn.welch@collabora.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Richard Weinberger <richard@nod.at>,
Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH 4/5] pxe_utils: Support a backup for localboot
Date: Fri, 20 Dec 2024 08:56:09 -0600 [thread overview]
Message-ID: <20241220145609.GD1505244@bill-the-cat> (raw)
In-Reply-To: <20241220040120.3245610-5-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Thu, Dec 19, 2024 at 09:01:19PM -0700, Simon Glass wrote:
> The current localboot implementation assumes that a 'localcmd'
> environment variable is provided, with the instructions to follow. This
> may not be included, so provide a fallback in that case.
>
> Add a test image and test as well.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
This is a pretty niche feature, I had to dig around a bit to see how
it's specified elsewhere (not really) and how it's used. And I think
that based on how it's used, making up a bootcmd when localcmd is
undefined is the wrong approach. It's the hook for "run what I defined
in the environment", so if not set erroring back out seems appropriate.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-12-20 14:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 4:01 [PATCH 0/5] pxe: Support an automatic localboot Simon Glass
2024-12-20 4:01 ` [PATCH 1/5] test/py: Refactor extlinux-image creation into a function Simon Glass
2024-12-20 4:01 ` [PATCH 2/5] test: bootflow: Avoid a confusing error condition Simon Glass
2024-12-20 4:01 ` [PATCH 3/5] pxe_utils: Allow the FDT to be missing Simon Glass
2024-12-20 14:45 ` Tom Rini
2025-01-14 15:13 ` Quentin Schulz
2025-01-15 1:16 ` Simon Glass
2025-01-15 11:59 ` Quentin Schulz
2025-01-15 13:19 ` Simon Glass
2024-12-20 4:01 ` [PATCH 4/5] pxe_utils: Support a backup for localboot Simon Glass
2024-12-20 14:56 ` Tom Rini [this message]
2024-12-20 17:18 ` Simon Glass
2024-12-20 17:23 ` Tom Rini
2024-12-20 17:37 ` Simon Glass
2024-12-20 20:48 ` Tom Rini
2025-01-08 17:04 ` Simon Glass
2025-01-08 17:31 ` Tom Rini
2025-01-09 12:31 ` Simon Glass
2024-12-20 4:01 ` [PATCH 5/5] pxe_utils: Support the SAY command Simon Glass
2024-12-20 14:44 ` Tom Rini
2024-12-20 17:36 ` Simon Glass
2024-12-20 18:30 ` Tom Rini
2024-12-20 19:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220145609.GD1505244@bill-the-cat \
--to=trini@konsulko.com \
--cc=ansuelsmth@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=francis.laniel@amarulasolutions.com \
--cc=glaroque@baylibre.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jmasson@baylibre.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=martyn.welch@collabora.com \
--cc=michael@amarulasolutions.com \
--cc=mkorpershoek@baylibre.com \
--cc=patrick.rudolph@9elements.com \
--cc=quentin.schulz@cherry.de \
--cc=richard@nod.at \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.