Re: [PATCH 4/5] pxe_utils: Support a backup for localboot

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

On Fri, Dec 20, 2024 at 10:18:17AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, 20 Dec 2024 at 07:56, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Dec 19, 2024 at 09:01:19PM -0700, Simon Glass wrote:
> >
> > > The current localboot implementation assumes that a 'localcmd'
> > > environment variable is provided, with the instructions to follow. This
> > > may not be included, so provide a fallback in that case.
> > >
> > > Add a test image and test as well.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > This is a pretty niche feature, I had to dig around a bit to see how
> > it's specified elsewhere (not really) and how it's used. And I think
> > that based on how it's used, making up a bootcmd when localcmd is
> > undefined is the wrong approach. It's the hook for "run what I defined
> > in the environment", so if not set erroring back out seems appropriate.
> 
> Yes, but unfortunately it seems to be used and we should support it.
> The problem with scripts is that we don't know the boot device, etc,
> so it needs to be integrated into PXE. I did consider putting
> something in bootstd, but we only find out that it is requesting a
> localboot when actually running the extlinux bootmeth, so this is what
> I came up with.
> 
> It will be interesting to see if any other cases come up.

It would be helpful at this point I think if you can point to how the
code for handling this case (the LOCALBOOT keyword followed by an
integer) in other projects so that we can be compliant with what's
expected, even if it's poorly documented.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]