From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
jason.andryuk@amd.com, christopher.w.clark@gmail.com,
stefano.stabellini@amd.com, "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>
Subject: [PATCH v2 13/15] x86/hyperlaunch: add memory parsing to domain config
Date: Thu, 26 Dec 2024 11:57:38 -0500 [thread overview]
Message-ID: <20241226165740.29812-14-dpsmith@apertussolutions.com> (raw)
In-Reply-To: <20241226165740.29812-1-dpsmith@apertussolutions.com>
Add three properties, memory, mem-min, and mem-max, to the domain node device
tree parsing to define the memory allocation for a domain. All three fields are
expressed in kb and written as a u64 in the device tree entries.
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
Changes since v1
- moved common fdt parsing to libfdt
- dropped ternary for name selection
- swtich over from match_fdt to strncmp
- change mem prints to kb
---
xen/arch/x86/dom0_build.c | 8 +++++++
xen/arch/x86/domain-builder/fdt.c | 34 +++++++++++++++++++++++++++
xen/arch/x86/include/asm/bootdomain.h | 4 ++++
xen/include/xen/libfdt/libfdt-xen.h | 9 +++++++
4 files changed, 55 insertions(+)
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index c231191faec7..1c3b7ff0e658 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -609,6 +609,14 @@ int __init construct_dom0(struct boot_domain *bd)
process_pending_softirqs();
+ /* If param dom0_size was not set and HL config provided memory size */
+ if ( !get_memsize(&dom0_size, LONG_MAX) && bd->mem_pages )
+ dom0_size.nr_pages = bd->mem_pages;
+ if ( !get_memsize(&dom0_min_size, LONG_MAX) && bd->min_pages )
+ dom0_size.nr_pages = bd->min_pages;
+ if ( !get_memsize(&dom0_max_size, LONG_MAX) && bd->max_pages )
+ dom0_size.nr_pages = bd->max_pages;
+
if ( is_hvm_domain(d) )
rc = dom0_construct_pvh(bd);
else if ( is_pv_domain(d) )
diff --git a/xen/arch/x86/domain-builder/fdt.c b/xen/arch/x86/domain-builder/fdt.c
index db584ba78e92..aff1b8c3235d 100644
--- a/xen/arch/x86/domain-builder/fdt.c
+++ b/xen/arch/x86/domain-builder/fdt.c
@@ -6,6 +6,7 @@
#include <xen/init.h>
#include <xen/lib.h>
#include <xen/libfdt/libfdt.h>
+#include <xen/sizes.h>
#include <asm/bootinfo.h>
#include <asm/guest.h>
@@ -113,6 +114,39 @@ static int __init process_domain_node(
else
printk("PV\n");
}
+ else if ( strncmp(prop_name, "memory", name_len) == 0 )
+ {
+ uint64_t kb;
+ if ( fdt_prop_as_u64(prop, &kb) != 0 )
+ {
+ printk(" failed processing memory for domain %s\n", name);
+ return -EINVAL;
+ }
+ bd->mem_pages = PFN_DOWN(kb * SZ_1K);
+ printk(" memory: %ld kb\n", kb);
+ }
+ else if ( strncmp(prop_name, "mem-min", name_len) == 0 )
+ {
+ uint64_t kb;
+ if ( fdt_prop_as_u64(prop, &kb) != 0 )
+ {
+ printk(" failed processing memory for domain %s\n", name);
+ return -EINVAL;
+ }
+ bd->min_pages = PFN_DOWN(kb * SZ_1K);
+ printk(" min memory: %ld kb\n", kb);
+ }
+ else if ( strncmp(prop_name, "mem-max", name_len) == 0 )
+ {
+ uint64_t kb;
+ if ( fdt_prop_as_u64(prop, &kb) != 0 )
+ {
+ printk(" failed processing memory for domain %s\n", name);
+ return -EINVAL;
+ }
+ bd->max_pages = PFN_DOWN(kb * SZ_1K);
+ printk(" max memory: %ld kb\n", kb);
+ }
}
fdt_for_each_subnode(node, fdt, dom_node)
diff --git a/xen/arch/x86/include/asm/bootdomain.h b/xen/arch/x86/include/asm/bootdomain.h
index 5918aaf6bb63..d7092bc32ad7 100644
--- a/xen/arch/x86/include/asm/bootdomain.h
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -20,6 +20,10 @@ struct boot_domain {
#define BUILD_MODE_ENABLE_DM (1 << 1) /* HVM | PVH */
uint32_t mode;
+ unsigned long mem_pages;
+ unsigned long min_pages;
+ unsigned long max_pages;
+
struct boot_module *kernel;
struct boot_module *ramdisk;
diff --git a/xen/include/xen/libfdt/libfdt-xen.h b/xen/include/xen/libfdt/libfdt-xen.h
index 2057030dda45..3b653e626842 100644
--- a/xen/include/xen/libfdt/libfdt-xen.h
+++ b/xen/include/xen/libfdt/libfdt-xen.h
@@ -37,6 +37,15 @@ static inline int __init fdt_prop_as_u32(
return fdt_cell_as_u32((fdt32_t *)prop->data, val);
}
+static inline int __init fdt_prop_as_u64(
+ const struct fdt_property *prop, uint64_t *val)
+{
+ if ( !prop || fdt32_to_cpu(prop->len) < sizeof(u64) )
+ return -EINVAL;
+
+ return fdt_cell_as_u64((fdt32_t *)prop->data, val);
+}
+
static inline int __init fdt_get_prop_by_offset(
const void *fdt, int node, const char *name, unsigned long *offset)
{
--
2.30.2
next prev parent reply other threads:[~2024-12-26 17:00 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 16:57 [PATCH v2 00/15] Hyperlaunch device tree for dom0 Daniel P. Smith
2024-12-26 16:57 ` [PATCH v2 01/15] x86/boot: introduce boot domain Daniel P. Smith
2025-01-30 13:45 ` Jan Beulich
2025-04-05 0:04 ` Daniel P. Smith
2025-04-07 7:10 ` Jan Beulich
2025-04-09 23:55 ` Daniel P. Smith
2025-04-10 6:37 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 02/15] x86/boot: introduce domid field to struct boot_domain Daniel P. Smith
2025-01-30 13:51 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 03/15] x86/boot: add cmdline " Daniel P. Smith
2025-01-10 19:52 ` Jason Andryuk
2025-01-15 17:22 ` Daniel P. Smith
2025-01-15 19:50 ` Jason Andryuk
2025-01-30 14:15 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 04/15] kconfig: introduce option to independently enable libfdt Daniel P. Smith
2025-01-30 14:19 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 05/15] kconfig: introduce domain builder config option Daniel P. Smith
2025-01-10 19:55 ` Jason Andryuk
2025-01-15 17:24 ` Daniel P. Smith
2025-01-30 14:30 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 06/15] x86/hyperlaunch: introduce the domain builder Daniel P. Smith
2025-01-08 21:54 ` Jason Andryuk
2025-01-15 17:25 ` Daniel P. Smith
2025-01-30 14:52 ` Jan Beulich
2025-04-01 18:01 ` Jason Andryuk
2025-04-02 9:25 ` Jan Beulich
2025-04-02 19:44 ` Jason Andryuk
2024-12-26 16:57 ` [PATCH v2 07/15] x86/hyperlaunch: initial support for hyperlaunch device tree Daniel P. Smith
2025-01-10 22:20 ` Jason Andryuk
2025-01-15 17:47 ` Daniel P. Smith
2025-01-30 15:01 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 08/15] x86/hyperlaunch: locate dom0 kernel with hyperlaunch Daniel P. Smith
2025-01-10 23:06 ` Jason Andryuk
2025-01-30 15:42 ` Jan Beulich
2025-01-30 21:14 ` Stefano Stabellini
2025-01-31 6:36 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 09/15] x86/hyperlaunch: obtain cmdline from device tree Daniel P. Smith
2025-01-15 16:38 ` Jason Andryuk
2025-01-30 15:58 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 10/15] x86/hyperlaunch: locate dom0 initrd with hyperlaunch Daniel P. Smith
2025-01-15 16:43 ` Jason Andryuk
2025-01-30 16:39 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 11/15] x86/hyperlaunch: add domain id parsing to domain config Daniel P. Smith
2025-01-30 16:49 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 12/15] x86/hyperlaunch: specify dom0 mode with device tree Daniel P. Smith
2025-01-15 19:42 ` Jason Andryuk
2025-01-30 16:55 ` Jan Beulich
2024-12-26 16:57 ` Daniel P. Smith [this message]
2025-01-15 16:55 ` [PATCH v2 13/15] x86/hyperlaunch: add memory parsing to domain config Jason Andryuk
2025-01-30 17:01 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 14/15] x86/hyperlaunch: add max vcpu parsing of hyperlaunch device tree Daniel P. Smith
2025-01-15 19:40 ` Jason Andryuk
2025-01-30 17:04 ` Jan Beulich
2024-12-26 16:57 ` [PATCH v2 15/15] x86/hyperlaunch: add capabilities to boot domain Daniel P. Smith
2025-02-04 11:13 ` Jan Beulich
2025-02-04 15:40 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241226165740.29812-14-dpsmith@apertussolutions.com \
--to=dpsmith@apertussolutions.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=christopher.w.clark@gmail.com \
--cc=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.