Re: [PATCH v2 06/15] x86/hyperlaunch: introduce the domain builder

[Jason Andryuk <jason.andryuk@amd.com>]

On 2025-04-02 05:25, Jan Beulich wrote:
> On 01.04.2025 20:01, Jason Andryuk wrote:
>> On 2025-01-30 09:52, Jan Beulich wrote:
>>> On 26.12.2024 17:57, Daniel P. Smith wrote:
>>>> --- a/xen/arch/x86/Makefile
>>>> +++ b/xen/arch/x86/Makefile
>>>> @@ -81,6 +81,8 @@ obj-$(CONFIG_COMPAT) += x86_64/platform_hypercall.o
>>>>    obj-y += sysctl.o
>>>>    endif
>>>>    
>>>> +obj-y += domain-builder/
>>>
>>> The set of subdirs needed in $(obj-y) is specified at the top of the file.
>>> Also shouldn't this be obj-$(CONFIG_DOMAIN_BUILDER)?
>>
>> Later, all boot-time domain building is handled by
>> domain-builder/core.c.  So some of domain-builder/ is always built, and
>> Kconfig disables multidomain support.
> 
> Then CONFIG_DOMAIN_BUILDER is a misnomer?

Dan also adds CONFIG_MULTIDOMAIN_BUILDER later... which is used only for:
-    BUG_ON(!pv_shim && d->domain_id != 0);
+    if ( ! IS_ENABLED(CONFIG_MULTIDOMAIN_BUILDER) )
+        BUG_ON(!pv_shim && d->domain_id != 0);

:(

I thought it at least restricted the size of the boot domains array.

-Jason