* [PATCH] drm: crtc-helper: Remove useless loop
@ 2014-05-28 12:43 Laurent Pinchart
2014-05-28 13:36 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-28 12:43 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, Dave Airlie
Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
disable disconnected outputs") made the for each loop over connectors
empty in __drm_helper_disable_unused_functions(). Remove the loop
altogether.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/drm_crtc_helper.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index df281b5..fbc3aa7 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -145,11 +145,6 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
drm_warn_on_modeset_not_all_locked(dev);
- list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
- if (!connector->encoder)
- continue;
- }
-
list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
if (!drm_helper_encoder_in_use(encoder)) {
drm_encoder_disable(encoder);
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: crtc-helper: Remove useless loop
2014-05-28 12:43 [PATCH] drm: crtc-helper: Remove useless loop Laurent Pinchart
@ 2014-05-28 13:36 ` Daniel Vetter
2014-05-28 14:35 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2014-05-28 13:36 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Daniel Vetter, dri-devel, Dave Airlie
On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> disable disconnected outputs") made the for each loop over connectors
> empty in __drm_helper_disable_unused_functions(). Remove the loop
> altogether.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Isn't the local variable connector now unused? At least that's what my old
patch did:
http://patchwork.freedesktop.org/patch/24184/
/me looks at Dave ...
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index df281b5..fbc3aa7 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -145,11 +145,6 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
>
> drm_warn_on_modeset_not_all_locked(dev);
>
> - list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
> - if (!connector->encoder)
> - continue;
> - }
> -
> list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
> if (!drm_helper_encoder_in_use(encoder)) {
> drm_encoder_disable(encoder);
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: crtc-helper: Remove useless loop
2014-05-28 13:36 ` Daniel Vetter
@ 2014-05-28 14:35 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-28 14:35 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Laurent Pinchart, dri-devel, Dave Airlie
Hi Daniel,
On Wednesday 28 May 2014 15:36:38 Daniel Vetter wrote:
> On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:
> > Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't
> > disable disconnected outputs") made the for each loop over connectors
> > empty in __drm_helper_disable_unused_functions(). Remove the loop
> > altogether.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Isn't the local variable connector now unused?
Yes it is. Missing hunk in my patch, sorry about that :-/
> At least that's what my old patch did:
>
> http://patchwork.freedesktop.org/patch/24184/
Looks like I've missed it. Sorry for the noise.
> /me looks at Dave ...
>
> Cheers, Daniel
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-28 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28 12:43 [PATCH] drm: crtc-helper: Remove useless loop Laurent Pinchart
2014-05-28 13:36 ` Daniel Vetter
2014-05-28 14:35 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.