All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Ondrej Jirman <megi@xff.cz>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [RFC 4/7] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Ultra
Date: Thu, 2 Jan 2025 15:53:08 -0600	[thread overview]
Message-ID: <20250102215308.GA636148-robh@kernel.org> (raw)
In-Reply-To: <20241229184256.1870-8-honyuenkwun@gmail.com>

On Sun, Dec 29, 2024 at 12:41:31PM -0600, Jimmy Hon wrote:
> Add devicetree binding for the Xunlong Orange Pi 5 Ultra board.

Why RFC? Looks fine to me.

However, you should have 'v4' on every patch in the series if this is 
v4.

> 
> The Orange Pi 5 Ultra is a single board computer powered by the Rockchip
> RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped
> for HDMI IN.
> 
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 2a141d99c533..9dd424265826 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1075,11 +1075,12 @@ properties:
>            - const: xunlong,orangepi-3b
>            - const: rockchip,rk3566
>  
> -      - description: Xunlong Orange Pi 5 Max/Plus
> +      - description: Xunlong Orange Pi 5 Max/Plus/Ultra
>          items:
>            - enum:
>                - xunlong,orangepi-5-max
>                - xunlong,orangepi-5-plus
> +              - xunlong,orangepi-5-ultra
>            - const: rockchip,rk3588
>  
>        - description: Xunlong Orange Pi R1 Plus / LTS
> -- 
> 2.47.1
> 


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Ondrej Jirman <megi@xff.cz>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [RFC 4/7] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Ultra
Date: Thu, 2 Jan 2025 15:53:08 -0600	[thread overview]
Message-ID: <20250102215308.GA636148-robh@kernel.org> (raw)
In-Reply-To: <20241229184256.1870-8-honyuenkwun@gmail.com>

On Sun, Dec 29, 2024 at 12:41:31PM -0600, Jimmy Hon wrote:
> Add devicetree binding for the Xunlong Orange Pi 5 Ultra board.

Why RFC? Looks fine to me.

However, you should have 'v4' on every patch in the series if this is 
v4.

> 
> The Orange Pi 5 Ultra is a single board computer powered by the Rockchip
> RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped
> for HDMI IN.
> 
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 2a141d99c533..9dd424265826 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1075,11 +1075,12 @@ properties:
>            - const: xunlong,orangepi-3b
>            - const: rockchip,rk3566
>  
> -      - description: Xunlong Orange Pi 5 Max/Plus
> +      - description: Xunlong Orange Pi 5 Max/Plus/Ultra
>          items:
>            - enum:
>                - xunlong,orangepi-5-max
>                - xunlong,orangepi-5-plus
> +              - xunlong,orangepi-5-ultra
>            - const: rockchip,rk3588
>  
>        - description: Xunlong Orange Pi R1 Plus / LTS
> -- 
> 2.47.1
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-01-02 21:54 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-29 18:41 [PATCH v4 0/7] arm64: dts: rockchip: Orange Pi 5 Max board Jimmy Hon
2024-12-29 18:41 ` Jimmy Hon
2024-12-29 18:41 ` [PATCH 1/7] arm64: dts: rockchip: refactor common rk3588-orangepi-5.dtsi Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-29 19:20   ` Jimmy Hon
2024-12-29 19:20     ` Jimmy Hon
2024-12-31  0:27     ` Heiko Stuebner
2024-12-31  0:27       ` Heiko Stuebner
2024-12-29 18:41 ` [PATCH 2/7] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Max Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-29 18:41 ` [PATCH 3/7] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-29 18:41 ` [RFC 4/7] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Ultra Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2025-01-02 21:53   ` Rob Herring [this message]
2025-01-02 21:53     ` Rob Herring
2025-01-03  0:18     ` Jimmy Hon
2025-01-03  0:18       ` Jimmy Hon
2024-12-29 18:41 ` [RFC 5/7] arm64: dts: rockchip: Add Orange Pi 5 Ultra board Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-29 19:06   ` Jimmy Hon
2024-12-29 19:06     ` Jimmy Hon
2024-12-29 18:41 ` [PATCH 6/7] arm64: dts: rockchip: Enable HDMI1 on Orange Pi 5 Max Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-29 19:12   ` Jimmy Hon
2024-12-29 19:12     ` Jimmy Hon
2024-12-30  3:04   ` kernel test robot
2024-12-30  3:04     ` kernel test robot
2025-01-04  7:23   ` kernel test robot
2025-01-04  7:23     ` kernel test robot
2024-12-29 18:41 ` [PATCH UNTESTED 7/7] arm64: dts: rockchip: Enable HDMI1 on Orange Pi 5 Plus Jimmy Hon
2024-12-29 18:41   ` Jimmy Hon
2024-12-30  5:07   ` kernel test robot
2024-12-30  5:07     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250102215308.GA636148-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=honyuenkwun@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=megi@xff.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.