All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	qemu-arm@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Jean-Christophe Dubois" <jcd@tribudubois.net>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	qemu-block@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate
Date: Sat, 11 Jan 2025 19:36:59 +0100	[thread overview]
Message-ID: <20250111183711.2338-2-shentey@gmail.com> (raw)
In-Reply-To: <20250111183711.2338-1-shentey@gmail.com>

In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and
"DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU
currently misses to set the DMA bit which causes the driver to loop forever. Fix
that by setting the DMA bit if enabled when doing DMA block transfers.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/sd/sdhci.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 299cd4bc1b..a958c11497 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -665,12 +665,13 @@ static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s)
         }
     }
 
+    if (s->norintstsen & SDHC_NISEN_DMA) {
+        s->norintsts |= SDHC_NIS_DMA;
+    }
+
     if (s->blkcnt == 0) {
         sdhci_end_transfer(s);
     } else {
-        if (s->norintstsen & SDHC_NISEN_DMA) {
-            s->norintsts |= SDHC_NIS_DMA;
-        }
         sdhci_update_irq(s);
     }
 }
@@ -691,6 +692,10 @@ static void sdhci_sdma_transfer_single_block(SDHCIState *s)
     }
     s->blkcnt--;
 
+    if (s->norintstsen & SDHC_NISEN_DMA) {
+        s->norintsts |= SDHC_NIS_DMA;
+    }
+
     sdhci_end_transfer(s);
 }
 
-- 
2.48.0


  reply	other threads:[~2025-01-11 18:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11 18:36 [PATCH v2 00/13] i.MX and SDHCI improvements Bernhard Beschow
2025-01-11 18:36 ` Bernhard Beschow [this message]
2025-01-15 12:55   ` [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate Michael Tokarev
2025-01-16 23:39     ` Bernhard Beschow
2025-01-17  7:11       ` Michael Tokarev
2025-01-11 18:37 ` [PATCH v2 02/13] hw/char/imx_serial: Fix reset value of UFCR register Bernhard Beschow
2025-01-27 13:18   ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 03/13] hw/char/imx_serial: Update all state before restarting ageing timer Bernhard Beschow
2025-01-27 13:19   ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 04/13] hw/pci-host/designware: Expose MSI IRQ Bernhard Beschow
2025-01-27 13:30   ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 05/13] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset Bernhard Beschow
2025-01-27 13:47   ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 06/13] hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs Bernhard Beschow
2025-01-27 13:24   ` Peter Maydell
2025-01-27 23:11     ` Bernhard Beschow
2025-01-28 10:34       ` Peter Maydell
2025-01-28 22:45         ` Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 07/13] hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOs Bernhard Beschow
2025-01-15 17:32   ` Philippe Mathieu-Daudé
2025-01-17  9:29     ` Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 08/13] hw/char/imx_serial: Turn some DPRINTF() statements into trace events Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 09/13] hw/timer/imx_gpt: Remove unused define Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 10/13] tests/qtest/libqos: Reuse TYPE_IMX_I2C define Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 11/13] hw/i2c/imx_i2c: Convert DPRINTF() to trace events Bernhard Beschow
2025-01-14 13:34   ` Corey Minyard
2025-01-11 18:37 ` [PATCH v2 12/13] hw/misc/imx6_src: " Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 13/13] hw/gpio/imx_gpio: Turn DPRINTF() into " Bernhard Beschow
2025-01-14 12:46 ` [PATCH v2 00/13] i.MX and SDHCI improvements Bernhard Beschow
2025-01-27 13:54 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250111183711.2338-2-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=bmeng.cn@gmail.com \
    --cc=farosas@suse.de \
    --cc=jcd@tribudubois.net \
    --cc=linux@roeck-us.net \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.