From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
qemu-arm@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
qemu-block@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 05/13] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset
Date: Sat, 11 Jan 2025 19:37:03 +0100 [thread overview]
Message-ID: <20250111183711.2338-6-shentey@gmail.com> (raw)
In-Reply-To: <20250111183711.2338-1-shentey@gmail.com>
Input GPIO values such as a present SD card may get notified before the GPIO
controller itself gets reset. Claring the input values thus loses data. Assuming
that input GPIO events are only fired when the state changes, the input values
shouldn't be reset.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/gpio/imx_gpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
index 898f80f8c8..67c47a7280 100644
--- a/hw/gpio/imx_gpio.c
+++ b/hw/gpio/imx_gpio.c
@@ -302,7 +302,6 @@ static void imx_gpio_reset(DeviceState *dev)
s->dr = 0;
s->gdir = 0;
- s->psr = 0;
s->icr = 0;
s->imr = 0;
s->isr = 0;
--
2.48.0
next prev parent reply other threads:[~2025-01-11 18:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 18:36 [PATCH v2 00/13] i.MX and SDHCI improvements Bernhard Beschow
2025-01-11 18:36 ` [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate Bernhard Beschow
2025-01-15 12:55 ` Michael Tokarev
2025-01-16 23:39 ` Bernhard Beschow
2025-01-17 7:11 ` Michael Tokarev
2025-01-11 18:37 ` [PATCH v2 02/13] hw/char/imx_serial: Fix reset value of UFCR register Bernhard Beschow
2025-01-27 13:18 ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 03/13] hw/char/imx_serial: Update all state before restarting ageing timer Bernhard Beschow
2025-01-27 13:19 ` Peter Maydell
2025-01-11 18:37 ` [PATCH v2 04/13] hw/pci-host/designware: Expose MSI IRQ Bernhard Beschow
2025-01-27 13:30 ` Peter Maydell
2025-01-11 18:37 ` Bernhard Beschow [this message]
2025-01-27 13:47 ` [PATCH v2 05/13] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset Peter Maydell
2025-01-11 18:37 ` [PATCH v2 06/13] hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs Bernhard Beschow
2025-01-27 13:24 ` Peter Maydell
2025-01-27 23:11 ` Bernhard Beschow
2025-01-28 10:34 ` Peter Maydell
2025-01-28 22:45 ` Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 07/13] hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOs Bernhard Beschow
2025-01-15 17:32 ` Philippe Mathieu-Daudé
2025-01-17 9:29 ` Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 08/13] hw/char/imx_serial: Turn some DPRINTF() statements into trace events Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 09/13] hw/timer/imx_gpt: Remove unused define Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 10/13] tests/qtest/libqos: Reuse TYPE_IMX_I2C define Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 11/13] hw/i2c/imx_i2c: Convert DPRINTF() to trace events Bernhard Beschow
2025-01-14 13:34 ` Corey Minyard
2025-01-11 18:37 ` [PATCH v2 12/13] hw/misc/imx6_src: " Bernhard Beschow
2025-01-11 18:37 ` [PATCH v2 13/13] hw/gpio/imx_gpio: Turn DPRINTF() into " Bernhard Beschow
2025-01-14 12:46 ` [PATCH v2 00/13] i.MX and SDHCI improvements Bernhard Beschow
2025-01-27 13:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250111183711.2338-6-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=farosas@suse.de \
--cc=jcd@tribudubois.net \
--cc=linux@roeck-us.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.