From: Nathan Chancellor <nathan@kernel.org>
To: yukaixiong <yukaixiong@huawei.com>,
Joel Granados <joel.granados@kernel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [sysctl:sysctl-testing 8/16] mm/nommu.c:394:12: error: static declaration of 'sysctl_nr_trim_pages' follows non-static declaration
Date: Wed, 15 Jan 2025 07:23:55 -0700 [thread overview]
Message-ID: <20250115142355.GA519100@ax162> (raw)
In-Reply-To: <CANiq72n6jb62PzgP-3T6sBQRZCDb4Mi1wq6X8vEwRDT-2OvKrg@mail.gmail.com>
On Wed, Jan 15, 2025 at 11:55:02AM +0100, Miguel Ojeda wrote:
> On Wed, Jan 15, 2025 at 9:14 AM yukaixiong <yukaixiong@huawei.com> wrote:
> >
> > I have deleted the line : "extern int sysctl_nr_trim_pages;" in
> > patch8 of v5. Why still produce this error? I don't understand!
>
> As far as I understand, the report is against the tree mentioned in
> the report, not against a patch series. So I would recommend checking
> the tree to see what it contains (e.g. what version).
This is the key. The version of the patch in the tree:
https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/commit/?id=0450345eca3ca45264db9ab09d31281e001236b7
is missing the hunk from include/linux/mm.h that was in the patch on the
mailing list:
https://lore.kernel.org/20250111070751.2588654-9-yukaixiong@huawei.com/
Was there a conflict at application time? Seems like this is something
Joel will likely need to sort out.
Cheers,
Nathan
next prev parent reply other threads:[~2025-01-15 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 18:39 [sysctl:sysctl-testing 8/16] mm/nommu.c:394:12: error: static declaration of 'sysctl_nr_trim_pages' follows non-static declaration kernel test robot
2025-01-15 8:14 ` yukaixiong
2025-01-15 10:55 ` Miguel Ojeda
2025-01-15 14:23 ` Nathan Chancellor [this message]
2025-01-16 2:05 ` yukaixiong
2025-01-16 10:58 ` Joel Granados
2025-01-16 11:07 ` yukaixiong
2025-01-16 10:57 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115142355.GA519100@ax162 \
--to=nathan@kernel.org \
--cc=joel.granados@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yukaixiong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.