Re: [sysctl:sysctl-testing 8/16] mm/nommu.c:394:12: error: static declaration of 'sysctl_nr_trim_pages' follows non-static declaration

[yukaixiong <yukaixiong@huawei.com>]

On 2025/1/16 18:58, Joel Granados wrote:
> On Thu, Jan 16, 2025 at 10:05:27AM +0800, yukaixiong wrote:
>>
>> On 2025/1/15 22:23, Nathan Chancellor wrote:
>>> On Wed, Jan 15, 2025 at 11:55:02AM +0100, Miguel Ojeda wrote:
>>>> On Wed, Jan 15, 2025 at 9:14 AM yukaixiong <yukaixiong@huawei.com> wrote:
>>>>>            I have deleted the line : "extern int sysctl_nr_trim_pages;" in
>>>>> patch8 of v5. Why still produce this error? I don't understand!
>>>> As far as I understand, the report is against the tree mentioned in
>>>> the report, not against a patch series. So I would recommend checking
>>>> the tree to see what it contains (e.g. what version).
>>> This is the key. The version of the patch in the tree:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/commit/?id=0450345eca3ca45264db9ab09d31281e001236b7
>>>
>>> is missing the hunk from include/linux/mm.h that was in the patch on the
>>> mailing list:
>>>
>>> https://lore.kernel.org/20250111070751.2588654-9-yukaixiong@huawei.com/
>>>
>>> Was there a conflict at application time? Seems like this is something
>>> Joel will likely need to sort out.
>>>
>>> Cheers,
>>> Nathan
>>> .
>> Right！Waiting for Joel's reply.
> Should be OK now.
>
>
Thx

Best ...