Re: [sysctl:sysctl-testing 8/16] mm/nommu.c:394:12: error: static declaration of 'sysctl_nr_trim_pages' follows non-static declaration

[yukaixiong <yukaixiong@huawei.com>]

On 2025/1/15 2:39, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git sysctl-testing
> head:   2fc99f285719e0cce8df1fe21479cb9e6626c2fe
> commit: 0450345eca3ca45264db9ab09d31281e001236b7 [8/16] mm: nommu: move sysctl to mm/nommu.c
> config: arm-randconfig-001-20250115 (https://download.01.org/0day-ci/archive/20250115/202501150216.3RVz44uS-lkp@intel.com/config)
> compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250115/202501150216.3RVz44uS-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501150216.3RVz44uS-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> mm/nommu.c:394:12: error: static declaration of 'sysctl_nr_trim_pages' follows non-static declaration
>     static int sysctl_nr_trim_pages = CONFIG_NOMMU_INITIAL_TRIM_EXCESS;
>                ^
>     include/linux/mm.h:4082:12: note: previous declaration is here
>     extern int sysctl_nr_trim_pages;
>                ^
>     1 error generated.
Help me!

Hi all;

         I have deleted the line : "extern int sysctl_nr_trim_pages;" in 
patch8 of v5. Why still produce this error? I don't understand!

Due to the environment configuration of the server, I have not installed 
the necessary setup for compilation and testing as mentioned in
download.01.org/0day-ci/archive/20250115/202501150216.3RVz44uS-lkp@intel.com/reproduce. 
But I compile the code with the config
as same as 
https://download.01.org/0day-ci/archive/20250115/202501150216.3RVz44uS-lkp@intel.com/config, 
and didn't find the error.

my environment as shown as below:
Linux ubuntu-2288H 5.13.0-40-generic #45~20.04.1-Ubuntu SMP Mon Apr 4 
09:38:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

The compile steps as below:

1. export ARCH=arm;export CROSS_COMPILE=arm-linux-gnueabihf-
2. cp ../stm32_config.log ./.config
3. make ARCH=arm olddefconfig
4. make -j200

the content of stm32_config.log is same as 
https://download.01.org/0day-ci/archive/20250115/202501150216.3RVz44uS-lkp@intel.com/config.
no error as shown above. the compile result as  below shown:

yukaixiong@ubuntu-2288H:~/linux_next/linux-next$ file arch/arm/boot/zImage
arch/arm/boot/zImage: Linux kernel ARM boot executable zImage 
(little-endian)
yukaixiong@ubuntu-2288H:~/linux_next/linux-next$ file ./mm/nommu.o
./mm/nommu.o: ELF 32-bit LSB relocatable, ARM, EABI5 version 1 (SYSV), 
with debug_info, not stripped

Can you tell me the reason for the error? It would be best if you could 
directly tell me how to fix it.
Can I fix this error by "git send-email -in-reply-to xxxxx" so that I 
don't need to send a new version?

Thank you so much!
>
> vim +/sysctl_nr_trim_pages +394 mm/nommu.c
>
>     393	
>   > 394	static int sysctl_nr_trim_pages = CONFIG_NOMMU_INITIAL_TRIM_EXCESS;
>     395	
>