All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH v3 09/15] mempool: add allocation function attributes
Date: Thu, 23 Jan 2025 08:28:09 -0800	[thread overview]
Message-ID: <20250123163003.23394-10-stephen@networkplumber.org> (raw)
In-Reply-To: <20250123163003.23394-1-stephen@networkplumber.org>

Use function attributes to catch cases where mempool is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
---
 lib/mempool/rte_mempool.h | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index 7bdc92b812..c495cc012f 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1012,6 +1012,20 @@ typedef void (rte_mempool_mem_cb_t)(struct rte_mempool *mp,
  */
 typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *);
 
+/**
+ * Free a mempool
+ *
+ * Unlink the mempool from global list, free the memory chunks, and all
+ * memory referenced by the mempool. The objects must not be used by
+ * other cores as they will be freed.
+ *
+ * @param mp
+ *   A pointer to the mempool structure.
+ *   If NULL then, the function does nothing.
+ */
+void
+rte_mempool_free(struct rte_mempool *mp);
+
 /**
  * Create a new mempool named *name* in memory.
  *
@@ -1095,7 +1109,8 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
 		   unsigned cache_size, unsigned private_data_size,
 		   rte_mempool_ctor_t *mp_init, void *mp_init_arg,
 		   rte_mempool_obj_cb_t *obj_init, void *obj_init_arg,
-		   int socket_id, unsigned flags);
+		   int socket_id, unsigned int flags)
+	__rte_malloc __rte_dealloc(rte_mempool_free, 1);
 
 /**
  * Create an empty mempool
@@ -1132,22 +1147,10 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
  *   with rte_errno set appropriately. See rte_mempool_create() for details.
  */
 struct rte_mempool *
-rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
-	unsigned cache_size, unsigned private_data_size,
-	int socket_id, unsigned flags);
-/**
- * Free a mempool
- *
- * Unlink the mempool from global list, free the memory chunks, and all
- * memory referenced by the mempool. The objects must not be used by
- * other cores as they will be freed.
- *
- * @param mp
- *   A pointer to the mempool structure.
- *   If NULL then, the function does nothing.
- */
-void
-rte_mempool_free(struct rte_mempool *mp);
+rte_mempool_create_empty(const char *name, unsigned int n, unsigned int elt_size,
+			 unsigned int cache_size, unsigned int private_data_size,
+			 int socket_id, unsigned int flags)
+		__rte_malloc __rte_dealloc(rte_mempool_free, 1);
 
 /**
  * Add physically contiguous memory for objects in the pool at init
-- 
2.45.2


  parent reply	other threads:[~2025-01-23 16:31 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250110170603.538756-1-stephen@networkplumber.or>
2025-01-20 23:23 ` [PATCH v2 0/3] Fix warnings when using gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 1/3] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 2/3] net/thunderx/base: fix build with Gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 3/3] examples/flow_filtering: fix gcc 15 overflow warning Stephen Hemminger
2025-01-22 10:50   ` [PATCH v2 0/3] Fix warnings when using gcc 15 David Marchand
2025-01-23 16:28 ` [PATCH v3 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-24  8:37     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 04/15] lpm: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 05/15] pipeline: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 06/15] acl: " Stephen Hemminger
2025-01-24  8:36     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 07/15] bitratestats: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 08/15] member: " Stephen Hemminger
2025-01-23 16:28   ` Stephen Hemminger [this message]
2025-01-24  8:32     ` [PATCH v3 09/15] mempool: " Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 10/15] eventdev: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 11/15] ring: " Stephen Hemminger
2025-01-24  8:31     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 12/15] reorder: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 13/15] compressdev: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 14/15] telemetry: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 15/15] sched: " Stephen Hemminger
2025-01-24 18:14 ` [PATCH v4 00/16] Add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 01/16] fib: add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 04/16] lpm: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 05/16] pipeline: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 06/16] acl: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 07/16] bitratestats: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 08/16] member: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 09/16] mempool: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 10/16] eventdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 11/16] ring: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 12/16] reorder: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 13/16] compressdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 14/16] telemetry: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 15/16] sched: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123163003.23394-10-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.