All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Fan Zhang <fanzhang.oss@gmail.com>,
	Ashish Gupta <ashish.gupta@marvell.com>
Subject: [PATCH v3 13/15] compressdev: add allocation function attributes
Date: Thu, 23 Jan 2025 08:28:13 -0800	[thread overview]
Message-ID: <20250123163003.23394-14-stephen@networkplumber.org> (raw)
In-Reply-To: <20250123163003.23394-1-stephen@networkplumber.org>

Use function attributes to catch cases where compressdev is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/compressdev/rte_comp.h | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
index d66a4b1cb9..f86e773b28 100644
--- a/lib/compressdev/rte_comp.h
+++ b/lib/compressdev/rte_comp.h
@@ -480,6 +480,19 @@ struct __rte_cache_aligned rte_comp_op {
 	 */
 };
 
+
+/**
+ * Free operation structure
+ * If operation has been allocate from a rte_mempool, then the operation will
+ * be returned to the mempool.
+ *
+ * @param op
+ *   Compress operation pointer allocated from rte_comp_op_alloc()
+ *   If op is NULL, no operation is performed.
+ */
+void
+rte_comp_op_free(struct rte_comp_op *op);
+
 /**
  * Creates an operation pool
  *
@@ -501,7 +514,8 @@ struct __rte_cache_aligned rte_comp_op {
 struct rte_mempool *
 rte_comp_op_pool_create(const char *name,
 		unsigned int nb_elts, unsigned int cache_size,
-		uint16_t user_size, int socket_id);
+		uint16_t user_size, int socket_id)
+	__rte_malloc __rte_dealloc(rte_comp_op_free, 1);
 
 /**
  * Allocate an operation from a mempool with default parameters set
@@ -533,18 +547,6 @@ int
 rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
 		struct rte_comp_op **ops, uint16_t nb_ops);
 
-/**
- * Free operation structure
- * If operation has been allocate from a rte_mempool, then the operation will
- * be returned to the mempool.
- *
- * @param op
- *   Compress operation pointer allocated from rte_comp_op_alloc()
- *   If op is NULL, no operation is performed.
- */
-void
-rte_comp_op_free(struct rte_comp_op *op);
-
 /**
  * Bulk free operation structures
  * If operations have been allocated from an rte_mempool, then the operations
-- 
2.45.2


  parent reply	other threads:[~2025-01-23 16:31 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250110170603.538756-1-stephen@networkplumber.or>
2025-01-20 23:23 ` [PATCH v2 0/3] Fix warnings when using gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 1/3] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 2/3] net/thunderx/base: fix build with Gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 3/3] examples/flow_filtering: fix gcc 15 overflow warning Stephen Hemminger
2025-01-22 10:50   ` [PATCH v2 0/3] Fix warnings when using gcc 15 David Marchand
2025-01-23 16:28 ` [PATCH v3 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-24  8:37     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 04/15] lpm: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 05/15] pipeline: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 06/15] acl: " Stephen Hemminger
2025-01-24  8:36     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 07/15] bitratestats: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 08/15] member: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 09/15] mempool: " Stephen Hemminger
2025-01-24  8:32     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 10/15] eventdev: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 11/15] ring: " Stephen Hemminger
2025-01-24  8:31     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 12/15] reorder: " Stephen Hemminger
2025-01-23 16:28   ` Stephen Hemminger [this message]
2025-01-23 16:28   ` [PATCH v3 14/15] telemetry: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 15/15] sched: " Stephen Hemminger
2025-01-24 18:14 ` [PATCH v4 00/16] Add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 01/16] fib: add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 04/16] lpm: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 05/16] pipeline: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 06/16] acl: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 07/16] bitratestats: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 08/16] member: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 09/16] mempool: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 10/16] eventdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 11/16] ring: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 12/16] reorder: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 13/16] compressdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 14/16] telemetry: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 15/16] sched: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123163003.23394-14-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=ashish.gupta@marvell.com \
    --cc=dev@dpdk.org \
    --cc=fanzhang.oss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.