All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [PATCH v3 05/15] pipeline: add allocation function attributes
Date: Thu, 23 Jan 2025 08:28:05 -0800	[thread overview]
Message-ID: <20250123163003.23394-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20250123163003.23394-1-stephen@networkplumber.org>

Use function attributes to catch cases where pipeline is allocated
but not freed correctly.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/pipeline/rte_port_in_action.h | 55 ++++++++++++++++---------------
 lib/pipeline/rte_table_action.h   | 53 +++++++++++++++--------------
 2 files changed, 56 insertions(+), 52 deletions(-)

diff --git a/lib/pipeline/rte_port_in_action.h b/lib/pipeline/rte_port_in_action.h
index 9d17bae988..ee6cc59fae 100644
--- a/lib/pipeline/rte_port_in_action.h
+++ b/lib/pipeline/rte_port_in_action.h
@@ -164,18 +164,6 @@ struct rte_port_in_action_lb_params {
  */
 struct rte_port_in_action_profile;
 
-/**
- * Input port action profile create.
- *
- * @param[in] socket_id
- *   CPU socket ID for the internal data structures memory allocation.
- * @return
- *   Input port action profile handle on success, NULL otherwise.
- */
-__rte_experimental
-struct rte_port_in_action_profile *
-rte_port_in_action_profile_create(uint32_t socket_id);
-
 /**
  * Input port action profile free.
  *
@@ -189,6 +177,19 @@ __rte_experimental
 int
 rte_port_in_action_profile_free(struct rte_port_in_action_profile *profile);
 
+/**
+ * Input port action profile create.
+ *
+ * @param[in] socket_id
+ *   CPU socket ID for the internal data structures memory allocation.
+ * @return
+ *   Input port action profile handle on success, NULL otherwise.
+ */
+__rte_experimental
+struct rte_port_in_action_profile *
+rte_port_in_action_profile_create(uint32_t socket_id)
+	__rte_malloc __rte_dealloc(rte_port_in_action_profile_free, 1);
+
 /**
  * Input port action profile action register.
  *
@@ -236,6 +237,19 @@ rte_port_in_action_profile_freeze(struct rte_port_in_action_profile *profile);
  */
 struct rte_port_in_action;
 
+/**
+ * Input port action free.
+ *
+ * @param[in] action
+ *   Handle to input port action object (needs to be valid).
+ *   If action is NULL, no operation is performed.
+ * @return
+ *   Always zero.
+ */
+__rte_experimental
+int
+rte_port_in_action_free(struct rte_port_in_action *action);
+
 /**
  * Input port action create.
  *
@@ -252,21 +266,8 @@ struct rte_port_in_action;
  */
 __rte_experimental
 struct rte_port_in_action *
-rte_port_in_action_create(struct rte_port_in_action_profile *profile,
-	uint32_t socket_id);
-
-/**
- * Input port action free.
- *
- * @param[in] action
- *   Handle to input port action object (needs to be valid).
- *   If action is NULL, no operation is performed.
- * @return
- *   Always zero.
- */
-__rte_experimental
-int
-rte_port_in_action_free(struct rte_port_in_action *action);
+rte_port_in_action_create(struct rte_port_in_action_profile *profile, uint32_t socket_id)
+	__rte_malloc __rte_dealloc(rte_port_in_action_free, 1);
 
 /**
  * Input port params get.
diff --git a/lib/pipeline/rte_table_action.h b/lib/pipeline/rte_table_action.h
index 47a7bdfc01..e8b4d8b33d 100644
--- a/lib/pipeline/rte_table_action.h
+++ b/lib/pipeline/rte_table_action.h
@@ -54,6 +54,7 @@
 
 #include <stdint.h>
 
+#include <rte_common.h>
 #include <rte_compat.h>
 #include <rte_ether.h>
 #include <rte_ip6.h>
@@ -812,17 +813,6 @@ struct rte_table_action_decap_params {
  */
 struct rte_table_action_profile;
 
-/**
- * Table action profile create.
- *
- * @param[in] common
- *   Common action configuration.
- * @return
- *   Table action profile handle on success, NULL otherwise.
- */
-__rte_experimental
-struct rte_table_action_profile *
-rte_table_action_profile_create(struct rte_table_action_common_config *common);
 
 /**
  * Table action profile free.
@@ -836,6 +826,19 @@ __rte_experimental
 int
 rte_table_action_profile_free(struct rte_table_action_profile *profile);
 
+/**
+ * Table action profile create.
+ *
+ * @param[in] common
+ *   Common action configuration.
+ * @return
+ *   Table action profile handle on success, NULL otherwise.
+ */
+__rte_experimental
+struct rte_table_action_profile *
+rte_table_action_profile_create(struct rte_table_action_common_config *common)
+	__rte_malloc __rte_dealloc(rte_table_action_profile_free, 1);
+
 /**
  * Table action profile action register.
  *
@@ -881,6 +884,18 @@ rte_table_action_profile_freeze(struct rte_table_action_profile *profile);
  */
 struct rte_table_action;
 
+/**
+ * Table action free.
+ *
+ * @param[in] action
+ *   Handle to table action object (needs to be valid).
+ * @return
+ *   Zero on success, non-zero error code otherwise.
+ */
+__rte_experimental
+int
+rte_table_action_free(struct rte_table_action *action);
+
 /**
  * Table action create.
  *
@@ -898,20 +913,8 @@ struct rte_table_action;
  */
 __rte_experimental
 struct rte_table_action *
-rte_table_action_create(struct rte_table_action_profile *profile,
-	uint32_t socket_id);
-
-/**
- * Table action free.
- *
- * @param[in] action
- *   Handle to table action object (needs to be valid).
- * @return
- *   Zero on success, non-zero error code otherwise.
- */
-__rte_experimental
-int
-rte_table_action_free(struct rte_table_action *action);
+rte_table_action_create(struct rte_table_action_profile *profile, uint32_t socket_id)
+	__rte_malloc __rte_dealloc(rte_table_action_free, 1);
 
 /**
  * Table action table params get.
-- 
2.45.2


  parent reply	other threads:[~2025-01-23 16:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250110170603.538756-1-stephen@networkplumber.or>
2025-01-20 23:23 ` [PATCH v2 0/3] Fix warnings when using gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 1/3] crypto/cnxk: fix gcc 15 warning Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 2/3] net/thunderx/base: fix build with Gcc 15 Stephen Hemminger
2025-01-20 23:23   ` [PATCH v2 3/3] examples/flow_filtering: fix gcc 15 overflow warning Stephen Hemminger
2025-01-22 10:50   ` [PATCH v2 0/3] Fix warnings when using gcc 15 David Marchand
2025-01-23 16:28 ` [PATCH v3 00/15] Add attributes to allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 01/15] fib: add allocation function attributes Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 02/15] rib: annotate rib allocation functions Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 03/15] hash: add allocation function attributes Stephen Hemminger
2025-01-24  8:37     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 04/15] lpm: " Stephen Hemminger
2025-01-23 16:28   ` Stephen Hemminger [this message]
2025-01-23 16:28   ` [PATCH v3 06/15] acl: " Stephen Hemminger
2025-01-24  8:36     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 07/15] bitratestats: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 08/15] member: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 09/15] mempool: " Stephen Hemminger
2025-01-24  8:32     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 10/15] eventdev: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 11/15] ring: " Stephen Hemminger
2025-01-24  8:31     ` Konstantin Ananyev
2025-01-23 16:28   ` [PATCH v3 12/15] reorder: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 13/15] compressdev: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 14/15] telemetry: " Stephen Hemminger
2025-01-23 16:28   ` [PATCH v3 15/15] sched: " Stephen Hemminger
2025-01-24 18:14 ` [PATCH v4 00/16] Add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 01/16] fib: add " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 02/16] rib: annotate rib allocation functions Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 03/16] hash: add allocation function attributes Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 04/16] lpm: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 05/16] pipeline: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 06/16] acl: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 07/16] bitratestats: " Stephen Hemminger
2025-01-24 18:14   ` [PATCH v4 08/16] member: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 09/16] mempool: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 10/16] eventdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 11/16] ring: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 12/16] reorder: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 13/16] compressdev: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 14/16] telemetry: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 15/16] sched: " Stephen Hemminger
2025-01-24 18:15   ` [PATCH v4 16/16] doc: add release note about allocation attributes Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250123163003.23394-6-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.