From: Anup Patel <apatel@ventanamicro.com>
To: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Len Brown <lenb@kernel.org>, Sunil V L <sunilvl@ventanamicro.com>,
Rahul Pathak <rpathak@ventanamicro.com>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
Atish Patra <atishp@atishpatra.org>,
Andrew Jones <ajones@ventanamicro.com>,
Samuel Holland <samuel.holland@sifive.com>,
Anup Patel <anup@brainfault.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Anup Patel <apatel@ventanamicro.com>
Subject: [RFC PATCH v2 16/17] irqchip/riscv-rpmi-sysmsi: Add ACPI support
Date: Mon, 3 Feb 2025 14:19:05 +0530 [thread overview]
Message-ID: <20250203084906.681418-17-apatel@ventanamicro.com> (raw)
In-Reply-To: <20250203084906.681418-1-apatel@ventanamicro.com>
From: Sunil V L <sunilvl@ventanamicro.com>
Add ACPI support for the RISC-V RPMI system MSI based irqchip driver.
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
drivers/irqchip/Kconfig | 2 +-
drivers/irqchip/irq-riscv-rpmi-sysmsi.c | 34 ++++++++++++++++++++++++-
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 2ae44354735b..cf96382113ce 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -599,7 +599,7 @@ config RISCV_IMSIC_PCI
config RISCV_RPMI_SYSMSI
bool
- depends on MAILBOX
+ depends on RISCV && MAILBOX
select IRQ_DOMAIN_HIERARCHY
select GENERIC_MSI_IRQ
default RISCV
diff --git a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
index 3022f0924c94..1f03241920bb 100644
--- a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
+++ b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
@@ -8,6 +8,7 @@
#include <linux/cpu.h>
#include <linux/interrupt.h>
#include <linux/irqchip.h>
+#include <linux/irqchip/riscv-imsic.h>
#include <linux/mailbox_client.h>
#include <linux/mailbox/riscv-rpmi-message.h>
#include <linux/module.h>
@@ -215,6 +216,7 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct rpmi_sysmsi_priv *priv;
+ u32 id;
int rc;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -223,6 +225,15 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
priv->dev = dev;
platform_set_drvdata(pdev, priv);
+ if (!is_of_node(dev->fwnode)) {
+ rc = riscv_acpi_get_gsi_info(dev->fwnode, &priv->gsi_base, &id,
+ &priv->nr_irqs, NULL);
+ if (rc) {
+ dev_err(dev, "failed to find GSI mapping\n");
+ return rc;
+ }
+ }
+
/* Setup mailbox client */
priv->client.dev = priv->dev;
priv->client.rx_callback = NULL;
@@ -252,8 +263,16 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
* then we need to set it explicitly before using any platform
* MSI functions.
*/
- if (is_of_node(dev->fwnode))
+ if (is_of_node(dev->fwnode)) {
of_msi_configure(dev, to_of_node(dev->fwnode));
+ } else {
+ struct irq_domain *msi_domain;
+
+ msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev),
+ DOMAIN_BUS_PLATFORM_MSI);
+ if (msi_domain)
+ dev_set_msi_domain(dev, msi_domain);
+ }
if (!dev_get_msi_domain(dev))
return -EPROBE_DEFER;
@@ -264,6 +283,10 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
priv->nr_irqs, priv, priv))
return dev_err_probe(dev, -ENOMEM, "failed to create MSI irq domain\n");
+#ifdef CONFIG_ACPI
+ if (!acpi_disabled)
+ acpi_dev_clear_dependencies(ACPI_COMPANION(dev));
+#endif
dev_info(dev, "%d system MSIs registered\n", priv->nr_irqs);
return 0;
}
@@ -273,10 +296,19 @@ static const struct of_device_id rpmi_sysmsi_match[] = {
{}
};
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id acpi_rpmi_sysmsi_match[] = {
+ { "RSCV0006", 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, acpi_rpmi_sysmsi_match);
+#endif
+
static struct platform_driver rpmi_sysmsi_driver = {
.driver = {
.name = "rpmi-sysmsi",
.of_match_table = rpmi_sysmsi_match,
+ .acpi_match_table = ACPI_PTR(acpi_rpmi_sysmsi_match),
},
.probe = rpmi_sysmsi_probe,
};
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <apatel@ventanamicro.com>
To: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Anup Patel <apatel@ventanamicro.com>,
devicetree@vger.kernel.org,
Andrew Jones <ajones@ventanamicro.com>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel.holland@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, Len Brown <lenb@kernel.org>,
linux-clk@vger.kernel.org,
Rahul Pathak <rpathak@ventanamicro.com>
Subject: [RFC PATCH v2 16/17] irqchip/riscv-rpmi-sysmsi: Add ACPI support
Date: Mon, 3 Feb 2025 14:19:05 +0530 [thread overview]
Message-ID: <20250203084906.681418-17-apatel@ventanamicro.com> (raw)
In-Reply-To: <20250203084906.681418-1-apatel@ventanamicro.com>
From: Sunil V L <sunilvl@ventanamicro.com>
Add ACPI support for the RISC-V RPMI system MSI based irqchip driver.
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
drivers/irqchip/Kconfig | 2 +-
drivers/irqchip/irq-riscv-rpmi-sysmsi.c | 34 ++++++++++++++++++++++++-
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 2ae44354735b..cf96382113ce 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -599,7 +599,7 @@ config RISCV_IMSIC_PCI
config RISCV_RPMI_SYSMSI
bool
- depends on MAILBOX
+ depends on RISCV && MAILBOX
select IRQ_DOMAIN_HIERARCHY
select GENERIC_MSI_IRQ
default RISCV
diff --git a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
index 3022f0924c94..1f03241920bb 100644
--- a/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
+++ b/drivers/irqchip/irq-riscv-rpmi-sysmsi.c
@@ -8,6 +8,7 @@
#include <linux/cpu.h>
#include <linux/interrupt.h>
#include <linux/irqchip.h>
+#include <linux/irqchip/riscv-imsic.h>
#include <linux/mailbox_client.h>
#include <linux/mailbox/riscv-rpmi-message.h>
#include <linux/module.h>
@@ -215,6 +216,7 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct rpmi_sysmsi_priv *priv;
+ u32 id;
int rc;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -223,6 +225,15 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
priv->dev = dev;
platform_set_drvdata(pdev, priv);
+ if (!is_of_node(dev->fwnode)) {
+ rc = riscv_acpi_get_gsi_info(dev->fwnode, &priv->gsi_base, &id,
+ &priv->nr_irqs, NULL);
+ if (rc) {
+ dev_err(dev, "failed to find GSI mapping\n");
+ return rc;
+ }
+ }
+
/* Setup mailbox client */
priv->client.dev = priv->dev;
priv->client.rx_callback = NULL;
@@ -252,8 +263,16 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
* then we need to set it explicitly before using any platform
* MSI functions.
*/
- if (is_of_node(dev->fwnode))
+ if (is_of_node(dev->fwnode)) {
of_msi_configure(dev, to_of_node(dev->fwnode));
+ } else {
+ struct irq_domain *msi_domain;
+
+ msi_domain = irq_find_matching_fwnode(imsic_acpi_get_fwnode(dev),
+ DOMAIN_BUS_PLATFORM_MSI);
+ if (msi_domain)
+ dev_set_msi_domain(dev, msi_domain);
+ }
if (!dev_get_msi_domain(dev))
return -EPROBE_DEFER;
@@ -264,6 +283,10 @@ static int rpmi_sysmsi_probe(struct platform_device *pdev)
priv->nr_irqs, priv, priv))
return dev_err_probe(dev, -ENOMEM, "failed to create MSI irq domain\n");
+#ifdef CONFIG_ACPI
+ if (!acpi_disabled)
+ acpi_dev_clear_dependencies(ACPI_COMPANION(dev));
+#endif
dev_info(dev, "%d system MSIs registered\n", priv->nr_irqs);
return 0;
}
@@ -273,10 +296,19 @@ static const struct of_device_id rpmi_sysmsi_match[] = {
{}
};
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id acpi_rpmi_sysmsi_match[] = {
+ { "RSCV0006", 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, acpi_rpmi_sysmsi_match);
+#endif
+
static struct platform_driver rpmi_sysmsi_driver = {
.driver = {
.name = "rpmi-sysmsi",
.of_match_table = rpmi_sysmsi_match,
+ .acpi_match_table = ACPI_PTR(acpi_rpmi_sysmsi_match),
},
.probe = rpmi_sysmsi_probe,
};
--
2.43.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-02-03 8:52 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 8:48 [RFC PATCH v2 00/17] Linux SBI MPXY and RPMI drivers Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 01/17] riscv: Add new error codes defined by SBI v3.0 Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 02/17] dt-bindings: mailbox: Add bindings for RPMI shared memory transport Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 22:30 ` Rob Herring
2025-02-03 22:30 ` Rob Herring
2025-05-02 9:15 ` Anup Patel
2025-05-02 9:15 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 03/17] dt-bindings: mailbox: Add bindings for RISC-V SBI MPXY extension Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 22:44 ` Rob Herring
2025-02-03 22:44 ` Rob Herring
2025-02-06 12:32 ` Anup Patel
2025-02-06 12:32 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 04/17] RISC-V: Add defines for the SBI message proxy extension Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 05/17] mailbox: Add common header for RPMI messages sent via mailbox Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 06/17] mailbox: Allow controller specific mapping using fwnode Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 07/17] mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 08/17] dt-bindings: clock: Add bindings for RISC-V RPMI clock service group Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 22:51 ` Rob Herring
2025-02-03 22:51 ` Rob Herring
2025-05-04 10:30 ` Anup Patel
2025-05-04 10:30 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 09/17] clk: Add clock driver for the " Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 8:48 ` [RFC PATCH v2 10/17] dt-bindings: interrupt-controller: Add bindings for RISC-V RPMI system MSI Anup Patel
2025-02-03 8:48 ` Anup Patel
2025-02-03 22:58 ` Rob Herring
2025-02-03 22:58 ` Rob Herring
2025-05-04 10:44 ` Anup Patel
2025-05-04 10:44 ` Anup Patel
2025-02-03 8:49 ` [RFC PATCH v2 11/17] irqchip: Add driver for the RISC-V RPMI system MSI service group Anup Patel
2025-02-03 8:49 ` Anup Patel
2025-02-03 13:50 ` Thomas Gleixner
2025-02-03 13:50 ` Thomas Gleixner
2025-02-06 12:17 ` Anup Patel
2025-02-06 12:17 ` Anup Patel
2025-02-03 8:49 ` [RFC PATCH v2 12/17] ACPI: property: Add support for nargs_prop in acpi_fwnode_get_reference_args() Anup Patel
2025-02-03 8:49 ` Anup Patel
2025-02-03 9:43 ` Andy Shevchenko
2025-02-03 9:43 ` Andy Shevchenko
2025-02-03 10:58 ` Mika Westerberg
2025-02-03 10:58 ` Mika Westerberg
2025-02-03 12:24 ` Sunil V L
2025-02-03 12:24 ` Sunil V L
2025-02-03 12:36 ` Mika Westerberg
2025-02-03 12:36 ` Mika Westerberg
2025-02-03 13:51 ` Sunil V L
2025-02-03 13:51 ` Sunil V L
2025-02-03 14:39 ` Andy Shevchenko
2025-02-03 14:39 ` Andy Shevchenko
2025-02-03 14:41 ` Andy Shevchenko
2025-02-03 14:41 ` Andy Shevchenko
2025-02-04 16:58 ` Sunil V L
2025-02-04 16:58 ` Sunil V L
2025-02-04 17:36 ` Andy Shevchenko
2025-02-04 17:36 ` Andy Shevchenko
2025-02-03 8:49 ` [RFC PATCH v2 13/17] ACPI: scan: Update honor list for RPMI System MSI Anup Patel
2025-02-03 8:49 ` Anup Patel
2025-02-03 8:49 ` [RFC PATCH v2 14/17] ACPI: RISC-V: Add RPMI System MSI to GSI mapping Anup Patel
2025-02-03 8:49 ` Anup Patel
2025-02-03 8:49 ` [RFC PATCH v2 15/17] mailbox/riscv-sbi-mpxy: Add ACPI support Anup Patel
2025-02-03 8:49 ` Anup Patel
2025-02-03 9:45 ` Andy Shevchenko
2025-02-03 9:45 ` Andy Shevchenko
2025-02-03 8:49 ` Anup Patel [this message]
2025-02-03 8:49 ` [RFC PATCH v2 16/17] irqchip/riscv-rpmi-sysmsi: " Anup Patel
2025-02-03 9:38 ` Andy Shevchenko
2025-02-03 9:38 ` Andy Shevchenko
2025-02-04 4:18 ` Sunil V L
2025-02-04 4:18 ` Sunil V L
2025-02-03 13:52 ` Thomas Gleixner
2025-02-03 13:52 ` Thomas Gleixner
2025-02-03 8:49 ` [RFC PATCH v2 17/17] RISC-V: Enable GPIO keyboard and event device in RV64 defconfig Anup Patel
2025-02-03 8:49 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203084906.681418-17-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=ajones@ventanamicro.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lenb@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rpathak@ventanamicro.com \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.