All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Peter Rosin" <peda@axentia.se>, "Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org,
	 netdev@vger.kernel.org, linux-phy@lists.infradead.org,
	 linux-sound@vger.kernel.org,
	David Lechner <dlechner@baylibre.com>
Subject: [PATCH v2 04/13] bus: ts-nbus: use gpiod_multi_set_value_cansleep
Date: Thu, 06 Feb 2025 16:48:18 -0600	[thread overview]
Message-ID: <20250206-gpio-set-array-helper-v2-4-1c5f048f79c3@baylibre.com> (raw)
In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com>

Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
gpiod_set_array_value_cansleep().

ts_nbus->data->ndescs is validated to be 8 during probe, so will have
the same value as the hard-coded 8 that is removed by this change.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/bus/ts-nbus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c
index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527fffce77784af2 100644
--- a/drivers/bus/ts-nbus.c
+++ b/drivers/bus/ts-nbus.c
@@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus)
 
 	values[0] = 0;
 
-	gpiod_set_array_value_cansleep(8, ts_nbus->data->desc,
-				       ts_nbus->data->info, values);
+	gpiod_multi_set_value_cansleep(ts_nbus->data, values);
 	gpiod_set_value_cansleep(ts_nbus->csn, 0);
 	gpiod_set_value_cansleep(ts_nbus->strobe, 0);
 	gpiod_set_value_cansleep(ts_nbus->ale, 0);
@@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val)
  */
 static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte)
 {
-	struct gpio_descs *gpios = ts_nbus->data;
 	DECLARE_BITMAP(values, 8);
 
 	values[0] = byte;
 
-	gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values);
+	gpiod_multi_set_value_cansleep(ts_nbus->data, values);
 }
 
 /*

-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <dlechner@baylibre.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Peter Rosin" <peda@axentia.se>, "Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org,
	 netdev@vger.kernel.org, linux-phy@lists.infradead.org,
	 linux-sound@vger.kernel.org,
	David Lechner <dlechner@baylibre.com>
Subject: [PATCH v2 04/13] bus: ts-nbus: use gpiod_multi_set_value_cansleep
Date: Thu, 06 Feb 2025 16:48:18 -0600	[thread overview]
Message-ID: <20250206-gpio-set-array-helper-v2-4-1c5f048f79c3@baylibre.com> (raw)
In-Reply-To: <20250206-gpio-set-array-helper-v2-0-1c5f048f79c3@baylibre.com>

Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
gpiod_set_array_value_cansleep().

ts_nbus->data->ndescs is validated to be 8 during probe, so will have
the same value as the hard-coded 8 that is removed by this change.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 drivers/bus/ts-nbus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c
index d3ee102a13893c83c50e41f7298821f4d7ae3487..b4c9308caf0647a3261071d9527fffce77784af2 100644
--- a/drivers/bus/ts-nbus.c
+++ b/drivers/bus/ts-nbus.c
@@ -109,8 +109,7 @@ static void ts_nbus_reset_bus(struct ts_nbus *ts_nbus)
 
 	values[0] = 0;
 
-	gpiod_set_array_value_cansleep(8, ts_nbus->data->desc,
-				       ts_nbus->data->info, values);
+	gpiod_multi_set_value_cansleep(ts_nbus->data, values);
 	gpiod_set_value_cansleep(ts_nbus->csn, 0);
 	gpiod_set_value_cansleep(ts_nbus->strobe, 0);
 	gpiod_set_value_cansleep(ts_nbus->ale, 0);
@@ -150,12 +149,11 @@ static int ts_nbus_read_byte(struct ts_nbus *ts_nbus, u8 *val)
  */
 static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte)
 {
-	struct gpio_descs *gpios = ts_nbus->data;
 	DECLARE_BITMAP(values, 8);
 
 	values[0] = byte;
 
-	gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values);
+	gpiod_multi_set_value_cansleep(ts_nbus->data, values);
 }
 
 /*

-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2025-02-06 22:48 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 22:48 [PATCH v2 00/13] gpiolib: add gpiod_multi_set_value_cansleep David Lechner
2025-02-06 22:48 ` David Lechner
2025-02-06 22:48 ` [PATCH v2 01/13] gpiolib: add gpiod_multi_set_value_cansleep() David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-07  9:10   ` Geert Uytterhoeven
2025-02-07  9:10     ` Geert Uytterhoeven
2025-02-07 16:29     ` David Lechner
2025-02-07 16:29       ` David Lechner
2025-02-07 16:44       ` Geert Uytterhoeven
2025-02-07 16:44         ` Geert Uytterhoeven
2025-02-06 22:48 ` [PATCH v2 02/13] auxdisplay: seg-led-gpio: use gpiod_multi_set_value_cansleep David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-07  9:04   ` Geert Uytterhoeven
2025-02-07  9:04     ` Geert Uytterhoeven
2025-02-06 22:48 ` [PATCH v2 03/13] bus: ts-nbus: validate ts,data-gpios array size David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-06 22:48 ` David Lechner [this message]
2025-02-06 22:48   ` [PATCH v2 04/13] bus: ts-nbus: use gpiod_multi_set_value_cansleep David Lechner
2025-02-07 12:15   ` Andy Shevchenko
2025-02-07 12:15     ` Andy Shevchenko
2025-02-07 12:17     ` Andy Shevchenko
2025-02-07 12:17       ` Andy Shevchenko
2025-02-07 15:23       ` David Lechner
2025-02-07 15:23         ` David Lechner
2025-02-07 15:34         ` Andy Shevchenko
2025-02-07 15:34           ` Andy Shevchenko
2025-02-07 15:43         ` Yury Norov
2025-02-07 15:43           ` Yury Norov
2025-02-06 22:48 ` [PATCH v2 05/13] gpio: max3191x: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-07 10:34   ` Andy Shevchenko
2025-02-07 10:34     ` Andy Shevchenko
2025-02-07 15:23     ` David Lechner
2025-02-07 15:23       ` David Lechner
2025-02-06 22:48 ` [PATCH v2 06/13] iio: adc: ad7606: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-07 12:13   ` Andy Shevchenko
2025-02-07 12:13     ` Andy Shevchenko
2025-02-08 13:23     ` Jonathan Cameron
2025-02-08 13:23       ` Jonathan Cameron
2025-02-06 22:48 ` [PATCH v2 07/13] iio: amplifiers: hmc425a: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-08 13:22   ` Jonathan Cameron
2025-02-08 13:22     ` Jonathan Cameron
2025-02-06 22:48 ` [PATCH v2 08/13] iio: resolver: ad2s1210: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-08 13:22   ` Jonathan Cameron
2025-02-08 13:22     ` Jonathan Cameron
2025-02-06 22:48 ` [PATCH v2 09/13] mmc: pwrseq_simple: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-06 22:48 ` [PATCH v2 10/13] mux: gpio: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-06 22:48 ` [PATCH v2 11/13] net: mdio: mux-gpio: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-06 22:48 ` [PATCH v2 12/13] phy: mapphone-mdm6600: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-06 22:48 ` [PATCH v2 13/13] ASoC: adau1701: " David Lechner
2025-02-06 22:48   ` David Lechner
2025-02-07  7:49 ` [PATCH v2 00/13] gpiolib: add gpiod_multi_set_value_cansleep Bartosz Golaszewski
2025-02-07  7:49   ` Bartosz Golaszewski
2025-02-07  9:47   ` Ulf Hansson
2025-02-07  9:47     ` Ulf Hansson
2025-02-07 12:20     ` Andy Shevchenko
2025-02-07 12:20       ` Andy Shevchenko
2025-02-08 13:20       ` Jonathan Cameron
2025-02-08 13:20         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250206-gpio-set-array-helper-v2-4-1c5f048f79c3@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andrew@lunn.ch \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=hkallweit1@gmail.com \
    --cc=jic23@kernel.org \
    --cc=kishon@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pabeni@redhat.com \
    --cc=peda@axentia.se \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.