Re: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value_cansleep

From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Peter Rosin" <peda@axentia.se>, "Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org,
	netdev@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value_cansleep
Date: Sat, 8 Feb 2025 13:23:13 +0000	[thread overview]
Message-ID: <20250208132313.5b151ca0@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vfb7EgHkHtqm4b0QnG=uWwszpWwFe8MLDPRSifKtQFAcA@mail.gmail.com>

On Fri, 7 Feb 2025 14:13:23 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Feb 7, 2025 at 12:48 AM David Lechner <dlechner@baylibre.com> wrote:
> >
> > Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> > gpiod_set_array_value().
> >
> > These are not called in an atomic context, so changing to the cansleep
> > variant is fine.  
> 
> ...
> 
> >         if (st->gpio_os) {
> > -               gpiod_set_array_value(st->gpio_os->ndescs,
> > -                                     st->gpio_os->desc, st->gpio_os->info, os);
> > +               gpiod_multi_set_value_cansleep(st->gpio_os, os);
> >         }  
> 
> Now I do not see any justification to leave {}.
> 
With that tidied up (good spot!) if this goes through the GPIO tree
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>