From: Al Viro <viro@zeniv.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Reaver <me@davidreaver.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, cocci@inria.fr,
linux-kernel@vger.kernel.org
Subject: Re: [cocci] [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API
Date: Mon, 10 Feb 2025 17:00:16 +0000 [thread overview]
Message-ID: <20250210170016.GD1977892@ZenIV> (raw)
In-Reply-To: <20250210115313.69299472@gandalf.local.home>
On Mon, Feb 10, 2025 at 11:53:13AM -0500, Steven Rostedt wrote:
> No it will not be fine. You should not be using dentry at all. I thought
> this was going to convert debugfs over to kernfs. The debugfs_node should
> be using kernfs and completely eliminate the use of dentry.
I disagree, actually - kernfs is an awful model for anything, sysfs included...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Reaver <me@davidreaver.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, cocci@inria.fr,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API
Date: Mon, 10 Feb 2025 17:00:16 +0000 [thread overview]
Message-ID: <20250210170016.GD1977892@ZenIV> (raw)
In-Reply-To: <20250210115313.69299472@gandalf.local.home>
On Mon, Feb 10, 2025 at 11:53:13AM -0500, Steven Rostedt wrote:
> No it will not be fine. You should not be using dentry at all. I thought
> this was going to convert debugfs over to kernfs. The debugfs_node should
> be using kernfs and completely eliminate the use of dentry.
I disagree, actually - kernfs is an awful model for anything, sysfs included...
next prev parent reply other threads:[~2025-02-10 17:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 5:20 [cocci] [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 1/6] debugfs: Add temporary "#define debugfs_node dentry" directives David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 2/6] debugfs: Add helper functions for debugfs_node encapsulation David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 3/6] relay: Replace dentry with debugfs_node David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 4/6] debugfs: Automated conversion from dentry to debugfs_node David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 16:45 ` [cocci] " Steven Rostedt
2025-02-10 16:45 ` Steven Rostedt
2025-02-10 17:53 ` [cocci] " David Reaver
2025-02-10 17:53 ` David Reaver
2025-02-10 5:20 ` [cocci] [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry David Reaver
2025-02-10 5:20 ` David Reaver
2025-02-10 5:58 ` [cocci] " Al Viro
2025-02-10 5:58 ` Al Viro
2025-02-10 15:33 ` kernel test robot
2025-02-10 15:44 ` kernel test robot
2025-02-10 5:53 ` [cocci] [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API Al Viro
2025-02-10 5:53 ` Al Viro
2025-02-10 7:08 ` [cocci] " Greg Kroah-Hartman
2025-02-10 7:08 ` Greg Kroah-Hartman
2025-02-10 16:08 ` [cocci] " David Reaver
2025-02-10 16:08 ` David Reaver
2025-02-10 16:53 ` [cocci] " Steven Rostedt
2025-02-10 16:53 ` Steven Rostedt
2025-02-10 17:00 ` Al Viro [this message]
2025-02-10 17:00 ` Al Viro
2025-02-10 17:12 ` [cocci] " Steven Rostedt
2025-02-10 17:12 ` Steven Rostedt
2025-02-10 17:25 ` [cocci] " Steven Rostedt
2025-02-10 17:25 ` Steven Rostedt
2025-02-10 17:59 ` [cocci] " David Reaver
2025-02-10 17:59 ` David Reaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210170016.GD1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=cocci@inria.fr \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.