All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
	richard@nod.at, vigneshr@ti.com, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	git@amd.com, amitrkcian2002@gmail.com
Subject: Re: [PATCH v12 1/3] dt-bindings: mtd: Describe MTD partitions concatenation
Date: Tue, 18 Feb 2025 15:39:03 -0600	[thread overview]
Message-ID: <20250218213903.GA1203860-robh@kernel.org> (raw)
In-Reply-To: <874j0zqgps.fsf@bootlin.com>

On Wed, Feb 12, 2025 at 05:18:39PM +0100, Miquel Raynal wrote:
> On 12/02/2025 at 10:06:59 -06, Rob Herring <robh@kernel.org> wrote:
> 
> > On Wed, Feb 12, 2025 at 09:25:53AM +0100, Miquel Raynal wrote:
> >> Hi,
> >> 
> >> >> The partitions that gets created are
> >> >> part0_0
> >> >> part1_1
> >> >> part0_1-part1_0-concat
> >> >
> >> > 'part-concat' doesn't work if you have multiple sets of partitions you 
> >> > want to concatenate.
> >> >
> >> > I think you need something like 'prev-partition' or 'next-partition' in 
> >> > the partition nodes to create a linked list of partitions. Hopefully, 
> >> > you don't need both properties, but you do have to scan everything to 
> >> > figure out which ones are concatenated or not. For example, no property 
> >> > can mean not concatenated or last partition if you use 'next-partition'. 
> >> 
> >> Out of curiosity, would the chosen node be eligible as a central place
> >> where to look at?
> >
> > Why would you need that?
> 
> I'm talking about storing in a central place all the concatenated
> partitions. Your proposal with "next-partition" works fine if we locate
> it inside the 'partitions' node, but I feel like the 'part-concat'
> instead was not fitting very well there. So I was wondering in this case
> if moving the concatenation of the partitions would be eligible to the
> chosen node, or if that's reserved to *very* few properties (and should
> remain like that).

You would have to solve the same problem as this patchset which is how 
to support N sets of concatenated partitions.

In general though, we add new things to /chosen very carefully. It's 
usually "things the bootloader configured/enabled" which I don't think 
this qualifies as. 

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
	richard@nod.at, vigneshr@ti.com, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	git@amd.com, amitrkcian2002@gmail.com
Subject: Re: [PATCH v12 1/3] dt-bindings: mtd: Describe MTD partitions concatenation
Date: Tue, 18 Feb 2025 15:39:03 -0600	[thread overview]
Message-ID: <20250218213903.GA1203860-robh@kernel.org> (raw)
In-Reply-To: <874j0zqgps.fsf@bootlin.com>

On Wed, Feb 12, 2025 at 05:18:39PM +0100, Miquel Raynal wrote:
> On 12/02/2025 at 10:06:59 -06, Rob Herring <robh@kernel.org> wrote:
> 
> > On Wed, Feb 12, 2025 at 09:25:53AM +0100, Miquel Raynal wrote:
> >> Hi,
> >> 
> >> >> The partitions that gets created are
> >> >> part0_0
> >> >> part1_1
> >> >> part0_1-part1_0-concat
> >> >
> >> > 'part-concat' doesn't work if you have multiple sets of partitions you 
> >> > want to concatenate.
> >> >
> >> > I think you need something like 'prev-partition' or 'next-partition' in 
> >> > the partition nodes to create a linked list of partitions. Hopefully, 
> >> > you don't need both properties, but you do have to scan everything to 
> >> > figure out which ones are concatenated or not. For example, no property 
> >> > can mean not concatenated or last partition if you use 'next-partition'. 
> >> 
> >> Out of curiosity, would the chosen node be eligible as a central place
> >> where to look at?
> >
> > Why would you need that?
> 
> I'm talking about storing in a central place all the concatenated
> partitions. Your proposal with "next-partition" works fine if we locate
> it inside the 'partitions' node, but I feel like the 'part-concat'
> instead was not fitting very well there. So I was wondering in this case
> if moving the concatenation of the partitions would be eligible to the
> chosen node, or if that's reserved to *very* few properties (and should
> remain like that).

You would have to solve the same problem as this patchset which is how 
to support N sets of concatenated partitions.

In general though, we add new things to /chosen very carefully. It's 
usually "things the bootloader configured/enabled" which I don't think 
this qualifies as. 

Rob

  reply	other threads:[~2025-02-18 21:58 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 13:37 [PATCH v12 0/3] mtd: Add support for stacked memories Amit Kumar Mahapatra
2025-02-05 13:37 ` Amit Kumar Mahapatra
2025-02-05 13:37 ` [PATCH v12 1/3] dt-bindings: mtd: Describe MTD partitions concatenation Amit Kumar Mahapatra
2025-02-05 13:37   ` Amit Kumar Mahapatra
2025-02-11 21:29   ` Rob Herring
2025-02-11 21:29     ` Rob Herring
2025-02-12  8:25     ` Miquel Raynal
2025-02-12  8:25       ` Miquel Raynal
2025-02-12 16:06       ` Rob Herring
2025-02-12 16:06         ` Rob Herring
2025-02-12 16:18         ` Miquel Raynal
2025-02-12 16:18           ` Miquel Raynal
2025-02-18 21:39           ` Rob Herring [this message]
2025-02-18 21:39             ` Rob Herring
2025-02-19  8:36             ` Miquel Raynal
2025-02-19  8:36               ` Miquel Raynal
2025-02-05 13:37 ` [PATCH v12 2/3] mtd: Move struct mtd_concat definition to header file Amit Kumar Mahapatra
2025-02-05 13:37   ` Amit Kumar Mahapatra
2025-02-05 13:37 ` [PATCH v12 3/3] mtd: Add driver for concatenating devices Amit Kumar Mahapatra
2025-02-05 13:37   ` Amit Kumar Mahapatra
2025-02-05 16:23   ` Markus Elfring
2025-02-05 16:23     ` Markus Elfring
2025-03-18 15:53   ` Miquel Raynal
2025-03-18 15:53     ` Miquel Raynal
2025-03-19  6:17     ` Mahapatra, Amit Kumar
2025-03-19  6:17       ` Mahapatra, Amit Kumar
2025-03-19  8:21       ` Miquel Raynal
2025-03-19  8:21         ` Miquel Raynal
2025-04-30 14:18     ` Mahapatra, Amit Kumar
2025-04-30 14:18       ` Mahapatra, Amit Kumar
2025-05-12 10:01       ` Miquel Raynal
2025-05-12 10:01         ` Miquel Raynal
2025-05-13 14:45         ` Mahapatra, Amit Kumar
2025-05-13 14:45           ` Mahapatra, Amit Kumar
2025-05-16 14:06           ` Miquel Raynal
2025-05-16 14:06             ` Miquel Raynal
2025-05-21  6:13             ` Mahapatra, Amit Kumar
2025-05-21  6:13               ` Mahapatra, Amit Kumar
2025-05-26  8:10               ` Miquel Raynal
2025-05-26  8:10                 ` Miquel Raynal
2025-05-26 14:27                 ` Mahapatra, Amit Kumar
2025-05-26 14:27                   ` Mahapatra, Amit Kumar
2025-05-26 14:39                   ` Miquel Raynal
2025-05-26 14:39                     ` Miquel Raynal
2025-05-26 15:01                     ` Mahapatra, Amit Kumar
2025-05-26 15:01                       ` Mahapatra, Amit Kumar
2025-05-27  8:21                       ` Miquel Raynal
2025-05-27  8:21                         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218213903.GA1203860-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=amit.kumar-mahapatra@amd.com \
    --cc=amitrkcian2002@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.