From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org,
joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com,
neil.armstrong@linaro.org, rfoss@kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
dmitry.torokhov@gmail.com, mchehab@kernel.org,
awalls@md.metrocast.net, hverkuil@xs4all.nl,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
louis.peens@corigine.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
parthiban.veerasooran@microchip.com,
arend.vanspriel@broadcom.com, johannes@sipsolutions.net,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
yury.norov@gmail.com, akpm@linux-foundation.org
Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org,
dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org, linux-mtd@lists.infradead.org,
oss-drivers@corigine.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-serial@vger.kernel.org, bpf@vger.kernel.org,
jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu <visitorckw@gmail.com>,
Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH 13/17] mtd: ssfdc: Replace open-coded parity calculation with parity32()
Date: Mon, 24 Feb 2025 00:42:13 +0800 [thread overview]
Message-ID: <20250223164217.2139331-14-visitorckw@gmail.com> (raw)
In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com>
Refactor parity calculations to use the standard parity32() helper.
This change eliminates redundant implementations and improves code
efficiency.
Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
drivers/mtd/ssfdc.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 46c01fa2ec46..e7f9e73da644 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -7,6 +7,7 @@
* Based on NTFL and MTDBLOCK_RO drivers
*/
+#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
@@ -178,20 +179,6 @@ static int read_raw_oob(struct mtd_info *mtd, loff_t offs, uint8_t *buf)
return 0;
}
-/* Parity calculator on a word of n bit size */
-static int get_parity(int number, int size)
-{
- int k;
- int parity;
-
- parity = 1;
- for (k = 0; k < size; k++) {
- parity += (number >> k);
- parity &= 1;
- }
- return parity;
-}
-
/* Read and validate the logical block address field stored in the OOB */
static int get_logical_address(uint8_t *oob_buf)
{
@@ -215,7 +202,7 @@ static int get_logical_address(uint8_t *oob_buf)
block_address &= 0x7FF;
block_address >>= 1;
- if (get_parity(block_address, 10) != parity) {
+ if (parity32(block_address & 0x3ff) == parity) {
pr_debug("SSFDC_RO: logical address field%d"
"parity error(0x%04X)\n", j+1,
block_address);
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org,
joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com,
neil.armstrong@linaro.org, rfoss@kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
dmitry.torokhov@gmail.com, mchehab@kernel.org,
awalls@md.metrocast.net, hverkuil@xs4all.nl,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
louis.peens@corigine.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
parthiban.veerasooran@microchip.com,
arend.vanspriel@broadcom.com, johannes@sipsolutions.net,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
yury.norov@gmail.com, akpm@linux-foundation.org
Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org,
dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org, linux-mtd@lists.infradead.org,
oss-drivers@corigine.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-serial@vger.kernel.org, bpf@vger.kernel.org,
jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu <visitorckw@gmail.com>,
Yu-Chun Lin <eleanor15x@gmail.com>
Subject: [PATCH 13/17] mtd: ssfdc: Replace open-coded parity calculation with parity32()
Date: Mon, 24 Feb 2025 00:42:13 +0800 [thread overview]
Message-ID: <20250223164217.2139331-14-visitorckw@gmail.com> (raw)
In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com>
Refactor parity calculations to use the standard parity32() helper.
This change eliminates redundant implementations and improves code
efficiency.
Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
drivers/mtd/ssfdc.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c
index 46c01fa2ec46..e7f9e73da644 100644
--- a/drivers/mtd/ssfdc.c
+++ b/drivers/mtd/ssfdc.c
@@ -7,6 +7,7 @@
* Based on NTFL and MTDBLOCK_RO drivers
*/
+#include <linux/bitops.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
@@ -178,20 +179,6 @@ static int read_raw_oob(struct mtd_info *mtd, loff_t offs, uint8_t *buf)
return 0;
}
-/* Parity calculator on a word of n bit size */
-static int get_parity(int number, int size)
-{
- int k;
- int parity;
-
- parity = 1;
- for (k = 0; k < size; k++) {
- parity += (number >> k);
- parity &= 1;
- }
- return parity;
-}
-
/* Read and validate the logical block address field stored in the OOB */
static int get_logical_address(uint8_t *oob_buf)
{
@@ -215,7 +202,7 @@ static int get_logical_address(uint8_t *oob_buf)
block_address &= 0x7FF;
block_address >>= 1;
- if (get_parity(block_address, 10) != parity) {
+ if (parity32(block_address & 0x3ff) == parity) {
pr_debug("SSFDC_RO: logical address field%d"
"parity error(0x%04X)\n", j+1,
block_address);
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-02-23 16:45 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 16:42 [PATCH 00/17] Introduce and use generic parity32/64 helper Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 01/17] bitops: Add generic parity calculation for u32 Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 02/17] bitops: Add generic parity calculation for u64 Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-24 7:09 ` Jiri Slaby
2025-02-24 7:09 ` Jiri Slaby
2025-02-24 13:34 ` David Laight
2025-02-24 13:34 ` David Laight
2025-02-24 16:56 ` Yu-Chun Lin
2025-02-24 16:56 ` Yu-Chun Lin
2025-02-25 15:21 ` H. Peter Anvin
2025-02-25 15:21 ` H. Peter Anvin
2025-02-25 15:24 ` H. Peter Anvin
2025-02-25 15:24 ` H. Peter Anvin
2025-02-25 21:43 ` Andrew Cooper
2025-02-25 21:43 ` Andrew Cooper
2025-02-26 1:35 ` H. Peter Anvin
2025-02-26 1:35 ` H. Peter Anvin
2025-02-24 19:27 ` Yury Norov
2025-02-24 19:27 ` Yury Norov
2025-02-25 13:29 ` Kuan-Wei Chiu
2025-02-25 13:29 ` Kuan-Wei Chiu
2025-02-25 14:20 ` Kuan-Wei Chiu
2025-02-25 14:20 ` Kuan-Wei Chiu
2025-02-26 7:14 ` Jiri Slaby
2025-02-26 7:14 ` Jiri Slaby
2025-02-26 17:59 ` Kuan-Wei Chiu
2025-02-26 17:59 ` Kuan-Wei Chiu
2025-02-26 18:33 ` Yury Norov
2025-02-26 18:33 ` Yury Norov
2025-02-27 6:38 ` Jiri Slaby
2025-02-27 6:38 ` Jiri Slaby
2025-02-27 17:37 ` Yury Norov
2025-02-27 17:37 ` Yury Norov
2025-02-26 22:29 ` David Laight
2025-02-26 22:29 ` David Laight
2025-02-27 18:05 ` Yury Norov
2025-02-27 18:05 ` Yury Norov
2025-02-27 21:57 ` David Laight
2025-02-27 21:57 ` David Laight
2025-02-28 1:50 ` H. Peter Anvin
2025-02-28 1:50 ` H. Peter Anvin
2025-03-02 15:47 ` Yury Norov
2025-03-02 15:47 ` Yury Norov
2025-02-23 16:42 ` [PATCH 03/17] x86: Replace open-coded parity calculation with parity8() Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-24 15:24 ` Uros Bizjak
2025-02-24 15:24 ` Uros Bizjak
2025-02-24 21:55 ` H. Peter Anvin
2025-02-24 21:55 ` H. Peter Anvin
2025-02-24 22:08 ` Uros Bizjak
2025-02-24 22:08 ` Uros Bizjak
2025-02-24 22:18 ` H. Peter Anvin
2025-02-24 22:18 ` H. Peter Anvin
2025-02-25 3:36 ` H. Peter Anvin
2025-02-25 3:36 ` H. Peter Anvin
2025-02-24 22:17 ` Yury Norov
2025-02-24 22:17 ` Yury Norov
2025-02-24 22:21 ` H. Peter Anvin
2025-02-24 22:21 ` H. Peter Anvin
2025-02-24 22:30 ` Yury Norov
2025-02-24 22:30 ` Yury Norov
2025-02-25 22:46 ` David Laight
2025-02-25 22:46 ` David Laight
2025-02-26 0:26 ` H. Peter Anvin
2025-02-26 0:26 ` H. Peter Anvin
2025-02-23 16:42 ` [PATCH 04/17] media: media/test_drivers: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 05/17] media: pci: cx18-av-vbi: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 06/17] media: saa7115: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 07/17] serial: max3100: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-24 7:25 ` Jiri Slaby
2025-02-24 7:25 ` Jiri Slaby
2025-02-23 16:42 ` [PATCH 08/17] lib/bch: Replace open-coded parity calculation with parity32() Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 09/17] Input: joystick - " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 10/17] net: ethernet: oa_tc6: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 11/17] wifi: brcm80211: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-25 6:29 ` Arend Van Spriel
2025-02-25 6:29 ` Arend Van Spriel
2025-02-23 16:42 ` [PATCH 12/17] drm/bridge: dw-hdmi: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu [this message]
2025-02-23 16:42 ` [PATCH 13/17] mtd: ssfdc: " Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 14/17] fsi: i2cr: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 15/17] fsi: i2cr: Replace open-coded parity calculation with parity64() Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 16/17] Input: joystick - " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 16:42 ` [PATCH 17/17] nfp: bpf: " Kuan-Wei Chiu
2025-02-23 16:42 ` Kuan-Wei Chiu
2025-02-23 20:25 ` [PATCH 00/17] Introduce and use generic parity32/64 helper Uros Bizjak
2025-02-23 20:25 ` Uros Bizjak
2025-02-24 15:27 ` Yu-Chun Lin
2025-02-24 15:27 ` Yu-Chun Lin
2025-02-24 7:58 ` Jeremy Kerr
2025-02-24 7:58 ` Jeremy Kerr
2025-02-24 15:35 ` Yu-Chun Lin
2025-02-24 15:35 ` Yu-Chun Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223164217.2139331-14-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=andrew+netdev@lunn.ch \
--cc=andrzej.hajda@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=awalls@md.metrocast.net \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eajames@linux.ibm.com \
--cc=edumazet@google.com \
--cc=eleanor15x@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jirislaby@kernel.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=johannes@sipsolutions.net \
--cc=jonas@kwiboo.se \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kuba@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=louis.peens@corigine.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=rfoss@kernel.org \
--cc=richard@nod.at \
--cc=simona@ffwll.ch \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.