* [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
@ 2025-02-25 13:51 Alexander Stein
2025-02-26 6:53 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexander Stein @ 2025-02-25 13:51 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Alexander Stein, dri-devel, linux-kernel, Herve Codina
Polarity for DE is stored in bridge state. Use this flag for setting
the DE polarity in the bridge.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 54ad462d17ef7..95563aa1b450d 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -561,6 +561,8 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge,
REG_LVDS_FMT_HS_NEG_POLARITY : 0) |
(mode->flags & DRM_MODE_FLAG_NVSYNC ?
REG_LVDS_FMT_VS_NEG_POLARITY : 0);
+ val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ?
+ REG_LVDS_FMT_DE_NEG_POLARITY : 0;
/* Set up bits-per-pixel, 18bpp or 24bpp. */
if (lvds_format_24bpp) {
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
2025-02-25 13:51 [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity Alexander Stein
@ 2025-02-26 6:53 ` Dmitry Baryshkov
2025-02-26 7:25 ` Herve Codina
2025-02-26 17:39 ` Robert Foss
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-26 6:53 UTC (permalink / raw)
To: Alexander Stein
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Herve Codina
On Tue, Feb 25, 2025 at 02:51:13PM +0100, Alexander Stein wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
2025-02-25 13:51 [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity Alexander Stein
2025-02-26 6:53 ` Dmitry Baryshkov
@ 2025-02-26 7:25 ` Herve Codina
2025-02-26 17:39 ` Robert Foss
2 siblings, 0 replies; 4+ messages in thread
From: Herve Codina @ 2025-02-26 7:25 UTC (permalink / raw)
To: Alexander Stein
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Hi Alexander,
On Tue, 25 Feb 2025 14:51:13 +0100
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 54ad462d17ef7..95563aa1b450d 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -561,6 +561,8 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge,
> REG_LVDS_FMT_HS_NEG_POLARITY : 0) |
> (mode->flags & DRM_MODE_FLAG_NVSYNC ?
> REG_LVDS_FMT_VS_NEG_POLARITY : 0);
> + val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ?
> + REG_LVDS_FMT_DE_NEG_POLARITY : 0;
>
> /* Set up bits-per-pixel, 18bpp or 24bpp. */
> if (lvds_format_24bpp) {
Tested without regression on my system.
Tested-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
2025-02-25 13:51 [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity Alexander Stein
2025-02-26 6:53 ` Dmitry Baryshkov
2025-02-26 7:25 ` Herve Codina
@ 2025-02-26 17:39 ` Robert Foss
2 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2025-02-26 17:39 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alexander Stein
Cc: dri-devel, linux-kernel, Herve Codina
On Tue, 25 Feb 2025 14:51:13 +0100, Alexander Stein wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
>
>
Applied, thanks!
[1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity
(no commit info)
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-26 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 13:51 [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity Alexander Stein
2025-02-26 6:53 ` Dmitry Baryshkov
2025-02-26 7:25 ` Herve Codina
2025-02-26 17:39 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.