From: Simon Horman <horms@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor the Tx scheduler feature
Date: Mon, 3 Mar 2025 09:54:05 +0000 [thread overview]
Message-ID: <20250303095405.GQ1615191@kernel.org> (raw)
In-Reply-To: <20250226113409.446325-1-mateusz.polchlopek@intel.com>
On Wed, Feb 26, 2025 at 12:33:56PM +0100, Mateusz Polchlopek wrote:
> Embed ice_get_tx_topo_user_sel() inside the only caller:
> ice_devlink_tx_sched_layers_get().
> Instead of jump from the wrapper to the function that does "get" operation
> it does "get" itself.
>
> Remove unnecessary comment and make usage of str_enabled_disabled()
> in ice_init_tx_topology().
Hi Mateusz,
These changes seem reasonable to me.
But I wonder if they could be motivated in the commit message.
What I mean is, the commit message explains what has been done.
But I think it should explain why it has been done.
> Suggested-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
...
next prev parent reply other threads:[~2025-03-03 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 11:33 [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor the Tx scheduler feature Mateusz Polchlopek
2025-03-03 9:54 ` Simon Horman [this message]
2025-03-04 13:43 ` Szapar-Mudlaw, Martyna
2025-03-05 13:30 ` Szapar-Mudlaw, Martyna
2025-03-06 17:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303095405.GQ1615191@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=marcin.szycik@linux.intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.