From: "Krzysztof Wilczyński" <kw@linux.com>
To: Fan Ni <nifan.cxl@gmail.com>
Cc: Shradha Todi <shradha.t@samsung.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org,
manivannan.sadhasivam@linaro.org, lpieralisi@kernel.org,
robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com,
Jonathan.Cameron@huawei.com, a.manzanares@samsung.com,
pankaj.dubey@samsung.com, cassel@kernel.org, 18255117159@163.com,
xueshuai@linux.alibaba.com, renyu.zj@linux.alibaba.com,
will@kernel.org, mark.rutland@arm.com
Subject: Re: [PATCH v7 3/5] Add debugfs based silicon debug support in DWC
Date: Tue, 4 Mar 2025 15:44:52 +0900 [thread overview]
Message-ID: <20250304064452.GA2615015@rocinante> (raw)
In-Reply-To: <Z8YWILtSbQnvVqbF@debian>
Hello,
[...]
> > > What will happen if ret != 0? still return 0?
> >
> > Given that callers of dwc_pcie_debugfs_init() check for errors,
> > this probably should correctly bubble up any failure coming from
> > dwc_pcie_rasdes_debugfs_init().
> >
> > I made updates to the code directly on the current branch, have a look:
> >
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=1ff54f4cbaed9ec6994844967c36cf7ada4cbe5e
> >
> > Let me know if this is OK with you.
>
> It looks good to me.
>
> Feel free to add,
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
Will do. Thank you.
Krzysztof
next prev parent reply other threads:[~2025-03-04 6:48 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250221132011epcas5p4dea1e9ae5c09afaabcd1822f3a7d15c5@epcas5p4.samsung.com>
2025-02-21 13:15 ` [PATCH v7 0/5] Add support for debugfs based RAS DES feature in PCIe DW Shradha Todi
2025-02-21 13:15 ` [PATCH v7 1/5] perf/dwc_pcie: Move common DWC struct definitions to 'pcie-dwc.h' Shradha Todi
2025-02-25 14:47 ` Krzysztof Wilczyński
2025-02-26 1:55 ` Shuai Xue
2025-02-26 6:48 ` Krzysztof Wilczyński
2025-03-03 17:19 ` Fan Ni
2025-02-21 13:15 ` [PATCH v7 2/5] PCI: dwc: Add helper to find the Vendor Specific Extended Capability (VSEC) Shradha Todi
2025-03-03 17:22 ` Fan Ni
2025-02-21 13:15 ` [PATCH v7 3/5] Add debugfs based silicon debug support in DWC Shradha Todi
2025-02-23 8:51 ` Manivannan Sadhasivam
2025-03-03 17:48 ` Fan Ni
2025-03-03 19:46 ` Krzysztof Wilczyński
2025-03-03 20:50 ` Fan Ni
2025-03-04 6:44 ` Krzysztof Wilczyński [this message]
2025-03-04 14:54 ` Geert Uytterhoeven
2025-03-04 14:57 ` Geert Uytterhoeven
2025-03-04 15:46 ` Krzysztof Wilczyński
2025-03-04 16:52 ` Shradha Todi
2025-03-05 7:44 ` 'Krzysztof Wilczyński'
2025-03-05 9:04 ` Shradha Todi
2025-03-04 17:11 ` Manivannan Sadhasivam
2025-03-04 17:58 ` Krzysztof Wilczyński
2025-03-05 17:38 ` Bjorn Helgaas
2025-03-05 18:28 ` Manivannan Sadhasivam
2025-03-05 19:09 ` Krzysztof Wilczyński
2025-03-05 21:57 ` Krzysztof Wilczyński
2025-03-06 8:22 ` Geert Uytterhoeven
2025-03-06 9:02 ` Krzysztof Wilczyński
2025-03-07 9:37 ` Shradha Todi
2025-03-04 15:18 ` Manivannan Sadhasivam
2025-02-21 13:15 ` [PATCH v7 4/5] Add debugfs based error injection " Shradha Todi
2025-02-23 8:53 ` Manivannan Sadhasivam
2025-03-03 9:52 ` Krzysztof Wilczyński
2025-03-04 6:50 ` Krzysztof Wilczyński
2025-03-04 15:29 ` Manivannan Sadhasivam
2025-03-04 15:35 ` Krzysztof Wilczyński
2025-03-04 17:00 ` Shradha Todi
2025-03-05 7:26 ` 'Krzysztof Wilczyński'
2025-03-03 17:53 ` Fan Ni
2025-02-21 13:15 ` [PATCH v7 5/5] Add debugfs based statistical counter " Shradha Todi
2025-02-23 8:54 ` Manivannan Sadhasivam
2025-03-03 18:02 ` Fan Ni
2025-03-03 19:42 ` Krzysztof Wilczyński
2025-03-03 21:03 ` Fan Ni
2025-03-04 15:32 ` Manivannan Sadhasivam
2025-03-04 17:10 ` Shradha Todi
2025-03-05 4:26 ` Fan Ni
2025-03-07 9:47 ` Shradha Todi
2025-02-24 17:08 ` [PATCH v7 0/5] Add support for debugfs based RAS DES feature in PCIe DW Niklas Cassel
2025-02-25 8:28 ` Manivannan Sadhasivam
2025-02-25 14:33 ` Krzysztof Wilczyński
2025-02-25 14:35 ` Niklas Cassel
2025-02-25 17:15 ` Manivannan Sadhasivam
2025-02-25 14:30 ` Krzysztof Wilczyński
2025-03-03 19:51 ` Krzysztof Wilczyński
2025-02-28 11:43 ` Hrishikesh Deleep
2025-03-03 20:00 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304064452.GA2615015@rocinante \
--to=kw@linux.com \
--cc=18255117159@163.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=a.manzanares@samsung.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=nifan.cxl@gmail.com \
--cc=pankaj.dubey@samsung.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.