[scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module

All of lore.kernel.org
 help / color / mirror / Atom feed

* [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
@ 2025-03-06 20:37 Brandon Brnich
  2025-03-06 20:37 ` [scarthgap][PATCH 2/2] conf: machine: J721e: Add Dependency for IMG Driver Brandon Brnich
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Brandon Brnich @ 2025-03-06 20:37 UTC (permalink / raw)
  To: meta-ti; +Cc: Ryan Eatmon, Brandon Brnich, Darren Etheridge

During 10.0 LTS bringup, the decision was made that it would be the last LTS
that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
git.ti.com. This recipe is responsible for pulling in the driver,
building it, and packaging it within the J721e SDK.

Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---

This build was tested by changing the kernel to point towards latest
head that has relevant device tree changes and config options. Build is
successful with those changes and no warnings are present.

 .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb

diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
new file mode 100644
index 00000000..fa2d3792
--- /dev/null
+++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
@@ -0,0 +1,23 @@
+DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
+
+inherit module
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+COMPATIBLE_MACHINE = "j721e"
+
+DEPENDS += "virtual/kernel"
+
+BRANCH = "scarthgap/k${PV}"
+
+SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
+
+SRCREV = "99d063aa0ef53633057042570411b84bd967624b"
+
+TARGET_PRODUCT:j721e = "j721e_linux"
+
+S = "${WORKDIR}/git"
+
+EXTRA_OEMAKE += 'KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [scarthgap][PATCH 2/2] conf: machine: J721e: Add Dependency for IMG Driver
  2025-03-06 20:37 [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Brandon Brnich
@ 2025-03-06 20:37 ` Brandon Brnich
  2025-03-06 23:15 ` [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Denys Dmytriyenko
       [not found] ` <182A59C7642211D5.31492@lists.yoctoproject.org>
  2 siblings, 0 replies; 8+ messages in thread
From: Brandon Brnich @ 2025-03-06 20:37 UTC (permalink / raw)
  To: meta-ti; +Cc: Ryan Eatmon, Brandon Brnich, Darren Etheridge

IMG codec drivers reside only on the J721e SoC. Ensure that the drivers
are being built when building SDK.

Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
 meta-ti-bsp/conf/machine/include/j721e.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-ti-bsp/conf/machine/include/j721e.inc b/meta-ti-bsp/conf/machine/include/j721e.inc
index 1507234b..6264d5c8 100644
--- a/meta-ti-bsp/conf/machine/include/j721e.inc
+++ b/meta-ti-bsp/conf/machine/include/j721e.inc
@@ -36,4 +36,4 @@ TFA_BOARD = "generic"
 
 OPTEEMACHINE = "k3-j721e"
 
-MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw vxd-dec-fw ti-eth-fw"
+MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw vxd-dec-fw ti-eth-fw ti-vxe-vxd-driver"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
  2025-03-06 20:37 [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Brandon Brnich
  2025-03-06 20:37 ` [scarthgap][PATCH 2/2] conf: machine: J721e: Add Dependency for IMG Driver Brandon Brnich
@ 2025-03-06 23:15 ` Denys Dmytriyenko
       [not found] ` <182A59C7642211D5.31492@lists.yoctoproject.org>
  2 siblings, 0 replies; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-06 23:15 UTC (permalink / raw)
  To: b-brnich; +Cc: meta-ti, Ryan Eatmon, Darren Etheridge

On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
> During 10.0 LTS bringup, the decision was made that it would be the last LTS
> that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
> git.ti.com. This recipe is responsible for pulling in the driver,
> building it, and packaging it within the J721e SDK.
> 
> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> ---
> 
> This build was tested by changing the kernel to point towards latest
> head that has relevant device tree changes and config options. Build is
> successful with those changes and no warnings are present.
> 
>  .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> 
> diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> new file mode 100644
> index 00000000..fa2d3792
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"

Shorter SUMMARY is missing?


> +LICENSE = "GPL-2.0-only"
> +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
> +
> +inherit module
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +COMPATIBLE_MACHINE = "j721e"
> +
> +DEPENDS += "virtual/kernel"
> +
> +BRANCH = "scarthgap/k${PV}"
> +
> +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
> +
> +SRCREV = "99d063aa0ef53633057042570411b84bd967624b"
> +
> +TARGET_PRODUCT:j721e = "j721e_linux"
> +
> +S = "${WORKDIR}/git"
> +
> +EXTRA_OEMAKE += 'KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
> -- 
> 2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <182A59C7642211D5.31492@lists.yoctoproject.org>]

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
       [not found] ` <182A59C7642211D5.31492@lists.yoctoproject.org>
@ 2025-03-10 19:50   ` Denys Dmytriyenko
       [not found]   ` <182B88F400236EE2.13955@lists.yoctoproject.org>
  1 sibling, 0 replies; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-10 19:50 UTC (permalink / raw)
  To: b-brnich; +Cc: meta-ti, Ryan Eatmon, Darren Etheridge

On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote:
> On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
> > During 10.0 LTS bringup, the decision was made that it would be the last LTS
> > that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
> > git.ti.com. This recipe is responsible for pulling in the driver,
> > building it, and packaging it within the J721e SDK.
> > 
> > Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> > ---
> > 
> > This build was tested by changing the kernel to point towards latest
> > head that has relevant device tree changes and config options. Build is
> > successful with those changes and no warnings are present.
> > 
> >  .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > 
> > diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > new file mode 100644
> > index 00000000..fa2d3792
> > --- /dev/null
> > +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > @@ -0,0 +1,23 @@
> > +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
> 
> Shorter SUMMARY is missing?
> 
> 
> > +LICENSE = "GPL-2.0-only"
> > +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
> > +
> > +inherit module
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +COMPATIBLE_MACHINE = "j721e"
> > +
> > +DEPENDS += "virtual/kernel"
> > +
> > +BRANCH = "scarthgap/k${PV}"
> > +
> > +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"

Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for 
https access (i.e. one level of /git/ is missing):

WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available

Just do this to see other examples in meta-ti:

$ grep 'git://git.ti.com' * -r


> > +
> > +SRCREV = "99d063aa0ef53633057042570411b84bd967624b"
> > +
> > +TARGET_PRODUCT:j721e = "j721e_linux"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +EXTRA_OEMAKE += 'KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
> > -- 
> > 2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <182B88F400236EE2.13955@lists.yoctoproject.org>]

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
       [not found]   ` <182B88F400236EE2.13955@lists.yoctoproject.org>
@ 2025-03-10 20:29     ` Denys Dmytriyenko
  2025-03-10 20:39       ` Brandon Brnich
  0 siblings, 1 reply; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-10 20:29 UTC (permalink / raw)
  To: b-brnich; +Cc: meta-ti, Ryan Eatmon, Darren Etheridge

On Mon, Mar 10, 2025 at 03:50:56PM -0400, Denys Dmytriyenko wrote:
> On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote:
> > On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
> > > During 10.0 LTS bringup, the decision was made that it would be the last LTS
> > > that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
> > > git.ti.com. This recipe is responsible for pulling in the driver,
> > > building it, and packaging it within the J721e SDK.
> > > 
> > > Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> > > ---
> > > 
> > > This build was tested by changing the kernel to point towards latest
> > > head that has relevant device tree changes and config options. Build is
> > > successful with those changes and no warnings are present.
> > > 
> > >  .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
> > >  1 file changed, 23 insertions(+)
> > >  create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > 
> > > diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > new file mode 100644
> > > index 00000000..fa2d3792
> > > --- /dev/null
> > > +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > @@ -0,0 +1,23 @@
> > > +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
> > 
> > Shorter SUMMARY is missing?
> > 
> > 
> > > +LICENSE = "GPL-2.0-only"
> > > +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
> > > +
> > > +inherit module
> > > +
> > > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > +
> > > +COMPATIBLE_MACHINE = "j721e"
> > > +
> > > +DEPENDS += "virtual/kernel"
> > > +
> > > +BRANCH = "scarthgap/k${PV}"
> > > +
> > > +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
> 
> Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for 
> https access (i.e. one level of /git/ is missing):
> 
> WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available
> 
> Just do this to see other examples in meta-ti:
> 
> $ grep 'git://git.ti.com' * -r

And it fails to build:

| /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:24:9: warning: "MAX" redefined
|    24 | #define MAX(a, b, type) ({ \
|       |         ^~~
| In file included from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/kernel.h:28,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/cpufeature.h:26,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/processor.h:38,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/sched.h:13,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/ratelimit.h:6,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dev_printk.h:16,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/device.h:15,
|                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dma-mapping.h:8,
|                  from /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:16:
| /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/minmax.h:330:9: note: this is the location of the previous definition
|   330 | #define MAX(a,b) __cmp(max,a,b)
|       |         ^~~
|   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.o
|   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.o
|   MODPOST /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers
| ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.ko] undefined!
| ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.ko] undefined!
| make[4]: *** [/OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/scripts/Makefile.modpost:145: /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers] Error 1



> > > +
> > > +SRCREV = "99d063aa0ef53633057042570411b84bd967624b"
> > > +
> > > +TARGET_PRODUCT:j721e = "j721e_linux"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +EXTRA_OEMAKE += 'KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
> > > -- 
> > > 2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
  2025-03-10 20:29     ` Denys Dmytriyenko
@ 2025-03-10 20:39       ` Brandon Brnich
  2025-03-10 21:14         ` Denys Dmytriyenko
  0 siblings, 1 reply; 8+ messages in thread
From: Brandon Brnich @ 2025-03-10 20:39 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-ti, Ryan Eatmon, Darren Etheridge

Hi Denys,

On 16:29-20250310, Denys Dmytriyenko wrote:
> On Mon, Mar 10, 2025 at 03:50:56PM -0400, Denys Dmytriyenko wrote:
> > On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote:
> > > On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
> > > > During 10.0 LTS bringup, the decision was made that it would be the last LTS
> > > > that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
> > > > git.ti.com. This recipe is responsible for pulling in the driver,
> > > > building it, and packaging it within the J721e SDK.
> > > > 
> > > > Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> > > > ---
> > > > 
> > > > This build was tested by changing the kernel to point towards latest
> > > > head that has relevant device tree changes and config options. Build is
> > > > successful with those changes and no warnings are present.
> > > > 
> > > >  .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
> > > >  1 file changed, 23 insertions(+)
> > > >  create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > 
> > > > diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > new file mode 100644
> > > > index 00000000..fa2d3792
> > > > --- /dev/null
> > > > +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > @@ -0,0 +1,23 @@
> > > > +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
> > > 
> > > Shorter SUMMARY is missing?

Should I just change DESCRIPTION to SUMMARY? Why need both?

> > > 
> > > 
> > > > +LICENSE = "GPL-2.0-only"
> > > > +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
> > > > +
> > > > +inherit module
> > > > +
> > > > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > > +
> > > > +COMPATIBLE_MACHINE = "j721e"
> > > > +
> > > > +DEPENDS += "virtual/kernel"
> > > > +
> > > > +BRANCH = "scarthgap/k${PV}"
> > > > +
> > > > +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
> > 
> > Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for 
> > https access (i.e. one level of /git/ is missing):
> > 
> > WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available
> > 
> > Just do this to see other examples in meta-ti:
> > 
> > $ grep 'git://git.ti.com' * -r

Okay will also fix.

> 
> And it fails to build:
> 
> | /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:24:9: warning: "MAX" redefined
> |    24 | #define MAX(a, b, type) ({ \
> |       |         ^~~
> | In file included from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/kernel.h:28,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/cpufeature.h:26,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/processor.h:38,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/sched.h:13,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/ratelimit.h:6,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dev_printk.h:16,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/device.h:15,
> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dma-mapping.h:8,
> |                  from /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:16:
> | /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/minmax.h:330:9: note: this is the location of the previous definition
> |   330 | #define MAX(a,b) __cmp(max,a,b)
> |       |         ^~~
> |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.o
> |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.o
> |   MODPOST /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers
> | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.ko] undefined!
> | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.ko] undefined!
> | make[4]: *** [/OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/scripts/Makefile.modpost:145: /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers] Error 1
> 

I added this in the notes section that the kernel commit needed to point
at the HEAD of TI's 6.12.y-cicd branch in order to build due to a config
issue. The driver built and was validated against Scarthgap.

This patch can already be found in scarthgap tree[0]. I will submit new
patch to fix up the other comments you have made.

[0]: https://git.ti.com/cgit/arago-project/meta-ti/commit/?h=scarthgap&id=296344c8ea44b958269352cd5a417adfd9df9857

Best,
Brandon

> 
> 
> > > > +
> > > > +SRCREV = "99d063aa0ef53633057042570411b84bd967624b"
> > > > +
> > > > +TARGET_PRODUCT:j721e = "j721e_linux"
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +
> > > > +EXTRA_OEMAKE += 'KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
> > > > -- 
> > > > 2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
  2025-03-10 20:39       ` Brandon Brnich
@ 2025-03-10 21:14         ` Denys Dmytriyenko
  2025-03-11 16:43           ` Ryan Eatmon
  0 siblings, 1 reply; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-10 21:14 UTC (permalink / raw)
  To: b-brnich; +Cc: meta-ti, Ryan Eatmon, Darren Etheridge

On Mon, Mar 10, 2025 at 03:39:53PM -0500, Brandon Brnich via lists.yoctoproject.org wrote:
> Hi Denys,
> 
> On 16:29-20250310, Denys Dmytriyenko wrote:
> > On Mon, Mar 10, 2025 at 03:50:56PM -0400, Denys Dmytriyenko wrote:
> > > On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote:
> > > > On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
> > > > > During 10.0 LTS bringup, the decision was made that it would be the last LTS
> > > > > that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
> > > > > git.ti.com. This recipe is responsible for pulling in the driver,
> > > > > building it, and packaging it within the J721e SDK.
> > > > > 
> > > > > Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> > > > > ---
> > > > > 
> > > > > This build was tested by changing the kernel to point towards latest
> > > > > head that has relevant device tree changes and config options. Build is
> > > > > successful with those changes and no warnings are present.
> > > > > 
> > > > >  .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
> > > > >  1 file changed, 23 insertions(+)
> > > > >  create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > > 
> > > > > diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > > new file mode 100644
> > > > > index 00000000..fa2d3792
> > > > > --- /dev/null
> > > > > +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
> > > > > @@ -0,0 +1,23 @@
> > > > > +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
> > > > 
> > > > Shorter SUMMARY is missing?
> 
> Should I just change DESCRIPTION to SUMMARY? Why need both?

Sigh, I'm becoming a "broken record"...

https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-SUMMARY
SUMMARY - A short summary for the recipe, which is 72 characters or less.

This is mandatory.

https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-DESCRIPTION
DESCRIPTION - A long description for the recipe.

This is optional - SUMMARY is used if omitted.


> > > > > +LICENSE = "GPL-2.0-only"
> > > > > +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
> > > > > +
> > > > > +inherit module
> > > > > +
> > > > > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > > > +
> > > > > +COMPATIBLE_MACHINE = "j721e"
> > > > > +
> > > > > +DEPENDS += "virtual/kernel"
> > > > > +
> > > > > +BRANCH = "scarthgap/k${PV}"
> > > > > +
> > > > > +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
> > > 
> > > Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for 
> > > https access (i.e. one level of /git/ is missing):
> > > 
> > > WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available
> > > 
> > > Just do this to see other examples in meta-ti:
> > > 
> > > $ grep 'git://git.ti.com' * -r
> 
> Okay will also fix.
> 
> > 
> > And it fails to build:
> > 
> > | /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:24:9: warning: "MAX" redefined
> > |    24 | #define MAX(a, b, type) ({ \
> > |       |         ^~~
> > | In file included from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/kernel.h:28,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/cpufeature.h:26,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/processor.h:38,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/sched.h:13,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/ratelimit.h:6,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dev_printk.h:16,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/device.h:15,
> > |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dma-mapping.h:8,
> > |                  from /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:16:
> > | /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/minmax.h:330:9: note: this is the location of the previous definition
> > |   330 | #define MAX(a,b) __cmp(max,a,b)
> > |       |         ^~~
> > |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.o
> > |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.o
> > |   MODPOST /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers
> > | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.ko] undefined!
> > | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.ko] undefined!
> > | make[4]: *** [/OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/scripts/Makefile.modpost:145: /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers] Error 1
> > 
> 
> I added this in the notes section that the kernel commit needed to point
> at the HEAD of TI's 6.12.y-cicd branch in order to build due to a config
> issue. The driver built and was validated against Scarthgap.

This has been merged to master-wip, which is what I'm testing now. It seems 
required dependencies are not met.


> This patch can already be found in scarthgap tree[0]. I will submit new
> patch to fix up the other comments you have made.
> 
> [0]: https://git.ti.com/cgit/arago-project/meta-ti/commit/?h=scarthgap&id=296344c8ea44b958269352cd5a417adfd9df9857

This is unacceptable!!

The first comment was made the same day within couple of hours of the patch 
being posted to the list:
https://patchwork.yoctoproject.org/project/ti/patch/20250306203749.794759-1-b-brnich@ti.com/

There should be AT LEAST 24-48 hours allowed for patch reviews and comments. 
There should NOT be any pressure applied on the maintainer to merge the 
patches immediately.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module
  2025-03-10 21:14         ` Denys Dmytriyenko
@ 2025-03-11 16:43           ` Ryan Eatmon
  0 siblings, 0 replies; 8+ messages in thread
From: Ryan Eatmon @ 2025-03-11 16:43 UTC (permalink / raw)
  To: Denys Dmytriyenko, b-brnich; +Cc: meta-ti, Darren Etheridge



On 3/10/2025 4:14 PM, Denys Dmytriyenko wrote:
> On Mon, Mar 10, 2025 at 03:39:53PM -0500, Brandon Brnich via lists.yoctoproject.org wrote:
>> Hi Denys,
>>
>> On 16:29-20250310, Denys Dmytriyenko wrote:
>>> On Mon, Mar 10, 2025 at 03:50:56PM -0400, Denys Dmytriyenko wrote:
>>>> On Thu, Mar 06, 2025 at 06:15:13PM -0500, Denys Dmytriyenko wrote:
>>>>> On Thu, Mar 06, 2025 at 02:37:48PM -0600, Brandon Brnich via lists.yoctoproject.org wrote:
>>>>>> During 10.0 LTS bringup, the decision was made that it would be the last LTS
>>>>>> that carried the IMG VXE and VXD driver in tree. Driver is now hosted on
>>>>>> git.ti.com. This recipe is responsible for pulling in the driver,
>>>>>> building it, and packaging it within the J721e SDK.
>>>>>>
>>>>>> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
>>>>>> ---
>>>>>>
>>>>>> This build was tested by changing the kernel to point towards latest
>>>>>> head that has relevant device tree changes and config options. Build is
>>>>>> successful with those changes and no warnings are present.
>>>>>>
>>>>>>   .../ti-vxe-vxd-driver_6.12.bb                 | 23 +++++++++++++++++++
>>>>>>   1 file changed, 23 insertions(+)
>>>>>>   create mode 100644 meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
>>>>>>
>>>>>> diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
>>>>>> new file mode 100644
>>>>>> index 00000000..fa2d3792
>>>>>> --- /dev/null
>>>>>> +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/ti-vxe-vxd-driver_6.12.bb
>>>>>> @@ -0,0 +1,23 @@
>>>>>> +DESCRIPTION =  "Kernel drivers for the VXE384 and D5500 Video Accelerators found in the J721E TI SoC"
>>>>>
>>>>> Shorter SUMMARY is missing?
>>
>> Should I just change DESCRIPTION to SUMMARY? Why need both?
> 
> Sigh, I'm becoming a "broken record"...
> 
> https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-SUMMARY
> SUMMARY - A short summary for the recipe, which is 72 characters or less.
> 
> This is mandatory.
> 
> https://docs.yoctoproject.org/bitbake/bitbake-user-manual/bitbake-user-manual-ref-variables.html#term-DESCRIPTION
> DESCRIPTION - A long description for the recipe.
> 
> This is optional - SUMMARY is used if omitted.
> 
> 
>>>>>> +LICENSE = "GPL-2.0-only"
>>>>>> +LIC_FILES_CHKSUM = "file://README;beginline=11;endline=12;md5=ad10b552e357ac443ec5dd2e02912b1b"
>>>>>> +
>>>>>> +inherit module
>>>>>> +
>>>>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>>>> +
>>>>>> +COMPATIBLE_MACHINE = "j721e"
>>>>>> +
>>>>>> +DEPENDS += "virtual/kernel"
>>>>>> +
>>>>>> +BRANCH = "scarthgap/k${PV}"
>>>>>> +
>>>>>> +SRC_URI = "git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=${BRANCH}"
>>>>
>>>> Also, SRC_URI is incorrect - should be git://git.ti.com/git/multimedia/... for
>>>> https access (i.e. one level of /git/ is missing):
>>>>
>>>> WARNING: ti-vxe-vxd-driver-6.12-r0 do_fetch: Failed to fetch URL git://git.ti.com/multimedia/img-vxe-vxd.git;protocol=https;branch=scarthgap/k6.12, attempting MIRRORS if available
>>>>
>>>> Just do this to see other examples in meta-ti:
>>>>
>>>> $ grep 'git://git.ti.com' * -r
>>
>> Okay will also fix.
>>
>>>
>>> And it fails to build:
>>>
>>> | /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:24:9: warning: "MAX" redefined
>>> |    24 | #define MAX(a, b, type) ({ \
>>> |       |         ^~~
>>> | In file included from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/kernel.h:28,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/cpufeature.h:26,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/arch/arm64/include/asm/processor.h:38,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/sched.h:13,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/ratelimit.h:6,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dev_printk.h:16,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/device.h:15,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/dma-mapping.h:8,
>>> |                  from /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/encoder/vxe_enc.c:16:
>>> | /OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/include/linux/minmax.h:330:9: note: this is the location of the previous definition
>>> |   330 | #define MAX(a,b) __cmp(max,a,b)
>>> |       |         ^~~
>>> |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.o
>>> |   LD [M]  /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.o
>>> |   MODPOST /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers
>>> | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxe-enc.ko] undefined!
>>> | ERROR: modpost: "vb2_dma_sg_memops" [/OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/vxd-dec.ko] undefined!
>>> | make[4]: *** [/OE/arago-master/build/arago-tmp-default/work-shared/j721e-evm/kernel-source/scripts/Makefile.modpost:145: /OE/arago-master/build/arago-tmp-default/work/j721e_evm-oe-linux/ti-vxe-vxd-driver/6.12/git/Module.symvers] Error 1
>>>
>>
>> I added this in the notes section that the kernel commit needed to point
>> at the HEAD of TI's 6.12.y-cicd branch in order to build due to a config
>> issue. The driver built and was validated against Scarthgap.
> 
> This has been merged to master-wip, which is what I'm testing now. It seems
> required dependencies are not met.
> 
> 
>> This patch can already be found in scarthgap tree[0]. I will submit new
>> patch to fix up the other comments you have made.
>>
>> [0]: https://git.ti.com/cgit/arago-project/meta-ti/commit/?h=scarthgap&id=296344c8ea44b958269352cd5a417adfd9df9857
> 
> This is unacceptable!!
> 
> The first comment was made the same day within couple of hours of the patch
> being posted to the list:
> https://patchwork.yoctoproject.org/project/ti/patch/20250306203749.794759-1-b-brnich@ti.com/
> 
> There should be AT LEAST 24-48 hours allowed for patch reviews and comments.
> There should NOT be any pressure applied on the maintainer to merge the
> patches immediately.

That's my fault.  I was the one rushing this.

Brandon, send in a second patch fixing all of the reported comments.


-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-03-11 16:43 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 20:37 [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Brandon Brnich
2025-03-06 20:37 ` [scarthgap][PATCH 2/2] conf: machine: J721e: Add Dependency for IMG Driver Brandon Brnich
2025-03-06 23:15 ` [meta-ti] [scarthgap][PATCH 1/2] ti-bsp: ti-img-encode-decode: Add Recipe for Building VXE-VXD Out-of-Tree Module Denys Dmytriyenko
     [not found] ` <182A59C7642211D5.31492@lists.yoctoproject.org>
2025-03-10 19:50   ` Denys Dmytriyenko
     [not found]   ` <182B88F400236EE2.13955@lists.yoctoproject.org>
2025-03-10 20:29     ` Denys Dmytriyenko
2025-03-10 20:39       ` Brandon Brnich
2025-03-10 21:14         ` Denys Dmytriyenko
2025-03-11 16:43           ` Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.