All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-ti][scarthgap/master][PATCH v5 0/3] Enabiling gc320
@ 2025-03-18  2:38 a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 1/3] recipe-graphics: port gc320 driver to work on kernel 6.12 a-christidis
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: a-christidis @ 2025-03-18  2:38 UTC (permalink / raw)
  To: meta-ti

From: Antonios Christidis <a-christidis@ti.com>

The gc320 driver has been ported from kernel 6.1 to 6.12.
This patch series updates and sets up everything required to start
buidling gc320 again for kernel 6.12. 


This patch series goes hand in hand with a patch sent to meta-arago
updating the SRCREV of ti-gc320-tests. 

Regards,
Antonios

Antonios Christidis (3):
  recipe-graphics: port gc320 driver to work on kernel 6.12
  conf: machine: am57xx-evm: Enable gc320 machine feature for am57xx
  recipes-graphics: port gc320 libs to work on kernel 6.12

 meta-ti-bsp/conf/machine/include/ti-bsp.inc               | 3 ---
 .../gc320-drivers/ti-gc320-driver_5.0.11.p7.bb            | 4 ++--
 .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
 3 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [meta-ti][scarthgap/master][PATCH v5 1/3] recipe-graphics: port gc320 driver to work on kernel 6.12
  2025-03-18  2:38 [meta-ti][scarthgap/master][PATCH v5 0/3] Enabiling gc320 a-christidis
@ 2025-03-18  2:38 ` a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 2/3] conf: machine: am57xx-evm: Enable gc320 machine feature for am57xx a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12 a-christidis
  2 siblings, 0 replies; 8+ messages in thread
From: a-christidis @ 2025-03-18  2:38 UTC (permalink / raw)
  To: meta-ti

From: Antonios Christidis <a-christidis@ti.com>

Changes made on the gc320 kernel mode driver in order to work with kernel
6.12. There is no other change in functionality with this update, and the
driver version remains the same.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 .../recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-ti-bsp/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb b/meta-ti-bsp/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
index 818ed683..a6dc3e25 100644
--- a/meta-ti-bsp/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
+++ b/meta-ti-bsp/recipes-bsp/gc320-drivers/ti-gc320-driver_5.0.11.p7.bb
@@ -8,9 +8,9 @@ inherit module features_check
 REQUIRED_MACHINE_FEATURES = "gc320"
 
 # Need to branch out with ${PV} var
-BRANCH = "ti-${PV}-k5.10"
+BRANCH = "ti-${PV}-k6.12"
 
-SRCREV = "e2a10f31e255a65ec30a6e10b890e77d7e9cb107"
+SRCREV = "83afddf9dbf6a8458267b4dae21ee35bfb11f3d1"
 
 SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-driver.git;protocol=https;branch=${BRANCH}"
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [meta-ti][scarthgap/master][PATCH v5 2/3] conf: machine: am57xx-evm: Enable gc320 machine feature for am57xx
  2025-03-18  2:38 [meta-ti][scarthgap/master][PATCH v5 0/3] Enabiling gc320 a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 1/3] recipe-graphics: port gc320 driver to work on kernel 6.12 a-christidis
@ 2025-03-18  2:38 ` a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12 a-christidis
  2 siblings, 0 replies; 8+ messages in thread
From: a-christidis @ 2025-03-18  2:38 UTC (permalink / raw)
  To: meta-ti

From: Antonios Christidis <a-christidis@ti.com>

MACHINE_FEATURE gc320, already gets set on omap-a15.inc. But ti-bsp.inc file,
removes the feature. So, remove that portion of functionality from ti-bsp, in
order to allow the building of gc320 in kernel 6.12.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---

v4:
- Instead of commenting out, remove both lines

 meta-ti-bsp/conf/machine/include/ti-bsp.inc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
index 32beacee..054aa6cb 100644
--- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
+++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
@@ -58,9 +58,6 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_12 = "24%"
 BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_12 = "24%"
 BSP_MESA_PVR_VERSION:bsp-ti-6_12 = "24%"
 
-# GC320 support requires out-of-tree drivers not yet available in 6.12
-MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
-
 # ==========
 # ti-6_6
 # TI staging kernel 6.6, u-boot 2024.04
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12
  2025-03-18  2:38 [meta-ti][scarthgap/master][PATCH v5 0/3] Enabiling gc320 a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 1/3] recipe-graphics: port gc320 driver to work on kernel 6.12 a-christidis
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 2/3] conf: machine: am57xx-evm: Enable gc320 machine feature for am57xx a-christidis
@ 2025-03-18  2:38 ` a-christidis
  2025-03-18 21:01   ` Andrew Davis
  2 siblings, 1 reply; 8+ messages in thread
From: a-christidis @ 2025-03-18  2:38 UTC (permalink / raw)
  To: meta-ti

From: Antonios Christidis <a-christidis@ti.com>

The user mode libraries needed recompiling with the scarthgap revision of gcc to
remove all the warnings about 32bit API usage during the linking stage, new
SRCREV and branch includes this changes. Versions of the libraries remain the
same.

Signed-off-by: Antonios Christidis <a-christidis@ti>
---
v5:
- Move the symb link of libGAL.so within the ${PN} package. While making
  sure the header files are part of the ${PN}-dev package.

v3:
- Removed commented lines and extra lib directory that was being created
  in do_install()

v2:
- No longer include withing the PN package /usr/include file and symb
  link to library file. This is done by not chaning the FILES/PACKAGES
  variables, thus creating a -dev package.

 .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
index 807f421c..6b7226ab 100644
--- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
+++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
@@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
 
 CLEANBROKEN = "1"
 
-BRANCH = "ti-${PV}"
+BRANCH = "ti-${PV}-scarthgap"
 
 SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
-SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
+SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
 
 RRECOMMENDS:${PN} = "ti-gc320-driver"
 
@@ -43,4 +43,6 @@ do_install() {
     chown -R root:root ${D}
 }
 
-INSANE_SKIP:${PN} += "ldflags"
+FILES:${PN}:append = " ${libdir}"
+
+INSANE_SKIP:${PN} += "ldflags already-stripped dev-so"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12
  2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12 a-christidis
@ 2025-03-18 21:01   ` Andrew Davis
  2025-03-18 21:38     ` Denys Dmytriyenko
  0 siblings, 1 reply; 8+ messages in thread
From: Andrew Davis @ 2025-03-18 21:01 UTC (permalink / raw)
  To: a-christidis, meta-ti

On 3/17/25 9:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> The user mode libraries needed recompiling with the scarthgap revision of gcc to
> remove all the warnings about 32bit API usage during the linking stage, new
> SRCREV and branch includes this changes. Versions of the libraries remain the
> same.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti>
> ---
> v5:
> - Move the symb link of libGAL.so within the ${PN} package. While making
>    sure the header files are part of the ${PN}-dev package.
> 
> v3:
> - Removed commented lines and extra lib directory that was being created
>    in do_install()
> 
> v2:
> - No longer include withing the PN package /usr/include file and symb
>    link to library file. This is done by not chaning the FILES/PACKAGES
>    variables, thus creating a -dev package.
> 
>   .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> index 807f421c..6b7226ab 100644
> --- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> +++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> @@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
>   
>   CLEANBROKEN = "1"
>   
> -BRANCH = "ti-${PV}"
> +BRANCH = "ti-${PV}-scarthgap"
>   
>   SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
> -SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
> +SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
>   
>   RRECOMMENDS:${PN} = "ti-gc320-driver"
>   
> @@ -43,4 +43,6 @@ do_install() {
>       chown -R root:root ${D}
>   }
>   
> -INSANE_SKIP:${PN} += "ldflags"
> +FILES:${PN}:append = " ${libdir}"

FILES:${PN} += "${libdir}" ?

Andrew

> +
> +INSANE_SKIP:${PN} += "ldflags already-stripped dev-so"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#18399): https://lists.yoctoproject.org/g/meta-ti/message/18399
> Mute This Topic: https://lists.yoctoproject.org/mt/111763600/3619733
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12
  2025-03-18 21:01   ` Andrew Davis
@ 2025-03-18 21:38     ` Denys Dmytriyenko
  2025-03-19 18:22       ` [EXTERNAL] " Antonios Christidis
  0 siblings, 1 reply; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-18 21:38 UTC (permalink / raw)
  To: afd; +Cc: a-christidis, meta-ti

On Tue, Mar 18, 2025 at 04:01:37PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> On 3/17/25 9:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> >From: Antonios Christidis <a-christidis@ti.com>
> >
> >The user mode libraries needed recompiling with the scarthgap revision of gcc to
> >remove all the warnings about 32bit API usage during the linking stage, new
> >SRCREV and branch includes this changes. Versions of the libraries remain the
> >same.
> >
> >Signed-off-by: Antonios Christidis <a-christidis@ti>
> >---
> >v5:
> >- Move the symb link of libGAL.so within the ${PN} package. While making
> >   sure the header files are part of the ${PN}-dev package.
> >
> >v3:
> >- Removed commented lines and extra lib directory that was being created
> >   in do_install()
> >
> >v2:
> >- No longer include withing the PN package /usr/include file and symb
> >   link to library file. This is done by not chaning the FILES/PACKAGES
> >   variables, thus creating a -dev package.
> >
> >  .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> >diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >index 807f421c..6b7226ab 100644
> >--- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >+++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >@@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
> >  CLEANBROKEN = "1"
> >-BRANCH = "ti-${PV}"
> >+BRANCH = "ti-${PV}-scarthgap"
> >  SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
> >-SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
> >+SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
> >  RRECOMMENDS:${PN} = "ti-gc320-driver"
> >@@ -43,4 +43,6 @@ do_install() {
> >      chown -R root:root ${D}
> >  }
> >-INSANE_SKIP:${PN} += "ldflags"
> >+FILES:${PN}:append = " ${libdir}"
> 
> FILES:${PN} += "${libdir}" ?

1. I agree it's best not to use blank :append overrides and instead use +=
2. ${libdir} is already a default and doesn't need to be added explicitly

-- 
Denys


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [EXTERNAL] Re: [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12
  2025-03-18 21:38     ` Denys Dmytriyenko
@ 2025-03-19 18:22       ` Antonios Christidis
  2025-03-19 23:10         ` Denys Dmytriyenko
  0 siblings, 1 reply; 8+ messages in thread
From: Antonios Christidis @ 2025-03-19 18:22 UTC (permalink / raw)
  To: Denys Dmytriyenko, afd, Andrew Davis; +Cc: meta-ti


On 3/18/25 4:38 PM, Denys Dmytriyenko wrote:
> On Tue, Mar 18, 2025 at 04: 01: 37PM -0500, Andrew Davis via 
> lists. yoctoproject. org wrote: > On 3/17/25 9: 38 PM, Antonios 
> Christidis via lists. yoctoproject. org wrote: > >From: Antonios 
> Christidis <a-christidis@ ti. com> > >
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uPdqXRfP1m17CwYkHLKDfHEYvlwyW_vqb9VOfJCHARPcQCe_gAXq208Sc3o-G_CVgqCM4tPnpSqs9A$> 
>
> ZjQcmQRYFpfptBannerEnd
> On Tue, Mar 18, 2025 at 04:01:37PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> > On 3/17/25 9:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> > >From: Antonios Christidis <a-christidis@ti.com>
> > >
> > >The user mode libraries needed recompiling with the scarthgap revision of gcc to
> > >remove all the warnings about 32bit API usage during the linking stage, new
> > >SRCREV and branch includes this changes. Versions of the libraries remain the
> > >same.
> > >
> > >Signed-off-by: Antonios Christidis <a-christidis@ti>
> > >---
> > >v5:
> > >- Move the symb link of libGAL.so within the ${PN} package. While making
> > >   sure the header files are part of the ${PN}-dev package.
> > >
> > >v3:
> > >- Removed commented lines and extra lib directory that was being created
> > >   in do_install()
> > >
> > >v2:
> > >- No longer include withing the PN package /usr/include file and symb
> > >   link to library file. This is done by not chaning the FILES/PACKAGES
> > >   variables, thus creating a -dev package.
> > >
> > >  .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > >diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> > >index 807f421c..6b7226ab 100644
> > >--- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> > >+++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> > >@@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
> > >  CLEANBROKEN = "1"
> > >-BRANCH = "ti-${PV}"
> > >+BRANCH = "ti-${PV}-scarthgap"
> > >  SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
> > >-SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
> > >+SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
> > >  RRECOMMENDS:${PN} = "ti-gc320-driver"
> > >@@ -43,4 +43,6 @@ do_install() {
> > >      chown -R root:root ${D}
> > >  }
> > >-INSANE_SKIP:${PN} += "ldflags"
> > >+FILES:${PN}:append = " ${libdir}"
> > 
> > FILES:${PN} += "${libdir}" ?
>
> 1. I agree it's best not to use blank :append overrides and instead use +=
> 2. ${libdir} is already a default and doesn't need to be added explicitly

Regarding #1, moving forward I'll prefer to use "+=" instead of the 
"append". This will be included in a new version of the series.
Regarding #2, the default search pattern for ${PN} packages is: 
"/usr/lib/lib*.so.* /usr/lib/*.so.*" so the symb link would never get 
included in the ${PN} package. I was not clear enough when making my 
change, but by explicitly stating ${libdir} the symb link is included in 
the ${PN} package.

> -- 
> Denys


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [EXTERNAL] Re: [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12
  2025-03-19 18:22       ` [EXTERNAL] " Antonios Christidis
@ 2025-03-19 23:10         ` Denys Dmytriyenko
  0 siblings, 0 replies; 8+ messages in thread
From: Denys Dmytriyenko @ 2025-03-19 23:10 UTC (permalink / raw)
  To: Antonios Christidis; +Cc: afd, meta-ti

On Wed, Mar 19, 2025 at 01:22:41PM -0500, Antonios Christidis wrote:
> 
> On 3/18/25 4:38 PM, Denys Dmytriyenko wrote:
> >On Tue, Mar 18, 2025 at 04: 01: 37PM -0500, Andrew Davis via
> >lists. yoctoproject. org wrote: > On 3/17/25 9: 38 PM, Antonios
> >Christidis via lists. yoctoproject. org wrote: > >From: Antonios
> >Christidis <a-christidis@ ti. com> > >
> >ZjQcmQRYFpfptBannerStart
> >This message was sent from outside of Texas Instruments.
> >Do not click links or open attachments unless you recognize the
> >source of this email and know the content is safe.
> >Report Suspicious
> ><https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uPdqXRfP1m17CwYkHLKDfHEYvlwyW_vqb9VOfJCHARPcQCe_gAXq208Sc3o-G_CVgqCM4tPnpSqs9A$>
> >
> >ZjQcmQRYFpfptBannerEnd
> >On Tue, Mar 18, 2025 at 04:01:37PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> >> On 3/17/25 9:38 PM, Antonios Christidis via lists.yoctoproject.org wrote:
> >> >From: Antonios Christidis <a-christidis@ti.com>
> >> >
> >> >The user mode libraries needed recompiling with the scarthgap revision of gcc to
> >> >remove all the warnings about 32bit API usage during the linking stage, new
> >> >SRCREV and branch includes this changes. Versions of the libraries remain the
> >> >same.
> >> >
> >> >Signed-off-by: Antonios Christidis <a-christidis@ti>
> >> >---
> >> >v5:
> >> >- Move the symb link of libGAL.so within the ${PN} package. While making
> >> >   sure the header files are part of the ${PN}-dev package.
> >> >
> >> >v3:
> >> >- Removed commented lines and extra lib directory that was being created
> >> >   in do_install()
> >> >
> >> >v2:
> >> >- No longer include withing the PN package /usr/include file and symb
> >> >   link to library file. This is done by not chaning the FILES/PACKAGES
> >> >   variables, thus creating a -dev package.
> >> >
> >> >  .../recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb    | 8 +++++---
> >> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >> >
> >> >diff --git a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >index 807f421c..6b7226ab 100644
> >> >--- a/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >+++ b/meta-ti-bsp/recipes-graphics/libgal/ti-gc320-libs_5.0.11.p7.bb
> >> >@@ -11,10 +11,10 @@ COMPATIBLE_MACHINE = "omap-a15"
> >> >  CLEANBROKEN = "1"
> >> >-BRANCH = "ti-${PV}"
> >> >+BRANCH = "ti-${PV}-scarthgap"
> >> >  SRC_URI = "git://git.ti.com/git/graphics/ti-gc320-libs.git;protocol=https;branch=${BRANCH}"
> >> >-SRCREV = "c0afab259de59909cfe74c01f3f7fbaa147f94b5"
> >> >+SRCREV = "85c175e8425c33dda6e272aeb45afe0f69a79096"
> >> >  RRECOMMENDS:${PN} = "ti-gc320-driver"
> >> >@@ -43,4 +43,6 @@ do_install() {
> >> >      chown -R root:root ${D}
> >> >  }
> >> >-INSANE_SKIP:${PN} += "ldflags"
> >> >+FILES:${PN}:append = " ${libdir}"
> >> > FILES:${PN} += "${libdir}" ?
> >
> >1. I agree it's best not to use blank :append overrides and instead use +=
> >2. ${libdir} is already a default and doesn't need to be added explicitly
> 
> Regarding #1, moving forward I'll prefer to use "+=" instead of the
> "append". This will be included in a new version of the series.
> Regarding #2, the default search pattern for ${PN} packages is:
> "/usr/lib/lib*.so.* /usr/lib/*.so.*" so the symb link would never
> get included in the ${PN} package. I was not clear enough when
> making my change, but by explicitly stating ${libdir} the symb link
> is included in the ${PN} package.

As I had previously detailed in another thread to you[1], the best approach 
is to override SOLIBS and FILES_SOLIBSDEV variables to make it explicit:
[1] https://lists.yoctoproject.org/g/meta-arago/message/15960

SOLIBS = ".so"
FILES_SOLIBSDEV = ""

It is also acceptable to adjust FILES:${PN} for the same, but you do want to 
explain it, e.g. in the comment...

-- 
Denys


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-03-19 23:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18  2:38 [meta-ti][scarthgap/master][PATCH v5 0/3] Enabiling gc320 a-christidis
2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 1/3] recipe-graphics: port gc320 driver to work on kernel 6.12 a-christidis
2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 2/3] conf: machine: am57xx-evm: Enable gc320 machine feature for am57xx a-christidis
2025-03-18  2:38 ` [meta-ti][scarthgap/master][PATCH v5 3/3] recipes-graphics: port gc320 libs to work on kernel 6.12 a-christidis
2025-03-18 21:01   ` Andrew Davis
2025-03-18 21:38     ` Denys Dmytriyenko
2025-03-19 18:22       ` [EXTERNAL] " Antonios Christidis
2025-03-19 23:10         ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.