All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Jai Luthra <jai.luthra@ideasonboard.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH v3 1/7] i2c: core: Drop duplicate check before calling OF APIs
Date: Mon,  7 Apr 2025 18:44:57 +0300	[thread overview]
Message-ID: <20250407154937.744466-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250407154937.744466-1-andriy.shevchenko@linux.intel.com>

OF APIs are usually NULL-aware and returns an error in case when
device node is not present or supported. We already have a check
for the returned value, no need to check for the parameter.

Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/i2c-core-base.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index ebda3926acf8..0d850d425734 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1213,11 +1213,9 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
 	u32 addr = default_addr;
 	int i;
 
-	if (np) {
-		i = of_property_match_string(np, "reg-names", name);
-		if (i >= 0)
-			of_property_read_u32_index(np, "reg", i, &addr);
-	}
+	i = of_property_match_string(np, "reg-names", name);
+	if (i >= 0)
+		of_property_read_u32_index(np, "reg", i, &addr);
 
 	dev_dbg(&client->adapter->dev, "Address for %s : 0x%x\n", name, addr);
 	return i2c_new_dummy_device(client->adapter, addr);
@@ -1655,12 +1653,10 @@ int i2c_add_adapter(struct i2c_adapter *adapter)
 	struct device *dev = &adapter->dev;
 	int id;
 
-	if (dev->of_node) {
-		id = of_alias_get_id(dev->of_node, "i2c");
-		if (id >= 0) {
-			adapter->nr = id;
-			return __i2c_add_numbered_adapter(adapter);
-		}
+	id = of_alias_get_id(dev->of_node, "i2c");
+	if (id >= 0) {
+		adapter->nr = id;
+		return __i2c_add_numbered_adapter(adapter);
 	}
 
 	mutex_lock(&core_lock);
-- 
2.47.2


  reply	other threads:[~2025-04-07 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 15:44 [PATCH v3 0/7] i2c: core: Move client towards fwnode Andy Shevchenko
2025-04-07 15:44 ` Andy Shevchenko [this message]
2025-04-08 14:43   ` [PATCH v3 1/7] i2c: core: Drop duplicate check before calling OF APIs Sakari Ailus
2025-04-07 15:44 ` [PATCH v3 2/7] i2c: core: Unify the firmware node type check Andy Shevchenko
2025-04-07 15:44 ` [PATCH v3 3/7] i2c: core: Switch to fwnode APIs to get IRQ Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 4/7] i2c: core: Reuse fwnode variable where it makes sense Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 5/7] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 6/7] i2c: core: Deprecate of_node in struct i2c_board_info Andy Shevchenko
2025-04-08 14:42   ` Sakari Ailus
2025-04-08 14:47     ` Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 7/7] media: i2c: ds90ub960: Remove of_node assignment Andy Shevchenko
2025-04-08 14:43 ` [PATCH v3 0/7] i2c: core: Move client towards fwnode Sakari Ailus
2025-04-08 14:48   ` Andy Shevchenko
2025-04-08 15:08     ` Sakari Ailus
2025-04-08 16:35       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407154937.744466-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.