From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH v3 7/7] media: i2c: ds90ub960: Remove of_node assignment
Date: Mon, 7 Apr 2025 18:45:03 +0300 [thread overview]
Message-ID: <20250407154937.744466-8-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20250407154937.744466-1-andriy.shevchenko@linux.intel.com>
Remove of_node assignment which duplicates fwnode in struct i2c_board_info.
In general drivers must not set both, it's quite confusing. The I²C core
will consider fwnode with a priority and of_node is subject to remove from
above mentioned data structure.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/i2c/ds90ub960.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index 5dde8452739b..5afdbbad9ff4 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -1682,7 +1682,6 @@ static int ub960_rxport_add_serializer(struct ub960_data *priv, u8 nport)
struct device *dev = &priv->client->dev;
struct ds90ub9xx_platform_data *ser_pdata = &rxport->ser.pdata;
struct i2c_board_info ser_info = {
- .of_node = to_of_node(rxport->ser.fwnode),
.fwnode = rxport->ser.fwnode,
.platform_data = ser_pdata,
};
--
2.47.2
next prev parent reply other threads:[~2025-04-07 15:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:44 [PATCH v3 0/7] i2c: core: Move client towards fwnode Andy Shevchenko
2025-04-07 15:44 ` [PATCH v3 1/7] i2c: core: Drop duplicate check before calling OF APIs Andy Shevchenko
2025-04-08 14:43 ` Sakari Ailus
2025-04-07 15:44 ` [PATCH v3 2/7] i2c: core: Unify the firmware node type check Andy Shevchenko
2025-04-07 15:44 ` [PATCH v3 3/7] i2c: core: Switch to fwnode APIs to get IRQ Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 4/7] i2c: core: Reuse fwnode variable where it makes sense Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 5/7] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 6/7] i2c: core: Deprecate of_node in struct i2c_board_info Andy Shevchenko
2025-04-08 14:42 ` Sakari Ailus
2025-04-08 14:47 ` Andy Shevchenko
2025-04-07 15:45 ` Andy Shevchenko [this message]
2025-04-08 14:43 ` [PATCH v3 0/7] i2c: core: Move client towards fwnode Sakari Ailus
2025-04-08 14:48 ` Andy Shevchenko
2025-04-08 15:08 ` Sakari Ailus
2025-04-08 16:35 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407154937.744466-8-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.