From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v3 6/7] i2c: core: Deprecate of_node in struct i2c_board_info
Date: Tue, 8 Apr 2025 17:47:48 +0300 [thread overview]
Message-ID: <Z_U3FNa0ay_Sb9Cs@smile.fi.intel.com> (raw)
In-Reply-To: <Z_U162kNEPSZI3zD@kekkonen.localdomain>
On Tue, Apr 08, 2025 at 02:42:51PM +0000, Sakari Ailus wrote:
> On Mon, Apr 07, 2025 at 06:45:02PM +0300, Andy Shevchenko wrote:
> > Two members of the same or similar semantics is quite confusing to begin with.
> > Moreover, the fwnode covers all possible firmware descriptions that Linux kernel
> > supports. Deprecate of_node in struct i2c_board_info, so users will be warned
> > and in the future remote it completely.
>
> Too long lines, should be up to 75 characters long only.
It's media CI complains, but this code is for I²C :-)
But in _this_ case I agree with you. It's more for the
external users of Git, rather than for us.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-08 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 15:44 [PATCH v3 0/7] i2c: core: Move client towards fwnode Andy Shevchenko
2025-04-07 15:44 ` [PATCH v3 1/7] i2c: core: Drop duplicate check before calling OF APIs Andy Shevchenko
2025-04-08 14:43 ` Sakari Ailus
2025-04-07 15:44 ` [PATCH v3 2/7] i2c: core: Unify the firmware node type check Andy Shevchenko
2025-04-07 15:44 ` [PATCH v3 3/7] i2c: core: Switch to fwnode APIs to get IRQ Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 4/7] i2c: core: Reuse fwnode variable where it makes sense Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 5/7] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2025-04-07 15:45 ` [PATCH v3 6/7] i2c: core: Deprecate of_node in struct i2c_board_info Andy Shevchenko
2025-04-08 14:42 ` Sakari Ailus
2025-04-08 14:47 ` Andy Shevchenko [this message]
2025-04-07 15:45 ` [PATCH v3 7/7] media: i2c: ds90ub960: Remove of_node assignment Andy Shevchenko
2025-04-08 14:43 ` [PATCH v3 0/7] i2c: core: Move client towards fwnode Sakari Ailus
2025-04-08 14:48 ` Andy Shevchenko
2025-04-08 15:08 ` Sakari Ailus
2025-04-08 16:35 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_U3FNa0ay_Sb9Cs@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.