Re: [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1

From: Conor Dooley <conor@kernel.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr,
	dlan@gentoo.org, p.zabel@pengutronix.de, drew@pdp7.com,
	inochiama@gmail.com, geert+renesas@glider.be, heylenay@4d2.org,
	tglx@linutronix.de, hal.feng@starfivetech.com,
	unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
	elder@riscstar.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1
Date: Fri, 11 Apr 2025 17:43:00 +0100	[thread overview]
Message-ID: <20250411-spoiler-dispatch-8f709700a996@spud> (raw)
In-Reply-To: <20250411131423.3802611-4-guodong@riscstar.com>

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

On Fri, Apr 11, 2025 at 09:14:17PM +0800, Guodong Xu wrote:
> Add "spacemit,k1-pwm" as a compatible string to support the PWM
> controller on the SpacemiT K1 platform.
> 
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
>  Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> index 9640d4b627c2..1e3cabf6a89a 100644
> --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml
> @@ -19,6 +19,7 @@ properties:
>        - marvell,pxa270-pwm
>        - marvell,pxa168-pwm
>        - marvell,pxa910-pwm
> +      - spacemit,k1-pwm

The driver doesn't appear to handle this differently to existing
compatibles, why is a fallback not used?

>  
>    reg:
>      # Length should be 0x10
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]