Re: [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3

From: Yixun Lan <dlan@gentoo.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Guodong Xu <guodong@riscstar.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
	drew@pdp7.com, inochiama@gmail.com, geert+renesas@glider.be,
	heylenay@4d2.org, tglx@linutronix.de, hal.feng@starfivetech.com,
	unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
	elder@riscstar.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3
Date: Mon, 14 Apr 2025 08:03:44 +0000	[thread overview]
Message-ID: <20250414080344-GYA28186@gentoo> (raw)
In-Reply-To: <5lfnxricxm2k3fuf6nfvjd6cbkmsjkx7inoi52uy5uwwvld7sq@abn4i62tdics>

Hi Uwe,

On 07:58 Mon 14 Apr     , Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Apr 11, 2025 at 09:14:21PM +0800, Guodong Xu wrote:
> > +&pwm14 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pwm14_1_cfg>;
> > +	status = "disabled";
> > +};
> 
> I wonder if the pinctrl properties can better be added to the SoC's
> .dtsi file. (Only applies if this is a canonical choice, i.e. there is
> no other possible output configuration.)
> 
I'd agree it's a good idea and should follow, but unfortunately in the
practical case, all pwm able to route to at least two different pins..

https://developer.spacemit.com/documentation?token=YiJZwXA2Ri4nJikV9E1cp6nqnMh
see section: 4.5 Multi-Function I/O Pin Assignments

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55