From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH 10/11] usb: xhci: add individual allocation checks in xhci_mem_init()
Date: Fri, 11 Apr 2025 12:11:54 +0300 [thread overview]
Message-ID: <20250411091155.3386971-11-niklas.neronin@linux.intel.com> (raw)
In-Reply-To: <20250411091155.3386971-1-niklas.neronin@linux.intel.com>
Break up the existing multi-allocation checks into individual checks.
Add missing allocation check for 'xhci->interrupters'.
Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
---
drivers/usb/host/xhci-mem.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 2d1f320e5fd6..a45d96a5ef5f 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2390,11 +2390,13 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
else
xhci->segment_pool = dma_pool_create("xHCI ring segments", dev,
TRB_SEGMENT_SIZE, TRB_SEGMENT_SIZE, xhci->page_size);
+ if (!xhci->segment_pool)
+ goto fail;
/* See Table 46 and Note on Figure 55 */
xhci->device_pool = dma_pool_create("xHCI input/output contexts", dev,
2112, 64, xhci->page_size);
- if (!xhci->segment_pool || !xhci->device_pool)
+ if (!xhci->device_pool)
goto fail;
/* Linear stream context arrays don't have any boundary restrictions,
@@ -2403,6 +2405,9 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
xhci->small_streams_pool =
dma_pool_create("xHCI 256 byte stream ctx arrays",
dev, SMALL_STREAM_ARRAY_SIZE, 16, 0);
+ if (!xhci->small_streams_pool)
+ goto fail;
+
xhci->medium_streams_pool =
dma_pool_create("xHCI 1KB stream ctx arrays",
dev, MEDIUM_STREAM_ARRAY_SIZE, 16, 0);
@@ -2410,7 +2415,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
* will be allocated with dma_alloc_coherent()
*/
- if (!xhci->small_streams_pool || !xhci->medium_streams_pool)
+ if (!xhci->medium_streams_pool)
goto fail;
/* Set up the command ring to have one segments for now. */
@@ -2433,6 +2438,8 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
"Allocating primary event ring");
xhci->interrupters = kcalloc_node(xhci->max_interrupters, sizeof(*xhci->interrupters),
flags, dev_to_node(dev));
+ if (!xhci->interrupters)
+ goto fail;
xhci->interrupters[0] = xhci_alloc_interrupter(xhci, 0, flags);
if (!xhci->interrupters[0])
--
2.47.2
next prev parent reply other threads:[~2025-04-11 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 9:11 [PATCH 00/11] usb: xhci: decouple allocation and initialization Niklas Neronin
2025-04-11 9:11 ` [PATCH 01/11] usb: xhci: relocate pre-allocation initialization Niklas Neronin
2025-04-11 9:11 ` [PATCH 02/11] usb: xhci: move device slot enabling register write Niklas Neronin
2025-04-11 9:11 ` [PATCH 03/11] usb: xhci: move command ring pointer write Niklas Neronin
2025-04-11 9:11 ` [PATCH 04/11] usb: xhci: refactor xhci_set_cmd_ring_deq() Niklas Neronin
2025-04-11 9:11 ` [PATCH 05/11] usb: xhci: move DCBAA pointer write Niklas Neronin
2025-04-11 15:05 ` Sergey Shtylyov
2025-04-11 9:11 ` [PATCH 06/11] usb: xhci: move doorbell array pointer assignment Niklas Neronin
2025-04-11 9:11 ` [PATCH 07/11] usb: xhci: move enabling of USB 3 device notifications Niklas Neronin
2025-04-11 9:11 ` [PATCH 08/11] usb: xhci: remove error handling from xhci_add_interrupter() Niklas Neronin
2025-04-11 9:11 ` [PATCH 09/11] usb: xhci: move initialization of the primary interrupter Niklas Neronin
2025-04-11 9:11 ` Niklas Neronin [this message]
2025-04-11 9:11 ` [PATCH 11/11] usb: xhci: cleanup xhci_mem_init() Niklas Neronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411091155.3386971-11-niklas.neronin@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.