Re: [PATCH 05/11] usb: xhci: move DCBAA pointer write

[Sergey Shtylyov <sergei.shtylyov@gmail.com>]

On 4/11/25 12:11 PM, Niklas Neronin wrote:

> Move the Device Context Base Address Array (DCBAA) pointer write from
> xhci_mem_init() to xhci_init(). This is part of the ongoing effort to
> separate allocation and initialization.
> 
> Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
[...]

> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 5f630e74b323..431c922b3f2d 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -544,6 +544,9 @@ static int xhci_init(struct usb_hcd *hcd)
>  	/* Set the address in the Command Ring Control register */
>  	xhci_set_cmd_ring_deq(xhci);
>  
> +	/* Set Device Context Base Address pointer */

   "Array" missing here?

> +	xhci_write_64(xhci, xhci->dcbaa->dma, &xhci->op_regs->dcbaa_ptr);
> +
>  	/* Initializing Compliance Mode Recovery Data If Needed */
>  	if (xhci_compliance_mode_recovery_timer_quirk_check()) {
>  		xhci->quirks |= XHCI_COMP_MODE_QUIRK;

MBR, Sergey