From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
<jdamato@fastly.com>, <intel-wired-lan@lists.osuosl.org>,
<netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Igor Raits" <igor@gooddata.com>,
Daniel Secik <daniel.secik@gooddata.com>,
"Zdenek Pesek" <zdenek.pesek@gooddata.com>,
"Eric Dumazet" <edumazet@google.com>,
Martin Karsten <mkarsten@uwaterloo.ca>,
"Ahmed Zaki" <ahmed.zaki@intel.com>,
"Czapnik, Lukasz" <lukasz.czapnik@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad)
Date: Tue, 15 Apr 2025 17:53:59 -0700 [thread overview]
Message-ID: <20250415175359.3c6117c9@kernel.org> (raw)
In-Reply-To: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com>
On Tue, 15 Apr 2025 16:38:40 +0200 Przemek Kitszel wrote:
> > We traced the issue to commit 492a044508ad13a490a24c66f311339bf891cb5f
> > "ice: Add support for persistent NAPI config".
>
> thank you for the report and bisection,
> this commit is ice's opt-in into using persistent napi_config
>
> I have checked the code, and there is nothing obvious to inflate memory
> consumption in the driver/core in the touched parts. I have not yet
> looked into how much memory is eaten by the hash array of now-kept
> configs.
+1 also unclear to me how that commit makes any difference.
Jaroslav, when you say "traced" what do you mean?
CONFIG_MEM_ALLOC_PROFILING ?
The napi_config struct is just 24B. The queue struct (we allocate
napi_config for each queue) is 320B...
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
<jdamato@fastly.com>, <intel-wired-lan@lists.osuosl.org>,
<netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Igor Raits" <igor@gooddata.com>,
Daniel Secik <daniel.secik@gooddata.com>,
"Zdenek Pesek" <zdenek.pesek@gooddata.com>,
"Eric Dumazet" <edumazet@google.com>,
Martin Karsten <mkarsten@uwaterloo.ca>,
"Ahmed Zaki" <ahmed.zaki@intel.com>,
"Czapnik, Lukasz" <lukasz.czapnik@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad)
Date: Tue, 15 Apr 2025 17:53:59 -0700 [thread overview]
Message-ID: <20250415175359.3c6117c9@kernel.org> (raw)
In-Reply-To: <4a061a51-8a6c-42b8-9957-66073b4bc65f@intel.com>
On Tue, 15 Apr 2025 16:38:40 +0200 Przemek Kitszel wrote:
> > We traced the issue to commit 492a044508ad13a490a24c66f311339bf891cb5f
> > "ice: Add support for persistent NAPI config".
>
> thank you for the report and bisection,
> this commit is ice's opt-in into using persistent napi_config
>
> I have checked the code, and there is nothing obvious to inflate memory
> consumption in the driver/core in the touched parts. I have not yet
> looked into how much memory is eaten by the hash array of now-kept
> configs.
+1 also unclear to me how that commit makes any difference.
Jaroslav, when you say "traced" what do you mean?
CONFIG_MEM_ALLOC_PROFILING ?
The napi_config struct is just 24B. The queue struct (we allocate
napi_config for each queue) is 320B...
next prev parent reply other threads:[~2025-04-16 0:59 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 16:29 [Intel-wired-lan] Increased memory usage on NUMA nodes with ICE driver after upgrade to 6.13.y (regression in commit 492a044508ad) Jaroslav Pulchart
2025-04-14 16:29 ` Jaroslav Pulchart
2025-04-14 17:15 ` [Intel-wired-lan] " Paul Menzel
2025-04-15 14:38 ` Przemek Kitszel
2025-04-15 14:38 ` Przemek Kitszel
2025-04-16 0:53 ` Jakub Kicinski [this message]
2025-04-16 0:53 ` Jakub Kicinski
2025-04-16 7:13 ` [Intel-wired-lan] " Jaroslav Pulchart
2025-04-16 7:13 ` Jaroslav Pulchart
2025-04-16 13:48 ` [Intel-wired-lan] " Jakub Kicinski
2025-04-16 13:48 ` Jakub Kicinski
2025-04-16 16:03 ` [Intel-wired-lan] " Jaroslav Pulchart
2025-04-16 16:03 ` Jaroslav Pulchart
2025-04-16 22:44 ` [Intel-wired-lan] " Jakub Kicinski
2025-04-16 22:44 ` Jakub Kicinski
2025-04-16 22:57 ` [Intel-wired-lan] " Keller, Jacob E
2025-04-16 22:57 ` Keller, Jacob E
2025-04-16 22:57 ` Keller, Jacob E
2025-04-16 22:57 ` Keller, Jacob E
2025-04-17 0:13 ` Jakub Kicinski
2025-04-17 17:52 ` Keller, Jacob E
2025-04-17 17:52 ` Keller, Jacob E
2025-05-21 9:32 ` Jaroslav Pulchart
2025-05-21 10:50 ` Jaroslav Pulchart
2025-06-04 8:42 ` Jaroslav Pulchart
2025-06-25 12:17 ` Jaroslav Pulchart
2025-06-25 14:03 ` Przemek Kitszel
2025-06-25 17:51 ` Jaroslav Pulchart
2025-06-25 20:25 ` Jakub Kicinski
2025-06-26 7:42 ` Jaroslav Pulchart
2025-06-30 7:35 ` Jaroslav Pulchart
2025-06-30 16:02 ` Jacob Keller
2025-06-30 17:24 ` Jaroslav Pulchart
2025-06-30 18:59 ` Jacob Keller
2025-06-30 20:01 ` Jaroslav Pulchart
2025-06-30 20:42 ` Jacob Keller
2025-06-30 21:56 ` Jacob Keller
2025-06-30 23:16 ` Jacob Keller
2025-07-01 6:48 ` Jaroslav Pulchart
2025-07-01 20:48 ` Jacob Keller
2025-07-02 9:48 ` Jaroslav Pulchart
2025-07-02 18:01 ` Jacob Keller
2025-07-02 21:56 ` Jacob Keller
2025-07-03 6:46 ` Jaroslav Pulchart
2025-07-03 16:16 ` Jacob Keller
2025-07-04 19:30 ` Maciej Fijalkowski
2025-07-07 18:32 ` Jacob Keller
2025-07-07 22:03 ` Jacob Keller
2025-07-09 0:50 ` Jacob Keller
2025-07-09 19:11 ` Jacob Keller
2025-07-09 21:04 ` Jaroslav Pulchart
2025-07-09 21:15 ` Jacob Keller
2025-07-11 18:16 ` Jaroslav Pulchart
2025-07-11 22:30 ` Jacob Keller
2025-07-14 5:34 ` Jaroslav Pulchart
2025-06-25 14:53 ` Paul Menzel
2025-07-04 16:55 ` Michal Kubiak
2025-07-05 7:01 ` Jaroslav Pulchart
2025-07-07 15:37 ` Jaroslav Pulchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415175359.3c6117c9@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=daniel.secik@gooddata.com \
--cc=edumazet@google.com \
--cc=igor@gooddata.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jaroslav.pulchart@gooddata.com \
--cc=jdamato@fastly.com \
--cc=lukasz.czapnik@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=zdenek.pesek@gooddata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.