From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org, sergei.shtylyov@gmail.com,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH v2 00/11] usb: xhci: decouple allocation and initialization
Date: Wed, 16 Apr 2025 16:44:59 +0300 [thread overview]
Message-ID: <20250416134510.2406543-1-niklas.neronin@linux.intel.com> (raw)
Currently, after hibernation (S4 state), the xhci driver frees all its
memory and reallocates it from scratch, which is inefficient. Instead, much
of the memory can be simply re-initialized.
The proposed changes begin the process by decoupling initialization code
from memory allocation code. Specifically, the initialization code is moved
from xhci_mem_init() into separate functions, which are then called from
xhci_init().
By implementing these changes, future patches will be able to call the
initialization functions directly after hibernation, thereby improving
efficiency and enhancing code structure.
v2:
* Add "Array" to "Set Device Context Base Address pointer" comment.
* Rebase on top of the recently accepted sideband series to resolve some
conflicts. The rebase impacts commits 8 and 9.
There will be duplicate code in xhci_create_secondary_interrupter().
Since I have another patch set pending that slightly impacts this
function, I have decided to hold off on reworking or cleaning up the
function.
Niklas Neronin (11):
usb: xhci: relocate pre-allocation initialization
usb: xhci: move device slot enabling register write
usb: xhci: move command ring pointer write
usb: xhci: refactor xhci_set_cmd_ring_deq()
usb: xhci: move DCBAA pointer write
usb: xhci: move doorbell array pointer assignment
usb: xhci: move enabling of USB 3 device notifications
usb: xhci: remove error handling from xhci_add_interrupter()
usb: xhci: move initialization of the primary interrupter
usb: xhci: add individual allocation checks in xhci_mem_init()
usb: xhci: cleanup xhci_mem_init()
drivers/usb/host/xhci-caps.h | 4 +-
drivers/usb/host/xhci-mem.c | 168 ++++++++++-------------------------
drivers/usb/host/xhci.c | 126 +++++++++++++++++++++-----
drivers/usb/host/xhci.h | 12 +--
4 files changed, 159 insertions(+), 151 deletions(-)
--
2.47.2
next reply other threads:[~2025-04-16 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 13:44 Niklas Neronin [this message]
2025-04-16 13:45 ` [PATCH v2 01/11] usb: xhci: relocate pre-allocation initialization Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 02/11] usb: xhci: move device slot enabling register write Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 03/11] usb: xhci: move command ring pointer write Niklas Neronin
2025-04-20 17:30 ` Sergey Shtylyov
2025-04-16 13:45 ` [PATCH v2 04/11] usb: xhci: refactor xhci_set_cmd_ring_deq() Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 05/11] usb: xhci: move DCBAA pointer write Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 06/11] usb: xhci: move doorbell array pointer assignment Niklas Neronin
2025-04-20 17:16 ` Sergey Shtylyov
2025-04-16 13:45 ` [PATCH v2 07/11] usb: xhci: move enabling of USB 3 device notifications Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 08/11] usb: xhci: remove error handling from xhci_add_interrupter() Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 09/11] usb: xhci: move initialization of the primary interrupter Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 10/11] usb: xhci: add individual allocation checks in xhci_mem_init() Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 11/11] usb: xhci: cleanup xhci_mem_init() Niklas Neronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416134510.2406543-1-niklas.neronin@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.