From: Niklas Neronin <niklas.neronin@linux.intel.com>
To: mathias.nyman@linux.intel.com
Cc: linux-usb@vger.kernel.org, sergei.shtylyov@gmail.com,
Niklas Neronin <niklas.neronin@linux.intel.com>
Subject: [PATCH v2 05/11] usb: xhci: move DCBAA pointer write
Date: Wed, 16 Apr 2025 16:45:04 +0300 [thread overview]
Message-ID: <20250416134510.2406543-6-niklas.neronin@linux.intel.com> (raw)
In-Reply-To: <20250416134510.2406543-1-niklas.neronin@linux.intel.com>
Move the Device Context Base Address Array (DCBAA) pointer write from
xhci_mem_init() to xhci_init(). This is part of the ongoing effort to
separate allocation and initialization.
Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
---
v2:
* Add "Array" to "Set Device Context Base Address pointer" comment.
drivers/usb/host/xhci-mem.c | 1 -
drivers/usb/host/xhci.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 46156e99bbbe..19f756a57cb7 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2400,7 +2400,6 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
xhci_dbg_trace(xhci, trace_xhci_dbg_init,
"// Device context base array address = 0x%pad (DMA), %p (virt)",
&xhci->dcbaa->dma, xhci->dcbaa);
- xhci_write_64(xhci, dma, &xhci->op_regs->dcbaa_ptr);
/*
* Initialize the ring segment pool. The ring must be a contiguous
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index d4f3da2c074b..ef93c1ae5215 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -545,6 +545,9 @@ static int xhci_init(struct usb_hcd *hcd)
/* Set the address in the Command Ring Control register */
xhci_set_cmd_ring_deq(xhci);
+ /* Set Device Context Base Address Array pointer */
+ xhci_write_64(xhci, xhci->dcbaa->dma, &xhci->op_regs->dcbaa_ptr);
+
/* Initializing Compliance Mode Recovery Data If Needed */
if (xhci_compliance_mode_recovery_timer_quirk_check()) {
xhci->quirks |= XHCI_COMP_MODE_QUIRK;
--
2.47.2
next prev parent reply other threads:[~2025-04-16 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 13:44 [PATCH v2 00/11] usb: xhci: decouple allocation and initialization Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 01/11] usb: xhci: relocate pre-allocation initialization Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 02/11] usb: xhci: move device slot enabling register write Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 03/11] usb: xhci: move command ring pointer write Niklas Neronin
2025-04-20 17:30 ` Sergey Shtylyov
2025-04-16 13:45 ` [PATCH v2 04/11] usb: xhci: refactor xhci_set_cmd_ring_deq() Niklas Neronin
2025-04-16 13:45 ` Niklas Neronin [this message]
2025-04-16 13:45 ` [PATCH v2 06/11] usb: xhci: move doorbell array pointer assignment Niklas Neronin
2025-04-20 17:16 ` Sergey Shtylyov
2025-04-16 13:45 ` [PATCH v2 07/11] usb: xhci: move enabling of USB 3 device notifications Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 08/11] usb: xhci: remove error handling from xhci_add_interrupter() Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 09/11] usb: xhci: move initialization of the primary interrupter Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 10/11] usb: xhci: add individual allocation checks in xhci_mem_init() Niklas Neronin
2025-04-16 13:45 ` [PATCH v2 11/11] usb: xhci: cleanup xhci_mem_init() Niklas Neronin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416134510.2406543-6-niklas.neronin@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.