From: Christoph Hellwig <hch@lst.de>
To: Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs
Date: Wed, 7 May 2025 09:48:17 +0200 [thread overview]
Message-ID: <20250507074817.GA4516@lst.de> (raw)
In-Reply-To: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org>
On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote:
> On 5/5/25 17:25, Christoph Hellwig wrote:
> > Hi all,
> >
> > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs.
> >
> > f2fs_sync_node_pages can still return it in a way that is not handled
> > by any caller and eventually is propagated to userspace. This does look
> > like a bug and needs attention by someone who actually knows the code.
>
> Oh, I guess this is a bug, thanks for catching this.
>
> Anyway, let me fix this based on your patchset.
I'll resend a fixed version later today, maybe wait for that.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Chao Yu <chao@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs
Date: Wed, 7 May 2025 09:48:17 +0200 [thread overview]
Message-ID: <20250507074817.GA4516@lst.de> (raw)
In-Reply-To: <43d55ab4-c490-4f3d-8331-dc47f427d06d@kernel.org>
On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote:
> On 5/5/25 17:25, Christoph Hellwig wrote:
> > Hi all,
> >
> > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs.
> >
> > f2fs_sync_node_pages can still return it in a way that is not handled
> > by any caller and eventually is propagated to userspace. This does look
> > like a bug and needs attention by someone who actually knows the code.
>
> Oh, I guess this is a bug, thanks for catching this.
>
> Anyway, let me fix this based on your patchset.
I'll resend a fixed version later today, maybe wait for that.
next prev parent reply other threads:[~2025-05-07 7:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 9:25 [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs Christoph Hellwig
2025-05-05 9:25 ` Christoph Hellwig
2025-05-05 9:25 ` [f2fs-dev] [PATCH 1/4] f2fs: return bool from __f2fs_write_meta_folio Christoph Hellwig
2025-05-05 9:25 ` Christoph Hellwig
2025-05-07 6:22 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 6:22 ` Chao Yu
2025-05-08 16:30 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-05-08 16:30 ` patchwork-bot+f2fs
2025-05-05 9:25 ` [f2fs-dev] [PATCH 2/4] f2fs: don't return AOP_WRITEPAGE_ACTIVATE from f2fs_write_single_data_page Christoph Hellwig
2025-05-05 9:25 ` Christoph Hellwig
2025-05-07 6:28 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 6:28 ` Chao Yu
2025-05-07 6:44 ` [f2fs-dev] " Christoph Hellwig
2025-05-07 6:44 ` Christoph Hellwig
2025-05-07 7:09 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 7:09 ` Chao Yu
2025-05-05 9:26 ` [f2fs-dev] [PATCH 3/4] f2fs: simplify return value handling in f2fs_fsync_node_pages Christoph Hellwig
2025-05-05 9:26 ` Christoph Hellwig
2025-05-07 7:19 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 7:19 ` Chao Yu
2025-05-05 9:26 ` [f2fs-dev] [PATCH 4/4] f2f2: return bool from __write_node_folio Christoph Hellwig
2025-05-05 9:26 ` Christoph Hellwig
2025-05-07 7:29 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 7:29 ` Chao Yu
2025-05-07 7:38 ` [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs Chao Yu via Linux-f2fs-devel
2025-05-07 7:38 ` Chao Yu
2025-05-07 7:48 ` Christoph Hellwig [this message]
2025-05-07 7:48 ` Christoph Hellwig
2025-05-07 8:13 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-05-07 8:13 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507074817.GA4516@lst.de \
--to=hch@lst.de \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.