All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Wunderlich <linux@fw-web.de>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Daniel Golle <daniel@makrotopia.org>,
	Qingfang Deng <dqfext@gmail.com>,
	SkyLake Huang <SkyLake.Huang@mediatek.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>
Cc: "Frank Wunderlich" <frank-w@public-files.de>,
	"Arınç ÜNAL" <arinc.unal@arinc9.com>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Felix Fietkau" <nbd@nbd.name>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [net-next, PATCH v2] net: phy: mediatek: do not require syscon compatible for pio property
Date: Fri, 16 May 2025 20:01:32 +0200	[thread overview]
Message-ID: <20250516180147.10416-3-linux@fw-web.de> (raw)
In-Reply-To: <20250516180147.10416-1-linux@fw-web.de>

From: Frank Wunderlich <frank-w@public-files.de>

Current implementation requires syscon compatible for pio property
which is used for driving the switch leds on mt7988.

Replace syscon_regmap_lookup_by_phandle with of_parse_phandle and
device_node_to_regmap to get the regmap already assigned by pinctrl
driver.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---

v2:
- out of RFC

---
 drivers/net/phy/mediatek/mtk-ge-soc.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c
index 175cf5239bba..21975ef946d5 100644
--- a/drivers/net/phy/mediatek/mtk-ge-soc.c
+++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
@@ -7,6 +7,7 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/phy.h>
 #include <linux/regmap.h>
+#include <linux/of.h>
 
 #include "../phylib.h"
 #include "mtk.h"
@@ -1319,6 +1320,7 @@ static int mt7988_phy_probe_shared(struct phy_device *phydev)
 {
 	struct device_node *np = dev_of_node(&phydev->mdio.bus->dev);
 	struct mtk_socphy_shared *shared = phy_package_get_priv(phydev);
+	struct device_node *pio_np;
 	struct regmap *regmap;
 	u32 reg;
 	int ret;
@@ -1336,7 +1338,13 @@ static int mt7988_phy_probe_shared(struct phy_device *phydev)
 	 * The 4 bits in TPBANK0 are kept as package shared data and are used to
 	 * set LED polarity for each of the LED0.
 	 */
-	regmap = syscon_regmap_lookup_by_phandle(np, "mediatek,pio");
+	pio_np = of_parse_phandle(np, "mediatek,pio", 0);
+	if (!pio_np)
+		return -ENODEV;
+
+	regmap = device_node_to_regmap(pio_np);
+	of_node_put(pio_np);
+
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);
 
-- 
2.43.0



WARNING: multiple messages have this Message-ID (diff)
From: Frank Wunderlich <linux@fw-web.de>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Daniel Golle <daniel@makrotopia.org>,
	Qingfang Deng <dqfext@gmail.com>,
	SkyLake Huang <SkyLake.Huang@mediatek.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>
Cc: devicetree@vger.kernel.org,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"Arınç ÜNAL" <arinc.unal@arinc9.com>,
	netdev@vger.kernel.org, "Sean Wang" <sean.wang@mediatek.com>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Felix Fietkau" <nbd@nbd.name>
Subject: [net-next, PATCH v2] net: phy: mediatek: do not require syscon compatible for pio property
Date: Fri, 16 May 2025 20:01:32 +0200	[thread overview]
Message-ID: <20250516180147.10416-3-linux@fw-web.de> (raw)
In-Reply-To: <20250516180147.10416-1-linux@fw-web.de>

From: Frank Wunderlich <frank-w@public-files.de>

Current implementation requires syscon compatible for pio property
which is used for driving the switch leds on mt7988.

Replace syscon_regmap_lookup_by_phandle with of_parse_phandle and
device_node_to_regmap to get the regmap already assigned by pinctrl
driver.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---

v2:
- out of RFC

---
 drivers/net/phy/mediatek/mtk-ge-soc.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c
index 175cf5239bba..21975ef946d5 100644
--- a/drivers/net/phy/mediatek/mtk-ge-soc.c
+++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
@@ -7,6 +7,7 @@
 #include <linux/pinctrl/consumer.h>
 #include <linux/phy.h>
 #include <linux/regmap.h>
+#include <linux/of.h>
 
 #include "../phylib.h"
 #include "mtk.h"
@@ -1319,6 +1320,7 @@ static int mt7988_phy_probe_shared(struct phy_device *phydev)
 {
 	struct device_node *np = dev_of_node(&phydev->mdio.bus->dev);
 	struct mtk_socphy_shared *shared = phy_package_get_priv(phydev);
+	struct device_node *pio_np;
 	struct regmap *regmap;
 	u32 reg;
 	int ret;
@@ -1336,7 +1338,13 @@ static int mt7988_phy_probe_shared(struct phy_device *phydev)
 	 * The 4 bits in TPBANK0 are kept as package shared data and are used to
 	 * set LED polarity for each of the LED0.
 	 */
-	regmap = syscon_regmap_lookup_by_phandle(np, "mediatek,pio");
+	pio_np = of_parse_phandle(np, "mediatek,pio", 0);
+	if (!pio_np)
+		return -ENODEV;
+
+	regmap = device_node_to_regmap(pio_np);
+	of_node_put(pio_np);
+
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);
 
-- 
2.43.0



  parent reply	other threads:[~2025-05-16 18:04 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 18:01 [PATCH v2 00/14] further mt7988 devicetree work Frank Wunderlich
2025-05-16 18:01 ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 01/14] dt-bindings: net: mediatek,net: update for mt7988 Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-27 19:28   ` Rob Herring (Arm)
2025-05-27 19:28     ` Rob Herring (Arm)
2025-05-16 18:01 ` Frank Wunderlich [this message]
2025-05-16 18:01   ` [net-next, PATCH v2] net: phy: mediatek: do not require syscon compatible for pio property Frank Wunderlich
2025-05-16 18:08   ` Frank Wunderlich
2025-05-16 23:31     ` Jakub Kicinski
2025-05-16 18:01 ` [PATCH v2 02/14] dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for mt7988 Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 03/14] dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-27 19:29   ` Rob Herring (Arm)
2025-05-27 19:29     ` Rob Herring (Arm)
2025-05-16 18:01 ` [PATCH v2 04/14] arm64: dts: mediatek: mt7988: add spi controllers Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 05/14] arm64: dts: mediatek: mt7988: move uart0 and spi1 pins to soc dtsi Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 06/14] arm64: dts: mediatek: mt7988: add cci node Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-20 11:27   ` AngeloGioacchino Del Regno
2025-05-20 11:27     ` AngeloGioacchino Del Regno
2025-05-20 11:53     ` Frank Wunderlich
2025-05-20 11:53       ` Frank Wunderlich
2025-05-20 11:55       ` AngeloGioacchino Del Regno
2025-05-20 11:55         ` AngeloGioacchino Del Regno
2025-05-20 17:08     ` Frank Wunderlich (linux)
2025-05-20 17:08       ` Frank Wunderlich (linux)
2025-05-16 18:01 ` [PATCH v2 07/14] arm64: dts: mediatek: mt7988: add phy calibration efuse subnodes Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 08/14] arm64: dts: mediatek: mt7988: add basic ethernet-nodes Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 09/14] arm64: dts: mediatek: mt7988: add switch node Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 10/14] arm64: dts: mediatek: mt7988a-bpi-r4: Add fan and coolingmaps Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 11/14] arm64: dts: mediatek: mt7988a-bpi-r4: configure spi-nodes Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 12/14] arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 13/14] arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-16 18:01 ` [PATCH v2 14/14] arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds Frank Wunderlich
2025-05-16 18:01   ` Frank Wunderlich
2025-05-20 10:17 ` (subset) [PATCH v2 00/14] further mt7988 devicetree work AngeloGioacchino Del Regno
2025-05-20 10:17   ` AngeloGioacchino Del Regno
  -- strict thread matches above, loose matches on Subject: below --
2025-05-10 17:49 [net-next, PATCH v2] net: phy: mediatek: do not require syscon compatible for pio property Frank Wunderlich
2025-05-10 17:49 ` Frank Wunderlich
2025-05-16 22:50 ` patchwork-bot+netdevbpf
2025-05-16 22:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250516180147.10416-3-linux@fw-web.de \
    --to=linux@fw-web.de \
    --cc=Landen.Chao@mediatek.com \
    --cc=SkyLake.Huang@mediatek.com \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arinc.unal@arinc9.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dqfext@gmail.com \
    --cc=edumazet@google.com \
    --cc=frank-w@public-files.de \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.