Re: [Intel-wired-lan] [PATCH] ixgbe: Fix typos and clarify comments in X550 driver code

[Simon Horman <horms@kernel.org>]

On Thu, May 22, 2025 at 12:47:26AM -0700, Alok Tiwari wrote:
> Corrected spelling errors such as "simular" -> "similar",
> "excepted" -> "accepted", and "Determime" -> "Determine".
> Fixed including incorrect word usage ("to MAC" -> "two MAC")
> and improved awkward phrasing.
> 
> Aligned function header descriptions with their actual functionality
> (e.g., "Writes a value" -> "Reads a value").
> Corrected typo in error code from -ENIVAL to -EINVAL.
> Improved overall clarity and consistency in comment across various
> functions.
> 
> These changes improve maintainability and readability of the code
> without affecting functionality.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 28 +++++++++----------

...

> @@ -1754,7 +1754,7 @@ ixgbe_setup_mac_link_sfp_n(struct ixgbe_hw *hw, ixgbe_link_speed speed,
>  	ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear);
>  
>  	/* If no SFP module present, then return success. Return success since
> -	 * SFP not present error is not excepted in the setup MAC link flow.
> +	 * SFP not present error is not accepted in the setup MAC link flow.

I wonder if "excepted" was supposed to be "expected".

>  	 */
>  	if (ret_val == -ENOENT)
>  		return 0;
> @@ -1804,7 +1804,7 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed,
>  	ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear);
>  
>  	/* If no SFP module present, then return success. Return success since
> -	 * SFP not present error is not excepted in the setup MAC link flow.
> +	 * SFP not present error is not accepted in the setup MAC link flow.

Ditto.

>  	 */
>  	if (ret_val == -ENOENT)
>  		return 0;

The above notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>