All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Jeff Johnson <jjohnson@kernel.org>
Cc: Miaoqing Pan <quic_miaoqing@quicinc.com>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 2/3] wifi: ath11k: use plain access for descriptor length
Date: Mon, 26 May 2025 13:48:02 +0200	[thread overview]
Message-ID: <20250526114803.2122-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20250526114803.2122-1-johan+linaro@kernel.org>

The read memory barrier added by commit 6d037a372f81 ("wifi: ath11k: fix
ring-buffer corruption") is enough to guarantee ordering also for plain
descriptor accesses if the length helper is ever inlined so drop the
unnecessary READ_ONCE().

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/net/wireless/ath/ath11k/hal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c
index 8cb1505a5a0c..1ea7c494f387 100644
--- a/drivers/net/wireless/ath/ath11k/hal.c
+++ b/drivers/net/wireless/ath/ath11k/hal.c
@@ -599,7 +599,7 @@ u32 ath11k_hal_ce_dst_status_get_length(void *buf)
 	struct hal_ce_srng_dst_status_desc *desc = buf;
 	u32 len;
 
-	len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, READ_ONCE(desc->flags));
+	len = FIELD_GET(HAL_CE_DST_STATUS_DESC_FLAGS_LEN, desc->flags);
 	desc->flags &= ~HAL_CE_DST_STATUS_DESC_FLAGS_LEN;
 
 	return len;
-- 
2.49.0



  parent reply	other threads:[~2025-05-26 11:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 11:48 [PATCH 0/3] wifi: ath11k: fix dest ring-buffer corruption Johan Hovold
2025-05-26 11:48 ` [PATCH 1/3] " Johan Hovold
2025-05-29  7:03   ` Miaoqing Pan
2025-06-02  8:03     ` Johan Hovold
2025-06-03 10:52       ` Baochen Qiang
2025-06-03 11:51         ` Johan Hovold
2025-06-04  2:16           ` Baochen Qiang
2025-06-04  6:59             ` Johan Hovold
2025-06-05  8:16               ` Baochen Qiang
2025-06-04  2:34           ` Miaoqing Pan
2025-06-04  5:32             ` Miaoqing Pan
2025-06-04  7:06               ` Johan Hovold
2025-06-04  7:57                 ` Miaoqing Pan
2025-06-04  8:07                   ` Johan Hovold
2025-06-04  8:18                     ` Miaoqing Pan
2025-06-04 16:24             ` Jeff Johnson
2025-06-05  4:01               ` Miaoqing Pan
2025-06-05 10:17                 ` Johan Hovold
2025-06-05 10:54                   ` Baochen Qiang
2025-06-06  0:52                     ` Miaoqing Pan
2025-06-06  2:02                       ` Baochen Qiang
2025-06-06  7:43                         ` Miaoqing Pan
2025-06-25  2:06   ` Baochen Qiang
2025-06-25  9:34     ` Johan Hovold
2025-05-26 11:48 ` Johan Hovold [this message]
2025-05-26 11:48 ` [PATCH 3/3] wifi: ath11k: use plain accesses for monitor descriptor Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250526114803.2122-3-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_miaoqing@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.