All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Gladkov <legion@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Daniel Gomez <da.gomez@samsung.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas.schier@linux.dev>,
	Khalid Aziz <khalid@gonehiking.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kbuild@vger.kernel.org, linux-scsi@vger.kernel.org,
	Alexey Gladkov <legion@kernel.org>
Subject: [PATCH v4 1/6] scsi: Always define blogic_pci_tbl structure
Date: Tue, 27 May 2025 16:06:06 +0200	[thread overview]
Message-ID: <20250527140606.68526-1-legion@kernel.org> (raw)
In-Reply-To: <628e85f1b7e9d0423a8b83ac3150b3e151c9c4e3.1748335606.git.legion@kernel.org>

The blogic_pci_tbl structure is used by the MODULE_DEVICE_TABLE macro.
There is no longer a need to protect it with the MODULE condition, since
this no longer causes the compiler to warn about an unused variable.

Cc: Khalid Aziz <khalid@gonehiking.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
 drivers/scsi/BusLogic.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 1f100270cd38..08e12a3d6703 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -3715,7 +3715,6 @@ static void __exit blogic_exit(void)
 
 __setup("BusLogic=", blogic_setup);
 
-#ifdef MODULE
 /*static const struct pci_device_id blogic_pci_tbl[] = {
 	{ PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
@@ -3731,7 +3730,6 @@ static const struct pci_device_id blogic_pci_tbl[] = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_FLASHPOINT)},
 	{0, },
 };
-#endif
 MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);
 
 module_init(blogic_init);
-- 
2.49.0


  parent reply	other threads:[~2025-05-27 14:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  9:07 [PATCH v3 0/6] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-05-27  9:07 ` [PATCH v3 1/6] scsi: Define MODULE_DEVICE_TABLE only if necessary Alexey Gladkov
2025-05-27 11:28   ` James Bottomley
2025-05-27 11:54     ` Alexey Gladkov
2025-05-27 11:58       ` James Bottomley
2025-05-27 12:58         ` Alexey Gladkov
2025-05-27 14:06   ` Alexey Gladkov [this message]
2025-05-27  9:07 ` [PATCH v3 2/6] modules: Add macros to specify modinfo prefix Alexey Gladkov
2025-06-02  7:49   ` Masahiro Yamada
2025-06-09  9:37     ` Alexey Gladkov
2025-05-27  9:07 ` [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique Alexey Gladkov
2025-06-02  7:45   ` Masahiro Yamada
2025-06-02  8:06     ` Alexey Gladkov
2025-06-02 10:58       ` Masahiro Yamada
2025-06-02 14:03         ` Alexey Gladkov
2025-06-02 16:18           ` Masahiro Yamada
2025-06-02 17:09             ` Alexey Gladkov
2025-06-04 11:26             ` Alexey Gladkov
2025-06-06  5:10               ` Masahiro Yamada
2025-06-06 11:20                 ` Masahiro Yamada
2025-06-02  7:52   ` Masahiro Yamada
2025-06-02  8:24     ` Alexey Gladkov
2025-06-02 18:00       ` Masahiro Yamada
2025-06-02 18:44         ` Alexey Gladkov
2025-06-06  5:12           ` Masahiro Yamada
2025-05-27  9:07 ` [PATCH v3 4/6] modpost: Create modalias for builtin modules Alexey Gladkov
2025-05-27  9:07 ` [PATCH v3 5/6] kbuild: Move modules.builtin.modinfo to another makefile Alexey Gladkov
2025-05-28 13:21   ` kernel test robot
2025-05-28 15:20     ` Alexey Gladkov
2025-05-27  9:08 ` [PATCH v3 6/6] kbuild: Create modules.builtin.modinfo for modpost results Alexey Gladkov
2025-05-27 13:15 ` [PATCH v3 7/6] scsi: Always define MODULE_DEVICE_TABLE Alexey Gladkov
2025-05-27 13:22   ` James Bottomley
2025-05-27 13:44     ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250527140606.68526-1-legion@kernel.org \
    --to=legion@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=da.gomez@samsung.com \
    --cc=khalid@gonehiking.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.