From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix __write_node_folio() conversion
Date: Mon, 2 Jun 2025 07:00:30 +0200 [thread overview]
Message-ID: <20250602050030.GA21716@lst.de> (raw)
In-Reply-To: <20250601002709.4094344-1-willy@infradead.org>
On Sun, Jun 01, 2025 at 01:26:54AM +0100, Matthew Wilcox (Oracle) wrote:
> This conversion moved the folio_unlock() to inside __write_node_folio(),
> but missed one caller so we had a double-unlock on this path.
Looks good, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Chao Yu <chao@kernel.org>, Jaegeuk Kim <jaegeuk@kernel.org>,
syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com
Subject: Re: [PATCH] f2fs: Fix __write_node_folio() conversion
Date: Mon, 2 Jun 2025 07:00:30 +0200 [thread overview]
Message-ID: <20250602050030.GA21716@lst.de> (raw)
In-Reply-To: <20250601002709.4094344-1-willy@infradead.org>
On Sun, Jun 01, 2025 at 01:26:54AM +0100, Matthew Wilcox (Oracle) wrote:
> This conversion moved the folio_unlock() to inside __write_node_folio(),
> but missed one caller so we had a double-unlock on this path.
Looks good, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-06-02 5:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-01 0:26 [f2fs-dev] [PATCH] f2fs: Fix __write_node_folio() conversion Matthew Wilcox (Oracle)
2025-06-01 0:26 ` Matthew Wilcox (Oracle)
2025-06-02 5:00 ` Christoph Hellwig [this message]
2025-06-02 5:00 ` Christoph Hellwig
2025-06-03 6:31 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-06-03 6:31 ` Chao Yu
2025-06-18 21:40 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-06-18 21:40 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602050030.GA21716@lst.de \
--to=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=syzbot+c0dc46208750f063d0e0@syzkaller.appspotmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.