From: Jakub Kicinski <kuba@kernel.org>
To: Ian Ray <ian.ray@gehealthcare.com>
Cc: horms@kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
brian.ruley@gehealthcare.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH v2] igb: Fix watchdog_task race with shutdown
Date: Thu, 5 Jun 2025 18:43:39 -0700 [thread overview]
Message-ID: <20250605184339.7a4e0f96@kernel.org> (raw)
In-Reply-To: <20250603080949.1681-1-ian.ray@gehealthcare.com>
On Tue, 3 Jun 2025 11:09:49 +0300 Ian Ray wrote:
> set_bit(__IGB_DOWN, &adapter->state);
> + timer_delete_sync(&adapter->watchdog_timer);
> + timer_delete_sync(&adapter->phy_info_timer);
> +
> + cancel_work_sync(&adapter->watchdog_task);
This doesn't look very race-proof as watchdog_task
can schedule the timer as its last operation?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ian Ray <ian.ray@gehealthcare.com>
Cc: horms@kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
brian.ruley@gehealthcare.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] igb: Fix watchdog_task race with shutdown
Date: Thu, 5 Jun 2025 18:43:39 -0700 [thread overview]
Message-ID: <20250605184339.7a4e0f96@kernel.org> (raw)
In-Reply-To: <20250603080949.1681-1-ian.ray@gehealthcare.com>
On Tue, 3 Jun 2025 11:09:49 +0300 Ian Ray wrote:
> set_bit(__IGB_DOWN, &adapter->state);
> + timer_delete_sync(&adapter->watchdog_timer);
> + timer_delete_sync(&adapter->phy_info_timer);
> +
> + cancel_work_sync(&adapter->watchdog_task);
This doesn't look very race-proof as watchdog_task
can schedule the timer as its last operation?
next prev parent reply other threads:[~2025-06-06 1:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 8:09 [Intel-wired-lan] [PATCH v2] igb: Fix watchdog_task race with shutdown Ian Ray
2025-06-03 8:09 ` Ian Ray
2025-06-06 1:43 ` Jakub Kicinski [this message]
2025-06-06 1:43 ` Jakub Kicinski
2025-06-09 6:32 ` [Intel-wired-lan] " Ian Ray
2025-06-09 6:32 ` Ian Ray
2025-06-09 23:10 ` [Intel-wired-lan] " Jakub Kicinski
2025-06-09 23:10 ` Jakub Kicinski
2025-06-10 12:44 ` [Intel-wired-lan] " Ian Ray
2025-06-10 12:44 ` Ian Ray
2025-06-16 21:47 ` [Intel-wired-lan] " Jacob Keller
2025-06-27 13:28 ` Ian Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605184339.7a4e0f96@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=brian.ruley@gehealthcare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ian.ray@gehealthcare.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.