* [PATCH v2] dt-bindings: arm: qcom: document r0q board binding
@ 2025-06-15 20:56 Eric Gonçalves
2025-06-15 20:56 ` [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22 Eric Gonçalves
2025-06-16 6:18 ` [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Eric Gonçalves @ 2025-06-15 20:56 UTC (permalink / raw)
To: linux-arm-msm; +Cc: devicetree, konradybcio, robh, Eric Gonçalves
Adds compatible for the Samsung Galaxy S22 (SM-S901E) (r0q), based on the Snapdragon 8 Gen 1 SoC.
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index b14206d11f8b..7ed1da6e42ed 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1092,6 +1092,7 @@ properties:
- qcom,sm8450-qrd
- sony,pdx223
- sony,pdx224
+ - samsung,r0q
- const: qcom,sm8450
- items:
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
2025-06-15 20:56 [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Eric Gonçalves
@ 2025-06-15 20:56 ` Eric Gonçalves
2025-06-16 6:18 ` Krzysztof Kozlowski
2025-06-16 6:18 ` [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Eric Gonçalves @ 2025-06-15 20:56 UTC (permalink / raw)
To: linux-arm-msm; +Cc: devicetree, konradybcio, robh, Eric Gonçalves
Adds new device support for the Samsung Galaxy S22 (SM-S901E) phone
Working features:
- simple-framebuffer
- side buttons
- storage
- usb
Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sm8450-samsung-r0q.dts | 365 ++++++++++++++++++
2 files changed, 366 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 669b888b27a1..cde80a17f2ab 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -287,6 +287,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
new file mode 100644
index 000000000000..cb58626e879e
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
@@ -0,0 +1,365 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2025, Eric Gonçalves <ghatto404@gmail.com>
+ * Copyright (c) 2025, Arthur Aligon <arthurus36.alt2@tutanota.com>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+#include "sm8450.dtsi"
+#include "pm8350.dtsi"
+#include "pm8350b.dtsi"
+#include "pm8350c.dtsi"
+#include "pm8450.dtsi"
+#include "pmk8350.dtsi"
+#include "pmr735a.dtsi"
+
+/delete-node/ &xbl_ramdump_mem;
+/delete-node/ &xbl_sc_mem;
+/delete-node/ &adsp_mem;
+/delete-node/ &rmtfs_mem;
+/delete-node/ &mte_mem;
+/delete-node/ &trusted_apps_mem;
+/delete-node/ &trusted_apps_ext_mem;
+
+/ {
+ chassis-type = "handset";
+ model = "Samsung Galaxy S22 (SM-S901E)";
+ compatible = "samsung,r0q", "qcom,sm8450";
+
+ chosen {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ bootargs = "clk_ignore_unused pd_ignore_unused";
+ linux,initrd-start = <0x00 0xb6915000>;
+ linux,initrd-end = <0x00 0xb7fff22c>;
+ stdout-path = "serial0:115200n8";
+
+ framebuffer: framebuffer@b8000000 {
+ compatible = "simple-framebuffer";
+ reg = <0x0 0xb8000000 0x0 0x2b00000>;
+ width = <1080>;
+ height = <2340>;
+ stride = <(1080 * 4)>;
+ format = "a8r8g8b8";
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ autorepeat;
+
+ pinctrl-0 = <&vol_up_n>;
+ pinctrl-names = "default";
+
+ key-vol-up {
+ label = "Volume Up";
+ linux,code = <KEY_VOLUMEUP>;
+ gpios = <&pm8350_gpios 6 GPIO_ACTIVE_LOW>;
+ debounce-interval = <15>;
+ };
+ };
+
+ memory {
+ ddr_device_type = <0x08>;
+ device_type = "memory";
+ reg = <0x00 0x80000000 0x00 0x6a000000 0x00 0xf1c00000 0x00 0xe400000 0x08 0x00 0x00 0x3ab00000 0x08 0x40000000 0x01 0x40000000 0x08 0x3b100000 0x00 0x1e00000>;
+ };
+
+ reserved-memory {
+ xbl_ramdump_mem: memory@a6b80000 {
+ reg = <0x0 0xa7d00000 0x0 0x300000>;
+ no-map;
+ };
+
+ xbl_sc_mem: memory@a6e00000 {
+ reg = <0x0 0xa6e00000 0x0 0x40000>;
+ no-map;
+ };
+
+ adsp_mem: memory@9fd00000 {
+ reg = <0x0 0x84500000 0x0 0x3b00000>;
+ no-map;
+ };
+
+ rmtfs_mem: memory@fe200000 {
+ compatible = "qcom,rmtfs-mem";
+ reg = <0x0 0xfe200000 0x0 0x280000>;
+ reg-names = "rmtfs";
+ qcom,client-id = <1>;
+ no-map;
+
+ qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
+ };
+
+ splash_region@b8000000 {
+ reg = <0x0 0xb8000000 0x0 0x2b00000>;
+ no-map;
+ };
+ };
+
+ vph_pwr: vph-pwr-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-min-microvolt = <3700000>;
+ regulator-max-microvolt = <3700000>;
+
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&tlmm {
+ gpio-reserved-ranges = <36 4>, <50 1>, <93 1>;
+
+ dsi_default: dsi-default-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ dsi_suspend: dsi-suspend-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
+
+&apps_rsc {
+ regulators-0 {
+ compatible = "qcom,pm8350-rpmh-regulators";
+ qcom,pmic-id = "b";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+ vdd-s4-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s6-supply = <&vph_pwr>;
+ vdd-s7-supply = <&vph_pwr>;
+ vdd-s8-supply = <&vph_pwr>;
+ vdd-s9-supply = <&vph_pwr>;
+ vdd-s10-supply = <&vph_pwr>;
+ vdd-s11-supply = <&vph_pwr>;
+ vdd-s12-supply = <&vph_pwr>;
+
+ vdd-l1-l4-supply = <&vreg_s11b_0p95>;
+ vdd-l2-l7-supply = <&vreg_bob>;
+ vdd-l3-l5-supply = <&vreg_bob>;
+ vdd-l6-l9-l10-supply = <&vreg_s12b_1p25>;
+ vdd-l8-supply = <&vreg_s2h_0p95>;
+
+ vreg_s11b_0p95: smps11 {
+ regulator-name = "vreg_s11b_0p95";
+ regulator-min-microvolt = <848000>;
+ regulator-max-microvolt = <1104000>;
+ };
+
+ vreg_s12b_1p25: smps12 {
+ regulator-name = "vreg_s12b_1p25";
+ regulator-min-microvolt = <1224000>;
+ regulator-max-microvolt = <1400000>;
+ };
+
+ vreg_l1b_0p91: ldo1 {
+ regulator-name = "vreg_l1b_0p91";
+ regulator-min-microvolt = <912000>;
+ regulator-max-microvolt = <920000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2b_3p07: ldo2 {
+ regulator-name = "vreg_l2b_3p07";
+ regulator-min-microvolt = <3072000>;
+ regulator-max-microvolt = <3072000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l5b_0p88: ldo5 {
+ regulator-name = "vreg_l5b_0p88";
+ regulator-min-microvolt = <880000>;
+ regulator-max-microvolt = <888000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l6b_1p2: ldo6 {
+ regulator-name = "vreg_l6b_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7b_2p5: ldo7 {
+ regulator-name = "vreg_l7b_2p5";
+ regulator-min-microvolt = <2504000>;
+ regulator-max-microvolt = <2504000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l9b_1p2: ldo9 {
+ regulator-name = "vreg_l9b_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-1 {
+ compatible = "qcom,pm8350c-rpmh-regulators";
+ qcom,pmic-id = "c";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+ vdd-s4-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s6-supply = <&vph_pwr>;
+ vdd-s7-supply = <&vph_pwr>;
+ vdd-s8-supply = <&vph_pwr>;
+ vdd-s9-supply = <&vph_pwr>;
+ vdd-s10-supply = <&vph_pwr>;
+
+ vdd-l1-l12-supply = <&vreg_bob>;
+ vdd-l2-l8-supply = <&vreg_bob>;
+ vdd-l3-l4-l5-l7-l13-supply = <&vreg_bob>;
+ vdd-l6-l9-l11-supply = <&vreg_bob>;
+
+ vdd-bob-supply = <&vph_pwr>;
+
+ vreg_s1c_1p86: smps1 {
+ regulator-name = "vreg_s1c_1p86";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <2024000>;
+ };
+
+ vreg_bob: bob {
+ regulator-name = "vreg_bob";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3960000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
+ };
+
+ vreg_l1c_1p8: ldo1 {
+ regulator-name = "vreg_l1c_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-2 {
+ compatible = "qcom,pm8450-rpmh-regulators";
+ qcom,pmic-id = "h";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+ vdd-s4-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s6-supply = <&vph_pwr>;
+
+ vdd-l2-supply = <&vreg_bob>;
+ vdd-l3-supply = <&vreg_bob>;
+ vdd-l4-supply = <&vreg_bob>;
+
+ vreg_s2h_0p95: smps2 {
+ regulator-name = "vreg_s2h_0p95";
+ regulator-min-microvolt = <848000>;
+ regulator-max-microvolt = <1104000>;
+ };
+ };
+
+ regulators-3 {
+ compatible = "qcom,pmr735a-rpmh-regulators";
+ qcom,pmic-id = "e";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s3-supply = <&vph_pwr>;
+
+ vdd-l1-l2-supply = <&vreg_s2e_0p85>;
+ vdd-l3-supply = <&vreg_s1e_1p25>;
+ vdd-l4-supply = <&vreg_s1c_1p86>;
+ vdd-l5-l6-supply = <&vreg_s1c_1p86>;
+ vdd-l7-bob-supply = <&vreg_bob>;
+
+ vreg_s1e_1p25: smps1 {
+ regulator-name = "vreg_s1e_1p25";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1296000>;
+ };
+
+ vreg_s2e_0p85: smps2 {
+ regulator-name = "vreg_s2e_0p85";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1040000>;
+ };
+ };
+};
+
+&pm8350_gpios {
+ vol_up_n: vol-up-n-state {
+ pins = "gpio6";
+ function = "normal";
+ power-source = <1>;
+ input-enable;
+ };
+};
+
+&pon_pwrkey {
+ status = "okay";
+};
+
+&pon_resin {
+ status = "okay";
+ linux,code = <KEY_VOLUMEDOWN>;
+};
+
+&usb_1 {
+ qcom,select-utmi-as-pipe-clk;
+ status = "okay";
+};
+
+&usb_1_dwc3 {
+ dr_mode = "peripheral";
+ maximum-speed = "high-speed";
+
+ phys = <&usb_1_hsphy>;
+ phy-names = "usb2-phy";
+};
+
+&usb_1_hsphy {
+ status = "okay";
+ vdda-pll-supply = <&vreg_l5b_0p88>;
+ vdda18-supply = <&vreg_l1c_1p8>;
+ vdda33-supply = <&vreg_l2b_3p07>;
+};
+
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
+
+ vcc-supply = <&vreg_l7b_2p5>;
+ vcc-max-microamp = <1100000>;
+ vccq-supply = <&vreg_l9b_1p2>;
+ vccq-max-microamp = <1200000>;
+ vccq2-supply = <&vreg_l9b_1p2>;
+ vccq2-max-microamp = <1200000>;
+ vdd-hba-supply = <&vreg_l9b_1p2>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ status = "okay";
+
+ vdda-phy-supply = <&vreg_l5b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
+};
--
2.49.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
@ 2025-06-16 4:25 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-06-16 4:25 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250615205608.1133129-2-ghatto404@gmail.com>
References: <20250615205608.1133129-2-ghatto404@gmail.com>
TO: "Eric Gonçalves" <ghatto404@gmail.com>
TO: linux-arm-msm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: konradybcio@kernel.org
CC: robh@kernel.org
CC: "Eric Gonçalves" <ghatto404@gmail.com>
Hi Eric,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.16-rc2 next-20250613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Gon-alves/arm64-dts-qcom-add-initial-tree-for-Samsung-Galaxy-S22/20250616-045847
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250615205608.1133129-2-ghatto404%40gmail.com
patch subject: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: arm64-randconfig-004-20250616 (https://download.01.org/0day-ci/archive/20250616/202506161130.j8LJjvNl-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250616/202506161130.j8LJjvNl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202506161130.j8LJjvNl-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts:69.9-73.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/sm8450.dtsi:3501.27-3574.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/qcom/sm8450.dtsi:3595.27-3649.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
vim +69 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
d366b02bf6a72c Eric Gonçalves 2025-06-15 28
d366b02bf6a72c Eric Gonçalves 2025-06-15 29 / {
d366b02bf6a72c Eric Gonçalves 2025-06-15 30 chassis-type = "handset";
d366b02bf6a72c Eric Gonçalves 2025-06-15 31 model = "Samsung Galaxy S22 (SM-S901E)";
d366b02bf6a72c Eric Gonçalves 2025-06-15 32 compatible = "samsung,r0q", "qcom,sm8450";
d366b02bf6a72c Eric Gonçalves 2025-06-15 33
d366b02bf6a72c Eric Gonçalves 2025-06-15 34 chosen {
d366b02bf6a72c Eric Gonçalves 2025-06-15 35 #address-cells = <2>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 36 #size-cells = <2>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 37 ranges;
d366b02bf6a72c Eric Gonçalves 2025-06-15 38
d366b02bf6a72c Eric Gonçalves 2025-06-15 39 bootargs = "clk_ignore_unused pd_ignore_unused";
d366b02bf6a72c Eric Gonçalves 2025-06-15 40 linux,initrd-start = <0x00 0xb6915000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 41 linux,initrd-end = <0x00 0xb7fff22c>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 42 stdout-path = "serial0:115200n8";
d366b02bf6a72c Eric Gonçalves 2025-06-15 43
d366b02bf6a72c Eric Gonçalves 2025-06-15 44 framebuffer: framebuffer@b8000000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 45 compatible = "simple-framebuffer";
d366b02bf6a72c Eric Gonçalves 2025-06-15 46 reg = <0x0 0xb8000000 0x0 0x2b00000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 47 width = <1080>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 48 height = <2340>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 49 stride = <(1080 * 4)>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 50 format = "a8r8g8b8";
d366b02bf6a72c Eric Gonçalves 2025-06-15 51 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 52 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 53
d366b02bf6a72c Eric Gonçalves 2025-06-15 54 gpio-keys {
d366b02bf6a72c Eric Gonçalves 2025-06-15 55 compatible = "gpio-keys";
d366b02bf6a72c Eric Gonçalves 2025-06-15 56 autorepeat;
d366b02bf6a72c Eric Gonçalves 2025-06-15 57
d366b02bf6a72c Eric Gonçalves 2025-06-15 58 pinctrl-0 = <&vol_up_n>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 59 pinctrl-names = "default";
d366b02bf6a72c Eric Gonçalves 2025-06-15 60
d366b02bf6a72c Eric Gonçalves 2025-06-15 61 key-vol-up {
d366b02bf6a72c Eric Gonçalves 2025-06-15 62 label = "Volume Up";
d366b02bf6a72c Eric Gonçalves 2025-06-15 63 linux,code = <KEY_VOLUMEUP>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 64 gpios = <&pm8350_gpios 6 GPIO_ACTIVE_LOW>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 65 debounce-interval = <15>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 66 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 67 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 68
d366b02bf6a72c Eric Gonçalves 2025-06-15 @69 memory {
d366b02bf6a72c Eric Gonçalves 2025-06-15 70 ddr_device_type = <0x08>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 71 device_type = "memory";
d366b02bf6a72c Eric Gonçalves 2025-06-15 72 reg = <0x00 0x80000000 0x00 0x6a000000 0x00 0xf1c00000 0x00 0xe400000 0x08 0x00 0x00 0x3ab00000 0x08 0x40000000 0x01 0x40000000 0x08 0x3b100000 0x00 0x1e00000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 73 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 74
d366b02bf6a72c Eric Gonçalves 2025-06-15 75 reserved-memory {
d366b02bf6a72c Eric Gonçalves 2025-06-15 76 xbl_ramdump_mem: memory@a6b80000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 77 reg = <0x0 0xa7d00000 0x0 0x300000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 78 no-map;
d366b02bf6a72c Eric Gonçalves 2025-06-15 79 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 80
d366b02bf6a72c Eric Gonçalves 2025-06-15 81 xbl_sc_mem: memory@a6e00000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 82 reg = <0x0 0xa6e00000 0x0 0x40000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 83 no-map;
d366b02bf6a72c Eric Gonçalves 2025-06-15 84 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 85
d366b02bf6a72c Eric Gonçalves 2025-06-15 86 adsp_mem: memory@9fd00000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 87 reg = <0x0 0x84500000 0x0 0x3b00000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 88 no-map;
d366b02bf6a72c Eric Gonçalves 2025-06-15 89 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 90
d366b02bf6a72c Eric Gonçalves 2025-06-15 91 rmtfs_mem: memory@fe200000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 92 compatible = "qcom,rmtfs-mem";
d366b02bf6a72c Eric Gonçalves 2025-06-15 93 reg = <0x0 0xfe200000 0x0 0x280000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 94 reg-names = "rmtfs";
d366b02bf6a72c Eric Gonçalves 2025-06-15 95 qcom,client-id = <1>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 96 no-map;
d366b02bf6a72c Eric Gonçalves 2025-06-15 97
d366b02bf6a72c Eric Gonçalves 2025-06-15 98 qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 99 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 100
d366b02bf6a72c Eric Gonçalves 2025-06-15 101 splash_region@b8000000 {
d366b02bf6a72c Eric Gonçalves 2025-06-15 102 reg = <0x0 0xb8000000 0x0 0x2b00000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 103 no-map;
d366b02bf6a72c Eric Gonçalves 2025-06-15 104 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 105 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 106
d366b02bf6a72c Eric Gonçalves 2025-06-15 107 vph_pwr: vph-pwr-regulator {
d366b02bf6a72c Eric Gonçalves 2025-06-15 108 compatible = "regulator-fixed";
d366b02bf6a72c Eric Gonçalves 2025-06-15 109 regulator-name = "vph_pwr";
d366b02bf6a72c Eric Gonçalves 2025-06-15 110 regulator-min-microvolt = <3700000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 111 regulator-max-microvolt = <3700000>;
d366b02bf6a72c Eric Gonçalves 2025-06-15 112
d366b02bf6a72c Eric Gonçalves 2025-06-15 113 regulator-always-on;
d366b02bf6a72c Eric Gonçalves 2025-06-15 114 regulator-boot-on;
d366b02bf6a72c Eric Gonçalves 2025-06-15 115 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 116 };
d366b02bf6a72c Eric Gonçalves 2025-06-15 117
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
2025-06-15 20:56 ` [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22 Eric Gonçalves
@ 2025-06-16 6:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-16 6:18 UTC (permalink / raw)
To: Eric Gonçalves, linux-arm-msm; +Cc: devicetree, konradybcio, robh
On 15/06/2025 22:56, Eric Gonçalves wrote:
> Adds new device support for the Samsung Galaxy S22 (SM-S901E) phone
>
> Working features:
> - simple-framebuffer
> - side buttons
> - storage
> - usb
Thread and name your patches correctly, e.g. use b4 or git format-patch
-vX -2, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>
>
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm8450-samsung-r0q.dts | 365 ++++++++++++++++++
> 2 files changed, 366 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 669b888b27a1..cde80a17f2ab 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -287,6 +287,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx224.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sm8450-samsung-r0q.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-hdk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm8550-qrd.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> new file mode 100644
> index 000000000000..cb58626e879e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> @@ -0,0 +1,365 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2025, Eric Gonçalves <ghatto404@gmail.com>
> + * Copyright (c) 2025, Arthur Aligon <arthurus36.alt2@tutanota.com>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "sm8450.dtsi"
> +#include "pm8350.dtsi"
> +#include "pm8350b.dtsi"
> +#include "pm8350c.dtsi"
> +#include "pm8450.dtsi"
> +#include "pmk8350.dtsi"
> +#include "pmr735a.dtsi"
> +
> +/delete-node/ &xbl_ramdump_mem;
> +/delete-node/ &xbl_sc_mem;
> +/delete-node/ &adsp_mem;
> +/delete-node/ &rmtfs_mem;
> +/delete-node/ &mte_mem;
> +/delete-node/ &trusted_apps_mem;
> +/delete-node/ &trusted_apps_ext_mem;
> +
> +/ {
> + chassis-type = "handset";
> + model = "Samsung Galaxy S22 (SM-S901E)";
> + compatible = "samsung,r0q", "qcom,sm8450";
> +
> + chosen {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + bootargs = "clk_ignore_unused pd_ignore_unused";
This is not really part of mainline DTS. If it is, then you need to
clearly document the reasons with comment.
> + linux,initrd-start = <0x00 0xb6915000>;
> + linux,initrd-end = <0x00 0xb7fff22c>;
Why this has to be in DTS?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] dt-bindings: arm: qcom: document r0q board binding
2025-06-15 20:56 [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Eric Gonçalves
2025-06-15 20:56 ` [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22 Eric Gonçalves
@ 2025-06-16 6:18 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-16 6:18 UTC (permalink / raw)
To: Eric Gonçalves, linux-arm-msm; +Cc: devicetree, konradybcio, robh
On 15/06/2025 22:56, Eric Gonçalves wrote:
> Adds compatible for the Samsung Galaxy S22 (SM-S901E) (r0q), based on the Snapdragon 8 Gen 1 SoC.
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index b14206d11f8b..7ed1da6e42ed 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1092,6 +1092,7 @@ properties:
> - qcom,sm8450-qrd
> - sony,pdx223
> - sony,pdx224
> + - samsung,r0q
Keep alphabetical order.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
@ 2025-06-16 20:31 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-06-16 20:31 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250615205608.1133129-2-ghatto404@gmail.com>
References: <20250615205608.1133129-2-ghatto404@gmail.com>
TO: "Eric Gonçalves" <ghatto404@gmail.com>
TO: linux-arm-msm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: konradybcio@kernel.org
CC: robh@kernel.org
CC: "Eric Gonçalves" <ghatto404@gmail.com>
Hi Eric,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.16-rc2 next-20250616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Gon-alves/arm64-dts-qcom-add-initial-tree-for-Samsung-Galaxy-S22/20250616-045847
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250615205608.1133129-2-ghatto404%40gmail.com
patch subject: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22
:::::: branch date: 23 hours ago
:::::: commit date: 23 hours ago
config: arm64-randconfig-051-20250616 (https://download.01.org/0day-ci/archive/20250617/202506170438.WyDgdF6n-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
dtschema version: 2025.3.dev28+g49451a5
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250617/202506170438.WyDgdF6n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202506170438.WyDgdF6n-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
'qcom,sm8550' was expected
'qcom,qcs8550-aim300' was expected
'qcom,sm8650' was expected
'qcom,sm8750' was expected
'qcom,x1e001de' was expected
'lenovo,thinkpad-t14s' was expected
'qcom,x1e80100' was expected
'qcom,x1p42100' was expected
from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#
arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtb: /: failed to match any schema with compatible: ['samsung,r0q', 'qcom,sm8450']
>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtb: / (samsung,r0q): memory: 'ddr_device_type' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/memory.yaml#
>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtb: / (samsung,r0q): memory: False schema does not allow {'ddr_device_type': [8], 'device_type': ['memory'], 'reg': [[0, 2147483648, 0, 1778384896], [0, 4055891968, 0, 239075328], [8, 0, 0, 984612864], [8, 1073741824, 1, 1073741824], [8, 990904320, 0, 31457280]]}
from schema $id: http://devicetree.org/schemas/root-node.yaml#
>> arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dtb: memory@fe200000 (qcom,rmtfs-mem): Unevaluated properties are not allowed ('reg-names' was unexpected)
from schema $id: http://devicetree.org/schemas/reserved-memory/qcom,rmtfs-mem.yaml#
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-16 20:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-15 20:56 [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Eric Gonçalves
2025-06-15 20:56 ` [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22 Eric Gonçalves
2025-06-16 6:18 ` Krzysztof Kozlowski
2025-06-16 6:18 ` [PATCH v2] dt-bindings: arm: qcom: document r0q board binding Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-06-16 4:25 [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22 kernel test robot
2025-06-16 20:31 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.