* [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
2025-06-21 21:05 [PATCH v1 0/5] Enable SSRAM support in PTL and LNL Xi Pardee
@ 2025-06-21 21:05 ` Xi Pardee
2025-06-24 14:45 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Xi Pardee @ 2025-06-21 21:05 UTC (permalink / raw)
To: xi.pardee, irenic.rajneesh, david.e.box, hdegoede, ilpo.jarvinen,
platform-driver-x86, linux-kernel, linux-pm
Add support to read and show S0ix blocker substate requirements.
Starting from Panther Lake, substate requirement data is provided
based on S0ix blockers instead of all low power mode requirements.
For platforms that support this new feature, add support to display
substate requirements based on S0ix blockers.
Change the "substate_requirements" attribute of Intel PMC Core
driver to show the substate requirements for each S0ix blocker
and the corresponding S0ix blocker value.
Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
---
drivers/platform/x86/intel/pmc/arl.c | 1 +
drivers/platform/x86/intel/pmc/core.c | 109 ++++++++++++++++++++++++--
drivers/platform/x86/intel/pmc/core.h | 12 +++
drivers/platform/x86/intel/pmc/lnl.c | 1 +
drivers/platform/x86/intel/pmc/mtl.c | 1 +
5 files changed, 118 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c
index 9d66d65e75779..f04c67738d721 100644
--- a/drivers/platform/x86/intel/pmc/arl.c
+++ b/drivers/platform/x86/intel/pmc/arl.c
@@ -732,6 +732,7 @@ struct pmc_dev_info arl_pmc_dev = {
struct pmc_dev_info arl_h_pmc_dev = {
.pci_func = 2,
+ .telem_info = SUB_REQ_LPM,
.dmu_guid = ARL_PMT_DMU_GUID,
.regmap_list = arl_pmc_info_list,
.map = &mtl_socm_reg_map,
diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index 47cc5120e7dd6..026a28bb7509c 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -844,6 +844,56 @@ static void pmc_core_substate_req_header_show(struct seq_file *s, int pmc_index,
seq_printf(s, " %9s |\n", name);
}
+static int pmc_core_substate_blk_req_show(struct seq_file *s, void *unused)
+{
+ struct pmc_dev *pmcdev = s->private;
+ unsigned int pmc_index;
+ u32 *blk_sub_req_regs;
+
+ for (pmc_index = 0; pmc_index < ARRAY_SIZE(pmcdev->pmcs); pmc_index++) {
+ const struct pmc_bit_map **maps;
+ unsigned int arr_size, r_idx;
+ u32 offset, counter;
+ struct pmc *pmc;
+
+ pmc = pmcdev->pmcs[pmc_index];
+ if (!pmc || !pmc->blk_sub_req_regs)
+ continue;
+
+ blk_sub_req_regs = pmc->blk_sub_req_regs;
+ maps = pmc->map->s0ix_blocker_maps;
+ offset = pmc->map->s0ix_blocker_offset;
+ arr_size = pmc_core_lpm_get_arr_size(maps);
+
+ /* Display the header */
+ pmc_core_substate_req_header_show(s, pmc_index, "Value");
+
+ for (r_idx = 0; r_idx < arr_size; r_idx++) {
+ const struct pmc_bit_map *map;
+
+ for (map = maps[r_idx]; map->name; map++) {
+ int mode;
+
+ if (!map->blk)
+ continue;
+
+ counter = pmc_core_reg_read(pmc, offset);
+ seq_printf(s, "pmc%d: %34s |", pmc_index, map->name);
+ pmc_for_each_mode(mode, pmcdev) {
+ bool required = *blk_sub_req_regs & BIT(mode);
+
+ seq_printf(s, " %9s |", required ? "Required" : " ");
+ }
+ seq_printf(s, " %9d |\n", counter);
+ offset += map->blk * S0IX_BLK_SIZE;
+ blk_sub_req_regs++;
+ }
+ }
+ }
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_blk_req);
+
static int pmc_core_substate_req_regs_show(struct seq_file *s, void *unused)
{
struct pmc_dev *pmcdev = s->private;
@@ -1335,7 +1385,10 @@ static void pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
debugfs_create_file("substate_requirements", 0444,
pmcdev->dbgfs_dir, pmcdev,
&pmc_core_substate_req_regs_fops);
- }
+ } else if (primary_pmc->blk_sub_req_regs)
+ debugfs_create_file("substate_requirements", 0444,
+ pmcdev->dbgfs_dir, pmcdev,
+ &pmc_core_substate_blk_req_fops);
if (primary_pmc->map->pson_residency_offset && pmc_core_is_pson_residency_enabled(pmcdev)) {
debugfs_create_file("pson_residency_usec", 0444,
@@ -1441,7 +1494,38 @@ static int pmc_core_pmt_get_lpm_req(struct pmc_dev *pmcdev, struct pmc *pmc,
return ret;
}
-static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func)
+static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
+ struct telem_endpoint *ep)
+{
+ u32 num_blocker, sample_id;
+ unsigned int index;
+ u32 *req_offset;
+ int ret;
+
+ num_blocker = pmc->map->num_s0ix_blocker;
+ sample_id = pmc->map->blocker_req_offset;
+
+ pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev,
+ num_blocker * sizeof(u32),
+ GFP_KERNEL);
+ if (!pmc->blk_sub_req_regs)
+ ret = -ENOMEM;
+
+ req_offset = pmc->blk_sub_req_regs;
+ for (index = 0; index < num_blocker; index++) {
+ ret = pmt_telem_read32(ep, sample_id, req_offset, 1);
+ if (ret) {
+ dev_err(&pmcdev->pdev->dev,
+ "couldn't read Low Power Mode requirements: %d\n", ret);
+ return ret;
+ }
+ sample_id++;
+ req_offset++;
+ }
+ return ret;
+}
+
+static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info)
{
struct pci_dev *pcidev __free(pci_dev_put) = NULL;
struct telem_endpoint *ep;
@@ -1470,13 +1554,24 @@ static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func)
return -EPROBE_DEFER;
}
- ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
- pmt_telem_unregister_endpoint(ep);
+ if (telem_info & SUB_REQ_LPM)
+ ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
if (ret)
- return ret;
+ goto unregister_ep;
+
+ if (telem_info & SUB_REQ_BLK)
+ ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep);
+ if (ret)
+ goto unregister_ep;
+
+ pmt_telem_unregister_endpoint(ep);
}
return 0;
+
+unregister_ep:
+ pmt_telem_unregister_endpoint(ep);
+ return ret;
}
static const struct pmc_reg_map *pmc_core_find_regmap(struct pmc_info *list, u16 devid)
@@ -1585,7 +1680,9 @@ int generic_core_init(struct pmc_dev *pmcdev, struct pmc_dev_info *pmc_dev_info)
pmc_core_punit_pmt_init(pmcdev, pmc_dev_info->dmu_guid);
if (ssram) {
- ret = pmc_core_get_telem_info(pmcdev, pmc_dev_info->pci_func);
+ ret = pmc_core_get_telem_info(pmcdev,
+ pmc_dev_info->pci_func,
+ pmc_dev_info->telem_info);
if (ret)
goto unmap_regbase;
}
diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
index 4a94a4ee031e6..d8c7b28493055 100644
--- a/drivers/platform/x86/intel/pmc/core.h
+++ b/drivers/platform/x86/intel/pmc/core.h
@@ -29,6 +29,10 @@ struct telem_endpoint;
#define LPM_REG_COUNT 28
#define LPM_MODE_OFFSET 1
+/* Telemetry Endpoint Info bits */
+#define SUB_REQ_LPM 0x01 /* Substate requirement for low power mode requirements */
+#define SUB_REQ_BLK 0x02 /* Substate requirement for S0ix blockers */
+
/* Sunrise Point Power Management Controller PCI Device ID */
#define SPT_PMC_PCI_DEVICE_ID 0x9d21
#define SPT_PMC_BASE_ADDR_OFFSET 0x48
@@ -344,6 +348,8 @@ struct pmc_bit_map {
* @pm_read_disable_bit: Bit index to read PMC_READ_DISABLE
* @slps0_dbg_offset: PWRMBASE offset to SLP_S0_DEBUG_REG*
* @s0ix_blocker_offset PWRMBASE offset to S0ix blocker counter
+ * @num_s0ix_blocker: Number of S0ix blockers
+ * @blocker_req_offset: Telemetry offset to S0ix blocker low power mode substate requirement table
*
* Each PCH has unique set of register offsets and bit indexes. This structure
* captures them to have a common implementation.
@@ -369,6 +375,8 @@ struct pmc_reg_map {
const u32 ltr_ignore_max;
const u32 pm_vric1_offset;
const u32 s0ix_blocker_offset;
+ const u32 num_s0ix_blocker;
+ const u32 blocker_req_offset;
/* Low Power Mode registers */
const int lpm_num_maps;
const int lpm_num_modes;
@@ -404,6 +412,7 @@ struct pmc_info {
* @map: pointer to pmc_reg_map struct that contains platform
* specific attributes
* @lpm_req_regs: List of substate requirements
+ * @blk_sub_req_reqs: List of registers showing substate requirements for S0ix blockers
* @ltr_ign: Holds LTR ignore data while suspended
*
* pmc contains info about one power management controller device.
@@ -413,6 +422,7 @@ struct pmc {
void __iomem *regbase;
const struct pmc_reg_map *map;
u32 *lpm_req_regs;
+ u32 *blk_sub_req_regs;
u32 ltr_ign;
};
@@ -468,6 +478,7 @@ enum pmc_index {
/**
* struct pmc_dev_info - Structure to keep PMC device info
* @pci_func: Function number of the primary PMC
+ * @telem_info: Bitmask to indicate which telemetry info is available
* @dmu_guid: Die Management Unit GUID
* @regmap_list: Pointer to a list of pmc_info structure that could be
* available for the platform. When set, this field implies
@@ -480,6 +491,7 @@ enum pmc_index {
*/
struct pmc_dev_info {
u8 pci_func;
+ u8 telem_info;
u32 dmu_guid;
struct pmc_info *regmap_list;
const struct pmc_reg_map *map;
diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c
index e08a77c778c2c..ec9e79f6cd913 100644
--- a/drivers/platform/x86/intel/pmc/lnl.c
+++ b/drivers/platform/x86/intel/pmc/lnl.c
@@ -572,6 +572,7 @@ static int lnl_core_init(struct pmc_dev *pmcdev, struct pmc_dev_info *pmc_dev_in
struct pmc_dev_info lnl_pmc_dev = {
.pci_func = 2,
+ .telem_info = SUB_REQ_LPM,
.regmap_list = lnl_pmc_info_list,
.map = &lnl_socm_reg_map,
.suspend = cnl_suspend,
diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c
index faa13a7ee688f..c58a871e2e0df 100644
--- a/drivers/platform/x86/intel/pmc/mtl.c
+++ b/drivers/platform/x86/intel/pmc/mtl.c
@@ -994,6 +994,7 @@ static int mtl_core_init(struct pmc_dev *pmcdev, struct pmc_dev_info *pmc_dev_in
struct pmc_dev_info mtl_pmc_dev = {
.pci_func = 2,
+ .telem_info = SUB_REQ_LPM,
.dmu_guid = MTL_PMT_DMU_GUID,
.regmap_list = mtl_pmc_info_list,
.map = &mtl_socm_reg_map,
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
@ 2025-06-24 10:50 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2025-06-24 10:50 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250621210529.237964-5-xi.pardee@linux.intel.com>
References: <20250621210529.237964-5-xi.pardee@linux.intel.com>
TO: Xi Pardee <xi.pardee@linux.intel.com>
Hi Xi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.16-rc3 next-20250623]
[cannot apply to amd-pstate/linux-next amd-pstate/bleeding-edge]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xi-Pardee/platform-x86-intel-pmc-Enable-SSRAM-support-for-Lunar-Lake/20250622-050804
base: linus/master
patch link: https://lore.kernel.org/r/20250621210529.237964-5-xi.pardee%40linux.intel.com
patch subject: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241840.0POVt4tf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506241840.0POVt4tf-lkp@intel.com/
New smatch warnings:
drivers/platform/x86/intel/pmc/core.c:1525 pmc_core_pmt_get_blk_sub_req() error: uninitialized symbol 'ret'.
drivers/platform/x86/intel/pmc/core.c:1559 pmc_core_get_telem_info() error: uninitialized symbol 'ret'.
Old smatch warnings:
drivers/platform/x86/intel/pmc/core.c:502 pmc_core_send_ltr_ignore() error: uninitialized symbol 'pmc'.
drivers/platform/x86/intel/pmc/core.c:502 pmc_core_send_ltr_ignore() error: uninitialized symbol 'map'.
drivers/platform/x86/intel/pmc/core.c:502 pmc_core_send_ltr_ignore() error: we previously assumed 'pmc' could be null (see line 480)
drivers/platform/x86/intel/pmc/core.c:1494 pmc_core_pmt_get_lpm_req() error: uninitialized symbol 'ret'.
vim +/ret +1525 drivers/platform/x86/intel/pmc/core.c
78a7491d5cba8b Xi Pardee 2025-04-09 1496
f3435ca196060d Xi Pardee 2025-06-21 1497 static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
f3435ca196060d Xi Pardee 2025-06-21 1498 struct telem_endpoint *ep)
f3435ca196060d Xi Pardee 2025-06-21 1499 {
f3435ca196060d Xi Pardee 2025-06-21 1500 u32 num_blocker, sample_id;
f3435ca196060d Xi Pardee 2025-06-21 1501 unsigned int index;
f3435ca196060d Xi Pardee 2025-06-21 1502 u32 *req_offset;
f3435ca196060d Xi Pardee 2025-06-21 1503 int ret;
f3435ca196060d Xi Pardee 2025-06-21 1504
f3435ca196060d Xi Pardee 2025-06-21 1505 num_blocker = pmc->map->num_s0ix_blocker;
f3435ca196060d Xi Pardee 2025-06-21 1506 sample_id = pmc->map->blocker_req_offset;
f3435ca196060d Xi Pardee 2025-06-21 1507
f3435ca196060d Xi Pardee 2025-06-21 1508 pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev,
f3435ca196060d Xi Pardee 2025-06-21 1509 num_blocker * sizeof(u32),
f3435ca196060d Xi Pardee 2025-06-21 1510 GFP_KERNEL);
f3435ca196060d Xi Pardee 2025-06-21 1511 if (!pmc->blk_sub_req_regs)
f3435ca196060d Xi Pardee 2025-06-21 1512 ret = -ENOMEM;
f3435ca196060d Xi Pardee 2025-06-21 1513
f3435ca196060d Xi Pardee 2025-06-21 1514 req_offset = pmc->blk_sub_req_regs;
f3435ca196060d Xi Pardee 2025-06-21 1515 for (index = 0; index < num_blocker; index++) {
f3435ca196060d Xi Pardee 2025-06-21 1516 ret = pmt_telem_read32(ep, sample_id, req_offset, 1);
f3435ca196060d Xi Pardee 2025-06-21 1517 if (ret) {
f3435ca196060d Xi Pardee 2025-06-21 1518 dev_err(&pmcdev->pdev->dev,
f3435ca196060d Xi Pardee 2025-06-21 1519 "couldn't read Low Power Mode requirements: %d\n", ret);
f3435ca196060d Xi Pardee 2025-06-21 1520 return ret;
f3435ca196060d Xi Pardee 2025-06-21 1521 }
f3435ca196060d Xi Pardee 2025-06-21 1522 sample_id++;
f3435ca196060d Xi Pardee 2025-06-21 1523 req_offset++;
f3435ca196060d Xi Pardee 2025-06-21 1524 }
f3435ca196060d Xi Pardee 2025-06-21 @1525 return ret;
f3435ca196060d Xi Pardee 2025-06-21 1526 }
f3435ca196060d Xi Pardee 2025-06-21 1527
f3435ca196060d Xi Pardee 2025-06-21 1528 static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info)
78a7491d5cba8b Xi Pardee 2025-04-09 1529 {
b5d46539626833 Xi Pardee 2025-04-25 1530 struct pci_dev *pcidev __free(pci_dev_put) = NULL;
d7bc7e19147769 Xi Pardee 2025-06-21 1531 struct telem_endpoint *ep;
052fabddeaa70b Xi Pardee 2025-04-09 1532 unsigned int i;
d7bc7e19147769 Xi Pardee 2025-06-21 1533 u32 guid;
052fabddeaa70b Xi Pardee 2025-04-09 1534 int ret;
78a7491d5cba8b Xi Pardee 2025-04-09 1535
b5d46539626833 Xi Pardee 2025-04-25 1536 pcidev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(20, func));
b5d46539626833 Xi Pardee 2025-04-25 1537 if (!pcidev)
78a7491d5cba8b Xi Pardee 2025-04-09 1538 return -ENODEV;
78a7491d5cba8b Xi Pardee 2025-04-09 1539
78a7491d5cba8b Xi Pardee 2025-04-09 1540 for (i = 0; i < ARRAY_SIZE(pmcdev->pmcs); ++i) {
d7bc7e19147769 Xi Pardee 2025-06-21 1541 struct pmc *pmc;
d7bc7e19147769 Xi Pardee 2025-06-21 1542
d7bc7e19147769 Xi Pardee 2025-06-21 1543 pmc = pmcdev->pmcs[i];
d7bc7e19147769 Xi Pardee 2025-06-21 1544 if (!pmc)
78a7491d5cba8b Xi Pardee 2025-04-09 1545 continue;
78a7491d5cba8b Xi Pardee 2025-04-09 1546
d7bc7e19147769 Xi Pardee 2025-06-21 1547 guid = pmc_core_find_guid(pmcdev->regmap_list, pmc->map);
d7bc7e19147769 Xi Pardee 2025-06-21 1548 if (!guid)
d7bc7e19147769 Xi Pardee 2025-06-21 1549 return -ENXIO;
d7bc7e19147769 Xi Pardee 2025-06-21 1550
d7bc7e19147769 Xi Pardee 2025-06-21 1551 ep = pmt_telem_find_and_register_endpoint(pcidev, guid, 0);
d7bc7e19147769 Xi Pardee 2025-06-21 1552 if (IS_ERR(ep)) {
d7bc7e19147769 Xi Pardee 2025-06-21 1553 dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep);
d7bc7e19147769 Xi Pardee 2025-06-21 1554 return -EPROBE_DEFER;
d7bc7e19147769 Xi Pardee 2025-06-21 1555 }
d7bc7e19147769 Xi Pardee 2025-06-21 1556
f3435ca196060d Xi Pardee 2025-06-21 1557 if (telem_info & SUB_REQ_LPM)
d7bc7e19147769 Xi Pardee 2025-06-21 1558 ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
78a7491d5cba8b Xi Pardee 2025-04-09 @1559 if (ret)
f3435ca196060d Xi Pardee 2025-06-21 1560 goto unregister_ep;
f3435ca196060d Xi Pardee 2025-06-21 1561
f3435ca196060d Xi Pardee 2025-06-21 1562 if (telem_info & SUB_REQ_BLK)
f3435ca196060d Xi Pardee 2025-06-21 1563 ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep);
f3435ca196060d Xi Pardee 2025-06-21 1564 if (ret)
f3435ca196060d Xi Pardee 2025-06-21 1565 goto unregister_ep;
f3435ca196060d Xi Pardee 2025-06-21 1566
f3435ca196060d Xi Pardee 2025-06-21 1567 pmt_telem_unregister_endpoint(ep);
78a7491d5cba8b Xi Pardee 2025-04-09 1568 }
78a7491d5cba8b Xi Pardee 2025-04-09 1569
78a7491d5cba8b Xi Pardee 2025-04-09 1570 return 0;
f3435ca196060d Xi Pardee 2025-06-21 1571
f3435ca196060d Xi Pardee 2025-06-21 1572 unregister_ep:
f3435ca196060d Xi Pardee 2025-06-21 1573 pmt_telem_unregister_endpoint(ep);
f3435ca196060d Xi Pardee 2025-06-21 1574 return ret;
78a7491d5cba8b Xi Pardee 2025-04-09 1575 }
78a7491d5cba8b Xi Pardee 2025-04-09 1576
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
2025-06-21 21:05 ` [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers Xi Pardee
@ 2025-06-24 14:45 ` Dan Carpenter
2025-06-24 18:56 ` Xi Pardee
2025-06-25 6:42 ` Xi Pardee
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2025-06-24 14:45 UTC (permalink / raw)
To: oe-kbuild, Xi Pardee; +Cc: lkp, oe-kbuild-all
Hi Xi,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xi-Pardee/platform-x86-intel-pmc-Enable-SSRAM-support-for-Lunar-Lake/20250622-050804
base: linus/master
patch link: https://lore.kernel.org/r/20250621210529.237964-5-xi.pardee%40linux.intel.com
patch subject: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241840.0POVt4tf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202506241840.0POVt4tf-lkp@intel.com/
New smatch warnings:
drivers/platform/x86/intel/pmc/core.c:1525 pmc_core_pmt_get_blk_sub_req() error: uninitialized symbol 'ret'.
drivers/platform/x86/intel/pmc/core.c:1559 pmc_core_get_telem_info() error: uninitialized symbol 'ret'.
vim +/ret +1525 drivers/platform/x86/intel/pmc/core.c
f3435ca196060d Xi Pardee 2025-06-21 1497 static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
f3435ca196060d Xi Pardee 2025-06-21 1498 struct telem_endpoint *ep)
f3435ca196060d Xi Pardee 2025-06-21 1499 {
f3435ca196060d Xi Pardee 2025-06-21 1500 u32 num_blocker, sample_id;
f3435ca196060d Xi Pardee 2025-06-21 1501 unsigned int index;
f3435ca196060d Xi Pardee 2025-06-21 1502 u32 *req_offset;
f3435ca196060d Xi Pardee 2025-06-21 1503 int ret;
f3435ca196060d Xi Pardee 2025-06-21 1504
f3435ca196060d Xi Pardee 2025-06-21 1505 num_blocker = pmc->map->num_s0ix_blocker;
f3435ca196060d Xi Pardee 2025-06-21 1506 sample_id = pmc->map->blocker_req_offset;
f3435ca196060d Xi Pardee 2025-06-21 1507
f3435ca196060d Xi Pardee 2025-06-21 1508 pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev,
f3435ca196060d Xi Pardee 2025-06-21 1509 num_blocker * sizeof(u32),
Use devm_kcalloc() so we don't have to check if num_blocker can be
greater than UINT_MAX / 4 on 32bit systems.
f3435ca196060d Xi Pardee 2025-06-21 1510 GFP_KERNEL);
f3435ca196060d Xi Pardee 2025-06-21 1511 if (!pmc->blk_sub_req_regs)
f3435ca196060d Xi Pardee 2025-06-21 1512 ret = -ENOMEM;
s/ret = /return /. Otherwise it leads to a NULL pointer dereference.
f3435ca196060d Xi Pardee 2025-06-21 1513
f3435ca196060d Xi Pardee 2025-06-21 1514 req_offset = pmc->blk_sub_req_regs;
f3435ca196060d Xi Pardee 2025-06-21 1515 for (index = 0; index < num_blocker; index++) {
smatch doesn't know if num_blocker can be zero.
f3435ca196060d Xi Pardee 2025-06-21 1516 ret = pmt_telem_read32(ep, sample_id, req_offset, 1);
f3435ca196060d Xi Pardee 2025-06-21 1517 if (ret) {
f3435ca196060d Xi Pardee 2025-06-21 1518 dev_err(&pmcdev->pdev->dev,
f3435ca196060d Xi Pardee 2025-06-21 1519 "couldn't read Low Power Mode requirements: %d\n", ret);
f3435ca196060d Xi Pardee 2025-06-21 1520 return ret;
f3435ca196060d Xi Pardee 2025-06-21 1521 }
f3435ca196060d Xi Pardee 2025-06-21 1522 sample_id++;
f3435ca196060d Xi Pardee 2025-06-21 1523 req_offset++;
f3435ca196060d Xi Pardee 2025-06-21 1524 }
f3435ca196060d Xi Pardee 2025-06-21 @1525 return ret;
f3435ca196060d Xi Pardee 2025-06-21 1526 }
f3435ca196060d Xi Pardee 2025-06-21 1527
f3435ca196060d Xi Pardee 2025-06-21 1528 static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info)
78a7491d5cba8b Xi Pardee 2025-04-09 1529 {
b5d46539626833 Xi Pardee 2025-04-25 1530 struct pci_dev *pcidev __free(pci_dev_put) = NULL;
d7bc7e19147769 Xi Pardee 2025-06-21 1531 struct telem_endpoint *ep;
052fabddeaa70b Xi Pardee 2025-04-09 1532 unsigned int i;
d7bc7e19147769 Xi Pardee 2025-06-21 1533 u32 guid;
052fabddeaa70b Xi Pardee 2025-04-09 1534 int ret;
78a7491d5cba8b Xi Pardee 2025-04-09 1535
b5d46539626833 Xi Pardee 2025-04-25 1536 pcidev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(20, func));
b5d46539626833 Xi Pardee 2025-04-25 1537 if (!pcidev)
78a7491d5cba8b Xi Pardee 2025-04-09 1538 return -ENODEV;
78a7491d5cba8b Xi Pardee 2025-04-09 1539
78a7491d5cba8b Xi Pardee 2025-04-09 1540 for (i = 0; i < ARRAY_SIZE(pmcdev->pmcs); ++i) {
d7bc7e19147769 Xi Pardee 2025-06-21 1541 struct pmc *pmc;
d7bc7e19147769 Xi Pardee 2025-06-21 1542
d7bc7e19147769 Xi Pardee 2025-06-21 1543 pmc = pmcdev->pmcs[i];
d7bc7e19147769 Xi Pardee 2025-06-21 1544 if (!pmc)
78a7491d5cba8b Xi Pardee 2025-04-09 1545 continue;
78a7491d5cba8b Xi Pardee 2025-04-09 1546
d7bc7e19147769 Xi Pardee 2025-06-21 1547 guid = pmc_core_find_guid(pmcdev->regmap_list, pmc->map);
d7bc7e19147769 Xi Pardee 2025-06-21 1548 if (!guid)
d7bc7e19147769 Xi Pardee 2025-06-21 1549 return -ENXIO;
d7bc7e19147769 Xi Pardee 2025-06-21 1550
d7bc7e19147769 Xi Pardee 2025-06-21 1551 ep = pmt_telem_find_and_register_endpoint(pcidev, guid, 0);
d7bc7e19147769 Xi Pardee 2025-06-21 1552 if (IS_ERR(ep)) {
d7bc7e19147769 Xi Pardee 2025-06-21 1553 dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep);
d7bc7e19147769 Xi Pardee 2025-06-21 1554 return -EPROBE_DEFER;
d7bc7e19147769 Xi Pardee 2025-06-21 1555 }
d7bc7e19147769 Xi Pardee 2025-06-21 1556
f3435ca196060d Xi Pardee 2025-06-21 1557 if (telem_info & SUB_REQ_LPM)
d7bc7e19147769 Xi Pardee 2025-06-21 1558 ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
ret is uninitialized on else path. I generally encourage developers
to set CONFIG_INIT_STACK_ALL_PATTERN=y for their testing.
78a7491d5cba8b Xi Pardee 2025-04-09 @1559 if (ret)
f3435ca196060d Xi Pardee 2025-06-21 1560 goto unregister_ep;
f3435ca196060d Xi Pardee 2025-06-21 1561
f3435ca196060d Xi Pardee 2025-06-21 1562 if (telem_info & SUB_REQ_BLK)
f3435ca196060d Xi Pardee 2025-06-21 1563 ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep);
f3435ca196060d Xi Pardee 2025-06-21 1564 if (ret)
f3435ca196060d Xi Pardee 2025-06-21 1565 goto unregister_ep;
f3435ca196060d Xi Pardee 2025-06-21 1566
f3435ca196060d Xi Pardee 2025-06-21 1567 pmt_telem_unregister_endpoint(ep);
78a7491d5cba8b Xi Pardee 2025-04-09 1568 }
78a7491d5cba8b Xi Pardee 2025-04-09 1569
78a7491d5cba8b Xi Pardee 2025-04-09 1570 return 0;
f3435ca196060d Xi Pardee 2025-06-21 1571
f3435ca196060d Xi Pardee 2025-06-21 1572 unregister_ep:
f3435ca196060d Xi Pardee 2025-06-21 1573 pmt_telem_unregister_endpoint(ep);
f3435ca196060d Xi Pardee 2025-06-21 1574 return ret;
78a7491d5cba8b Xi Pardee 2025-04-09 1575 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
2025-06-24 14:45 ` Dan Carpenter
@ 2025-06-24 18:56 ` Xi Pardee
2025-06-25 6:42 ` Xi Pardee
1 sibling, 0 replies; 5+ messages in thread
From: Xi Pardee @ 2025-06-24 18:56 UTC (permalink / raw)
To: Dan Carpenter, oe-kbuild; +Cc: lkp, oe-kbuild-all
Hi Dan,
Thanks for reviewing. My responses are in line.
Xi
On 6/24/2025 7:45 AM, Dan Carpenter wrote:
> Hi Xi,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Xi-Pardee/platform-x86-intel-pmc-Enable-SSRAM-support-for-Lunar-Lake/20250622-050804
> base: linus/master
> patch link: https://lore.kernel.org/r/20250621210529.237964-5-xi.pardee%40linux.intel.com
> patch subject: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
> config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241840.0POVt4tf-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202506241840.0POVt4tf-lkp@intel.com/
>
> New smatch warnings:
> drivers/platform/x86/intel/pmc/core.c:1525 pmc_core_pmt_get_blk_sub_req() error: uninitialized symbol 'ret'.
> drivers/platform/x86/intel/pmc/core.c:1559 pmc_core_get_telem_info() error: uninitialized symbol 'ret'.
>
> vim +/ret +1525 drivers/platform/x86/intel/pmc/core.c
>
> f3435ca196060d Xi Pardee 2025-06-21 1497 static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
> f3435ca196060d Xi Pardee 2025-06-21 1498 struct telem_endpoint *ep)
> f3435ca196060d Xi Pardee 2025-06-21 1499 {
> f3435ca196060d Xi Pardee 2025-06-21 1500 u32 num_blocker, sample_id;
> f3435ca196060d Xi Pardee 2025-06-21 1501 unsigned int index;
> f3435ca196060d Xi Pardee 2025-06-21 1502 u32 *req_offset;
> f3435ca196060d Xi Pardee 2025-06-21 1503 int ret;
> f3435ca196060d Xi Pardee 2025-06-21 1504
> f3435ca196060d Xi Pardee 2025-06-21 1505 num_blocker = pmc->map->num_s0ix_blocker;
> f3435ca196060d Xi Pardee 2025-06-21 1506 sample_id = pmc->map->blocker_req_offset;
> f3435ca196060d Xi Pardee 2025-06-21 1507
> f3435ca196060d Xi Pardee 2025-06-21 1508 pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev,
> f3435ca196060d Xi Pardee 2025-06-21 1509 num_blocker * sizeof(u32),
>
> Use devm_kcalloc() so we don't have to check if num_blocker can be
> greater than UINT_MAX / 4 on 32bit systems.
Will change to use devm_kcalloc() in next version.
>
> f3435ca196060d Xi Pardee 2025-06-21 1510 GFP_KERNEL);
> f3435ca196060d Xi Pardee 2025-06-21 1511 if (!pmc->blk_sub_req_regs)
> f3435ca196060d Xi Pardee 2025-06-21 1512 ret = -ENOMEM;
>
> s/ret = /return /. Otherwise it leads to a NULL pointer dereference.
Will change to return in next version
>
> f3435ca196060d Xi Pardee 2025-06-21 1513
> f3435ca196060d Xi Pardee 2025-06-21 1514 req_offset = pmc->blk_sub_req_regs;
> f3435ca196060d Xi Pardee 2025-06-21 1515 for (index = 0; index < num_blocker; index++) {
>
> smatch doesn't know if num_blocker can be zero.
Will initialize ret to be 0 in next version.
>
> f3435ca196060d Xi Pardee 2025-06-21 1516 ret = pmt_telem_read32(ep, sample_id, req_offset, 1);
> f3435ca196060d Xi Pardee 2025-06-21 1517 if (ret) {
> f3435ca196060d Xi Pardee 2025-06-21 1518 dev_err(&pmcdev->pdev->dev,
> f3435ca196060d Xi Pardee 2025-06-21 1519 "couldn't read Low Power Mode requirements: %d\n", ret);
> f3435ca196060d Xi Pardee 2025-06-21 1520 return ret;
> f3435ca196060d Xi Pardee 2025-06-21 1521 }
> f3435ca196060d Xi Pardee 2025-06-21 1522 sample_id++;
> f3435ca196060d Xi Pardee 2025-06-21 1523 req_offset++;
> f3435ca196060d Xi Pardee 2025-06-21 1524 }
> f3435ca196060d Xi Pardee 2025-06-21 @1525 return ret;
> f3435ca196060d Xi Pardee 2025-06-21 1526 }
> f3435ca196060d Xi Pardee 2025-06-21 1527
> f3435ca196060d Xi Pardee 2025-06-21 1528 static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1529 {
> b5d46539626833 Xi Pardee 2025-04-25 1530 struct pci_dev *pcidev __free(pci_dev_put) = NULL;
> d7bc7e19147769 Xi Pardee 2025-06-21 1531 struct telem_endpoint *ep;
> 052fabddeaa70b Xi Pardee 2025-04-09 1532 unsigned int i;
> d7bc7e19147769 Xi Pardee 2025-06-21 1533 u32 guid;
> 052fabddeaa70b Xi Pardee 2025-04-09 1534 int ret;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1535
> b5d46539626833 Xi Pardee 2025-04-25 1536 pcidev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(20, func));
> b5d46539626833 Xi Pardee 2025-04-25 1537 if (!pcidev)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1538 return -ENODEV;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1539
> 78a7491d5cba8b Xi Pardee 2025-04-09 1540 for (i = 0; i < ARRAY_SIZE(pmcdev->pmcs); ++i) {
> d7bc7e19147769 Xi Pardee 2025-06-21 1541 struct pmc *pmc;
> d7bc7e19147769 Xi Pardee 2025-06-21 1542
> d7bc7e19147769 Xi Pardee 2025-06-21 1543 pmc = pmcdev->pmcs[i];
> d7bc7e19147769 Xi Pardee 2025-06-21 1544 if (!pmc)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1545 continue;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1546
> d7bc7e19147769 Xi Pardee 2025-06-21 1547 guid = pmc_core_find_guid(pmcdev->regmap_list, pmc->map);
> d7bc7e19147769 Xi Pardee 2025-06-21 1548 if (!guid)
> d7bc7e19147769 Xi Pardee 2025-06-21 1549 return -ENXIO;
> d7bc7e19147769 Xi Pardee 2025-06-21 1550
> d7bc7e19147769 Xi Pardee 2025-06-21 1551 ep = pmt_telem_find_and_register_endpoint(pcidev, guid, 0);
> d7bc7e19147769 Xi Pardee 2025-06-21 1552 if (IS_ERR(ep)) {
> d7bc7e19147769 Xi Pardee 2025-06-21 1553 dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep);
> d7bc7e19147769 Xi Pardee 2025-06-21 1554 return -EPROBE_DEFER;
> d7bc7e19147769 Xi Pardee 2025-06-21 1555 }
> d7bc7e19147769 Xi Pardee 2025-06-21 1556
> f3435ca196060d Xi Pardee 2025-06-21 1557 if (telem_info & SUB_REQ_LPM)
> d7bc7e19147769 Xi Pardee 2025-06-21 1558 ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
>
> ret is uninitialized on else path. I generally encourage developers
> to set CONFIG_INIT_STACK_ALL_PATTERN=y for their testing.
Will initialize ret to be 0 in next version. Thanks for your suggestion.
Will try this option when testing.
Thanks!
Xi
> 78a7491d5cba8b Xi Pardee 2025-04-09 @1559 if (ret)
> f3435ca196060d Xi Pardee 2025-06-21 1560 goto unregister_ep;
> f3435ca196060d Xi Pardee 2025-06-21 1561
> f3435ca196060d Xi Pardee 2025-06-21 1562 if (telem_info & SUB_REQ_BLK)
> f3435ca196060d Xi Pardee 2025-06-21 1563 ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep);
> f3435ca196060d Xi Pardee 2025-06-21 1564 if (ret)
> f3435ca196060d Xi Pardee 2025-06-21 1565 goto unregister_ep;
> f3435ca196060d Xi Pardee 2025-06-21 1566
> f3435ca196060d Xi Pardee 2025-06-21 1567 pmt_telem_unregister_endpoint(ep);
> 78a7491d5cba8b Xi Pardee 2025-04-09 1568 }
> 78a7491d5cba8b Xi Pardee 2025-04-09 1569
> 78a7491d5cba8b Xi Pardee 2025-04-09 1570 return 0;
> f3435ca196060d Xi Pardee 2025-06-21 1571
> f3435ca196060d Xi Pardee 2025-06-21 1572 unregister_ep:
> f3435ca196060d Xi Pardee 2025-06-21 1573 pmt_telem_unregister_endpoint(ep);
> f3435ca196060d Xi Pardee 2025-06-21 1574 return ret;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1575 }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
2025-06-24 14:45 ` Dan Carpenter
2025-06-24 18:56 ` Xi Pardee
@ 2025-06-25 6:42 ` Xi Pardee
1 sibling, 0 replies; 5+ messages in thread
From: Xi Pardee @ 2025-06-25 6:42 UTC (permalink / raw)
To: Dan Carpenter, oe-kbuild; +Cc: lkp, oe-kbuild-all
Hi Dan,
Thanks for your comments. Responses are in line.
Xi
On 6/24/2025 7:45 AM, Dan Carpenter wrote:
> Hi Xi,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Xi-Pardee/platform-x86-intel-pmc-Enable-SSRAM-support-for-Lunar-Lake/20250622-050804
> base: linus/master
> patch link: https://lore.kernel.org/r/20250621210529.237964-5-xi.pardee%40linux.intel.com
> patch subject: [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers
> config: i386-randconfig-141-20250623 (https://download.01.org/0day-ci/archive/20250624/202506241840.0POVt4tf-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202506241840.0POVt4tf-lkp@intel.com/
>
> New smatch warnings:
> drivers/platform/x86/intel/pmc/core.c:1525 pmc_core_pmt_get_blk_sub_req() error: uninitialized symbol 'ret'.
> drivers/platform/x86/intel/pmc/core.c:1559 pmc_core_get_telem_info() error: uninitialized symbol 'ret'.
>
> vim +/ret +1525 drivers/platform/x86/intel/pmc/core.c
>
> f3435ca196060d Xi Pardee 2025-06-21 1497 static int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
> f3435ca196060d Xi Pardee 2025-06-21 1498 struct telem_endpoint *ep)
> f3435ca196060d Xi Pardee 2025-06-21 1499 {
> f3435ca196060d Xi Pardee 2025-06-21 1500 u32 num_blocker, sample_id;
> f3435ca196060d Xi Pardee 2025-06-21 1501 unsigned int index;
> f3435ca196060d Xi Pardee 2025-06-21 1502 u32 *req_offset;
> f3435ca196060d Xi Pardee 2025-06-21 1503 int ret;
> f3435ca196060d Xi Pardee 2025-06-21 1504
> f3435ca196060d Xi Pardee 2025-06-21 1505 num_blocker = pmc->map->num_s0ix_blocker;
> f3435ca196060d Xi Pardee 2025-06-21 1506 sample_id = pmc->map->blocker_req_offset;
> f3435ca196060d Xi Pardee 2025-06-21 1507
> f3435ca196060d Xi Pardee 2025-06-21 1508 pmc->blk_sub_req_regs = devm_kzalloc(&pmcdev->pdev->dev,
> f3435ca196060d Xi Pardee 2025-06-21 1509 num_blocker * sizeof(u32),
>
> Use devm_kcalloc() so we don't have to check if num_blocker can be
> greater than UINT_MAX / 4 on 32bit systems.
>
> f3435ca196060d Xi Pardee 2025-06-21 1510 GFP_KERNEL);
> f3435ca196060d Xi Pardee 2025-06-21 1511 if (!pmc->blk_sub_req_regs)
> f3435ca196060d Xi Pardee 2025-06-21 1512 ret = -ENOMEM;
>
> s/ret = /return /. Otherwise it leads to a NULL pointer dereference.
>
> f3435ca196060d Xi Pardee 2025-06-21 1513
> f3435ca196060d Xi Pardee 2025-06-21 1514 req_offset = pmc->blk_sub_req_regs;
> f3435ca196060d Xi Pardee 2025-06-21 1515 for (index = 0; index < num_blocker; index++) {
>
> smatch doesn't know if num_blocker can be zero.
To avoid the warning, return 0 instead when function succeeds in version 2.
>
> f3435ca196060d Xi Pardee 2025-06-21 1516 ret = pmt_telem_read32(ep, sample_id, req_offset, 1);
> f3435ca196060d Xi Pardee 2025-06-21 1517 if (ret) {
> f3435ca196060d Xi Pardee 2025-06-21 1518 dev_err(&pmcdev->pdev->dev,
> f3435ca196060d Xi Pardee 2025-06-21 1519 "couldn't read Low Power Mode requirements: %d\n", ret);
> f3435ca196060d Xi Pardee 2025-06-21 1520 return ret;
> f3435ca196060d Xi Pardee 2025-06-21 1521 }
> f3435ca196060d Xi Pardee 2025-06-21 1522 sample_id++;
> f3435ca196060d Xi Pardee 2025-06-21 1523 req_offset++;
> f3435ca196060d Xi Pardee 2025-06-21 1524 }
> f3435ca196060d Xi Pardee 2025-06-21 @1525 return ret;
> f3435ca196060d Xi Pardee 2025-06-21 1526 }
> f3435ca196060d Xi Pardee 2025-06-21 1527
> f3435ca196060d Xi Pardee 2025-06-21 1528 static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, int func, unsigned int telem_info)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1529 {
> b5d46539626833 Xi Pardee 2025-04-25 1530 struct pci_dev *pcidev __free(pci_dev_put) = NULL;
> d7bc7e19147769 Xi Pardee 2025-06-21 1531 struct telem_endpoint *ep;
> 052fabddeaa70b Xi Pardee 2025-04-09 1532 unsigned int i;
> d7bc7e19147769 Xi Pardee 2025-06-21 1533 u32 guid;
> 052fabddeaa70b Xi Pardee 2025-04-09 1534 int ret;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1535
> b5d46539626833 Xi Pardee 2025-04-25 1536 pcidev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(20, func));
> b5d46539626833 Xi Pardee 2025-04-25 1537 if (!pcidev)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1538 return -ENODEV;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1539
> 78a7491d5cba8b Xi Pardee 2025-04-09 1540 for (i = 0; i < ARRAY_SIZE(pmcdev->pmcs); ++i) {
> d7bc7e19147769 Xi Pardee 2025-06-21 1541 struct pmc *pmc;
> d7bc7e19147769 Xi Pardee 2025-06-21 1542
> d7bc7e19147769 Xi Pardee 2025-06-21 1543 pmc = pmcdev->pmcs[i];
> d7bc7e19147769 Xi Pardee 2025-06-21 1544 if (!pmc)
> 78a7491d5cba8b Xi Pardee 2025-04-09 1545 continue;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1546
> d7bc7e19147769 Xi Pardee 2025-06-21 1547 guid = pmc_core_find_guid(pmcdev->regmap_list, pmc->map);
> d7bc7e19147769 Xi Pardee 2025-06-21 1548 if (!guid)
> d7bc7e19147769 Xi Pardee 2025-06-21 1549 return -ENXIO;
> d7bc7e19147769 Xi Pardee 2025-06-21 1550
> d7bc7e19147769 Xi Pardee 2025-06-21 1551 ep = pmt_telem_find_and_register_endpoint(pcidev, guid, 0);
> d7bc7e19147769 Xi Pardee 2025-06-21 1552 if (IS_ERR(ep)) {
> d7bc7e19147769 Xi Pardee 2025-06-21 1553 dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep);
> d7bc7e19147769 Xi Pardee 2025-06-21 1554 return -EPROBE_DEFER;
> d7bc7e19147769 Xi Pardee 2025-06-21 1555 }
> d7bc7e19147769 Xi Pardee 2025-06-21 1556
> f3435ca196060d Xi Pardee 2025-06-21 1557 if (telem_info & SUB_REQ_LPM)
> d7bc7e19147769 Xi Pardee 2025-06-21 1558 ret = pmc_core_pmt_get_lpm_req(pmcdev, pmc, ep);
>
> ret is uninitialized on else path. I generally encourage developers
> to set CONFIG_INIT_STACK_ALL_PATTERN=y for their testing.
Changed to only check ret value in the if condition in version 2.
> 78a7491d5cba8b Xi Pardee 2025-04-09 @1559 if (ret)
> f3435ca196060d Xi Pardee 2025-06-21 1560 goto unregister_ep;
> f3435ca196060d Xi Pardee 2025-06-21 1561
> f3435ca196060d Xi Pardee 2025-06-21 1562 if (telem_info & SUB_REQ_BLK)
> f3435ca196060d Xi Pardee 2025-06-21 1563 ret = pmc_core_pmt_get_blk_sub_req(pmcdev, pmc, ep);
> f3435ca196060d Xi Pardee 2025-06-21 1564 if (ret)
> f3435ca196060d Xi Pardee 2025-06-21 1565 goto unregister_ep;
> f3435ca196060d Xi Pardee 2025-06-21 1566
> f3435ca196060d Xi Pardee 2025-06-21 1567 pmt_telem_unregister_endpoint(ep);
> 78a7491d5cba8b Xi Pardee 2025-04-09 1568 }
> 78a7491d5cba8b Xi Pardee 2025-04-09 1569
> 78a7491d5cba8b Xi Pardee 2025-04-09 1570 return 0;
> f3435ca196060d Xi Pardee 2025-06-21 1571
> f3435ca196060d Xi Pardee 2025-06-21 1572 unregister_ep:
> f3435ca196060d Xi Pardee 2025-06-21 1573 pmt_telem_unregister_endpoint(ep);
> f3435ca196060d Xi Pardee 2025-06-21 1574 return ret;
> 78a7491d5cba8b Xi Pardee 2025-04-09 1575 }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-25 6:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 10:50 [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-06-21 21:05 [PATCH v1 0/5] Enable SSRAM support in PTL and LNL Xi Pardee
2025-06-21 21:05 ` [PATCH v1 4/5] platform/x86:intel/pmc: Show substate requirement for S0ix blockers Xi Pardee
2025-06-24 14:45 ` Dan Carpenter
2025-06-24 18:56 ` Xi Pardee
2025-06-25 6:42 ` Xi Pardee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.