[PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Bart Van Assche]

Change "resourse" into "resource" in the name of a sysfs attribute.

Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 Documentation/ABI/testing/sysfs-driver-ufs | 2 +-
 drivers/ufs/core/ufs-sysfs.c               | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
index f3de8c521bbd..a90612ab5780 100644
--- a/Documentation/ABI/testing/sysfs-driver-ufs
+++ b/Documentation/ABI/testing/sysfs-driver-ufs
@@ -711,7 +711,7 @@ Description:	This file shows the thin provisioning type. This is one of
 
 		The file is read only.
 
-What:		/sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resourse_count
+What:		/sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resource_count
 Date:		February 2018
 Contact:	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
 Description:	This file shows the total physical memory resources. This is
diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c
index 10006ae5ee35..00948378a719 100644
--- a/drivers/ufs/core/ufs-sysfs.c
+++ b/drivers/ufs/core/ufs-sysfs.c
@@ -1998,7 +1998,7 @@ UFS_UNIT_DESC_PARAM(logical_block_size, _LOGICAL_BLK_SIZE, 1);
 UFS_UNIT_DESC_PARAM(logical_block_count, _LOGICAL_BLK_COUNT, 8);
 UFS_UNIT_DESC_PARAM(erase_block_size, _ERASE_BLK_SIZE, 4);
 UFS_UNIT_DESC_PARAM(provisioning_type, _PROVISIONING_TYPE, 1);
-UFS_UNIT_DESC_PARAM(physical_memory_resourse_count, _PHY_MEM_RSRC_CNT, 8);
+UFS_UNIT_DESC_PARAM(physical_memory_resource_count, _PHY_MEM_RSRC_CNT, 8);
 UFS_UNIT_DESC_PARAM(context_capabilities, _CTX_CAPABILITIES, 2);
 UFS_UNIT_DESC_PARAM(large_unit_granularity, _LARGE_UNIT_SIZE_M1, 1);
 UFS_UNIT_DESC_PARAM(wb_buf_alloc_units, _WB_BUF_ALLOC_UNITS, 4);
@@ -2015,7 +2015,7 @@ static struct attribute *ufs_sysfs_unit_descriptor[] = {
 	&dev_attr_logical_block_count.attr,
 	&dev_attr_erase_block_size.attr,
 	&dev_attr_provisioning_type.attr,
-	&dev_attr_physical_memory_resourse_count.attr,
+	&dev_attr_physical_memory_resource_count.attr,
 	&dev_attr_context_capabilities.attr,
 	&dev_attr_large_unit_granularity.attr,
 	&dev_attr_wb_buf_alloc_units.attr,

RE: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Avri Altman]

> Change "resourse" into "resource" in the name of a sysfs attribute.
> 
> Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Avri Altman <avri.altman@sandisk.com>

Re: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Peter Wang (王信友)]

On Tue, 2025-06-24 at 11:16 -0700, Bart Van Assche wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Change "resourse" into "resource" in the name of a sysfs attribute.
> 
> Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>


Reviewed-by: Peter Wang <peter.wang@mediatek.com>

Re: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Greg Kroah-Hartman]

On Tue, Jun 24, 2025 at 11:16:44AM -0700, Bart Van Assche wrote:
> Change "resourse" into "resource" in the name of a sysfs attribute.
> 
> Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  Documentation/ABI/testing/sysfs-driver-ufs | 2 +-
>  drivers/ufs/core/ufs-sysfs.c               | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
> index f3de8c521bbd..a90612ab5780 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -711,7 +711,7 @@ Description:	This file shows the thin provisioning type. This is one of
>  
>  		The file is read only.
>  
> -What:		/sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resourse_count
> +What:		/sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resource_count
>  Date:		February 2018

As you are changing the name of a sysfs file that has been in the kernel
for a very long time, what userspace code is now going to break that was
using the old name?

thanks,

greg k-h

RE: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Avri Altman]

> On Tue, Jun 24, 2025 at 11:16:44AM -0700, Bart Van Assche wrote:
> > Change "resourse" into "resource" in the name of a sysfs attribute.
> >
> > Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > ---
> >  Documentation/ABI/testing/sysfs-driver-ufs | 2 +-
> >  drivers/ufs/core/ufs-sysfs.c               | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > b/Documentation/ABI/testing/sysfs-driver-ufs
> > index f3de8c521bbd..a90612ab5780 100644
> > --- a/Documentation/ABI/testing/sysfs-driver-ufs
> > +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > @@ -711,7 +711,7 @@ Description:      This file shows the thin provisioning
> type. This is one of
> >
> >               The file is read only.
> >
> > -What:
> /sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resourse_cou
> nt
> > +What:
> /sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resource_cou
> nt
> >  Date:                February 2018
> 
> As you are changing the name of a sysfs file that has been in the kernel for a very
> long time, what userspace code is now going to break that was using the old
> name?
AFAIK none.

Thanks,
Avri

> 
> thanks,
> 
> greg k-h

Re: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Greg Kroah-Hartman]

On Wed, Jun 25, 2025 at 09:18:27AM +0000, Avri Altman wrote:
> > On Tue, Jun 24, 2025 at 11:16:44AM -0700, Bart Van Assche wrote:
> > > Change "resourse" into "resource" in the name of a sysfs attribute.
> > >
> > > Fixes: d829fc8a1058 ("scsi: ufs: sysfs: unit descriptor")
> > > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > > ---
> > >  Documentation/ABI/testing/sysfs-driver-ufs | 2 +-
> > >  drivers/ufs/core/ufs-sysfs.c               | 4 ++--
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > > b/Documentation/ABI/testing/sysfs-driver-ufs
> > > index f3de8c521bbd..a90612ab5780 100644
> > > --- a/Documentation/ABI/testing/sysfs-driver-ufs
> > > +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > > @@ -711,7 +711,7 @@ Description:      This file shows the thin provisioning
> > type. This is one of
> > >
> > >               The file is read only.
> > >
> > > -What:
> > /sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resourse_cou
> > nt
> > > +What:
> > /sys/class/scsi_device/*/device/unit_descriptor/physical_memory_resource_cou
> > nt
> > >  Date:                February 2018
> > 
> > As you are changing the name of a sysfs file that has been in the kernel for a very
> > long time, what userspace code is now going to break that was using the old
> > name?
> AFAIK none.

So if no tool needs / uses this, why not just delete the attribute
entirely as obviously it's not necessary :)

RE: [PATCH] scsi: ufs: core: Fix spelling of a sysfs attribute name

[Avri Altman]

> > > As you are changing the name of a sysfs file that has been in the
> > > kernel for a very long time, what userspace code is now going to
> > > break that was using the old name?
> > AFAIK none.
> 
> So if no tool needs / uses this, why not just delete the attribute entirely as
> obviously it's not necessary :)
We can still read it manually should we need to.
We do that from time to time.

Thanks,
Avri

>