Re: [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 2 Jul 2025 08:47:08 +0800 Jason Xing wrote:
> >  static int bnxt_request_irq(struct bnxt *bp)
> >  {
> > +       struct cpu_rmap *rmap = NULL;
> >         int i, j, rc = 0;
> >         unsigned long flags = 0;
> > -#ifdef CONFIG_RFS_ACCEL
> > -       struct cpu_rmap *rmap;
> > -#endif  
> 
> Sorry, Jakub. I failed to see the positive point of this kind of
> change comparatively.

Like Simon said -- fewer #ifdefs leads to fewer bugs of this nature.
Or do you mean that you don't understand how my fix works?

> >         rc = bnxt_setup_int_mode(bp);
> >         if (rc) {  
> 
> Probably in this position, you expect 'rmap = bp->dev->rx_cpu_rmap;'
> to stay there even when CONFIG_RFS_ACCEL is off?

no, dev->rx_cpu_rmap doesn't exist if RDS_ACCEL=n

> The report says it's 'j' that causes the complaint.