From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Simon Horman <horms@kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL
Date: Tue, 1 Jul 2025 18:34:27 -0700 [thread overview]
Message-ID: <20250701183427.497e5f24@kernel.org> (raw)
In-Reply-To: <CAL+tcoA8+gGaOhAC4p743Ah9fVbmVwk8AT8zHH7SpFr2-pmm=A@mail.gmail.com>
On Wed, 2 Jul 2025 09:11:35 +0800 Jason Xing wrote:
> > >
> > > Like Simon said -- fewer #ifdefs leads to fewer bugs of this nature.
> >
> > Agree on this point.
> >
> > > Or do you mean that you don't understand how my fix works?
>
> Oh, thanks to the word 'fix' you mentioned. It seems that I'm supposed
> to add Fixes: tag...
Yes, change the commit reference to a full Fixes tag.
Also -- may be worth mentioning that it happens with GCC specifically.
My first try to reproduce was with clang and it seems not to show this
warning even with W=1
next prev parent reply other threads:[~2025-07-02 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 0:36 [PATCH net] bnxt_en: eliminate the compile warning in bnxt_request_irq due to CONFIG_RFS_ACCEL Jason Xing
2025-06-30 11:09 ` Simon Horman
2025-06-30 11:47 ` Jason Xing
2025-07-02 0:15 ` Jakub Kicinski
2025-07-02 0:47 ` Jason Xing
2025-07-02 0:56 ` Jakub Kicinski
2025-07-02 1:07 ` Jason Xing
2025-07-02 1:11 ` Jason Xing
2025-07-02 1:34 ` Jakub Kicinski [this message]
2025-07-01 4:07 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701183427.497e5f24@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=lkp@intel.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.